Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Reset the UnifiedHistogram chart when data view changes #200222

Closed
wants to merge 6 commits into from

Conversation

jughosta
Copy link
Contributor

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_node:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 14, 2024
@jughosta jughosta self-assigned this Nov 14, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 14, 2024

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 14, 2024

💔 Build Failed

Failed CI Steps

History

cc @jughosta

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7408

[❌] test/functional/apps/discover/group3/config.ts: 0/100 tests passed.

see run history

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 14, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #46 / Discover discover async search should should clean the search session when navigating to ESQL mode, and reinitialize when navigating back
  • [job] [logs] FTR Configs #46 / Discover discover async search should should clean the search session when navigating to ESQL mode, and reinitialize when navigating back
  • [job] [logs] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group5.ts / discover/group3 discover request counts data view mode should send 2 requests (documents + chart) when changing the data view
  • [job] [logs] FTR Configs #28 / discover/group3 discover request counts data view mode should send 2 requests (documents + chart) when changing the data view
  • [job] [logs] FTR Configs #42 / discover/group3 discover request counts data view mode should send 2 requests (documents + chart) when changing the data view
  • [job] [logs] FTR Configs #44 / discover/group3 discover request counts data view mode should send 2 requests (documents + chart) when changing the data view
  • [job] [logs] x-pack/test_serverless/functional/test_suites/security/common_configs/config.group5.ts / discover/group3 discover request counts data view mode should send 2 requests (documents + chart) when changing the data view
  • [job] [logs] FTR Configs #28 / discover/group3 discover request counts data view mode should send 2 requests (documents + chart) when changing the data view
  • [job] [logs] FTR Configs #44 / discover/group3 discover request counts data view mode should send 2 requests (documents + chart) when changing the data view
  • [job] [logs] FTR Configs #42 / discover/group3 discover request counts data view mode should send 2 requests (documents + chart) when changing the data view
  • [job] [logs] FTR Configs #43 / serverless search UI Elasticsearch Start [Onboarding Empty State] developer should show the api key in code view
  • [job] [logs] FTR Configs #43 / serverless search UI Elasticsearch Start [Onboarding Empty State] developer should show the api key in code view

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [ed002ec]

History

cc @jughosta

@jughosta jughosta closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants