Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM][9.0] Adding kibana upgrade deprecation warning apm_user removed #200163

Merged
merged 16 commits into from
Nov 20, 2024
Merged

[APM][9.0] Adding kibana upgrade deprecation warning apm_user removed #200163

merged 16 commits into from
Nov 20, 2024

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Nov 14, 2024 •
edited
Loading

Related to: elastic/elasticsearch#116712

Meta issue: #116760
The apm_user role was elastic/elasticsearch#68749 in 7.13 and was supposed to be removed in 8.0.
All mentions of apm_user role were finally removed in #132790.

This PR adds some deprecation steps for users are using the apm_user.

Screenshot 2024-11-18 at 14 10 08 Screenshot 2024-11-18 at 14 10 18 Screenshot 2024-11-14 at 13 12 01

@cauemarcondes cauemarcondes added release_note:breaking backport:skip This commit does not require backporting v9.0.0 labels Nov 14, 2024
@cauemarcondes cauemarcondes requested a review from a team as a code owner November 14, 2024 12:38
@azasypkin azasypkin self-requested a review November 14, 2024 13:00
@cauemarcondes cauemarcondes requested a review from a team as a code owner November 14, 2024 13:48
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Nov 14, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@cauemarcondes cauemarcondes removed the request for review from a team November 14, 2024 13:49
@colleenmcginnis colleenmcginnis self-requested a review November 14, 2024 17:16
colleenmcginnis
colleenmcginnis reviewed Nov 14, 2024
View reviewed changes
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cauemarcondes @mdbirnstiehl I added a couple suggestions below. Let me know what you think.

x-pack/plugins/observability_solution/apm/server/deprecations/apm_user_role.ts Outdated Show resolved Hide resolved
x-pack/plugins/observability_solution/apm/server/deprecations/apm_user_role.ts Outdated Show resolved Hide resolved
@cauemarcondes cauemarcondes changed the title [APM] Adding kibana upgrade deprecation warning apm_user removed [APM][9.0] Adding kibana upgrade deprecation warning apm_user removed Nov 18, 2024
crespocarlos
crespocarlos reviewed Nov 19, 2024
View reviewed changes
x-pack/plugins/observability_solution/apm/server/deprecations/apm_user_role.ts Outdated Show resolved Hide resolved
x-pack/plugins/observability_solution/apm/server/deprecations/apm_user_role.ts Outdated Show resolved Hide resolved
x-pack/plugins/observability_solution/apm/server/deprecations/apm_user_role.ts Outdated Show resolved Hide resolved
x-pack/plugins/observability_solution/apm/server/deprecations/apm_user_role.ts Outdated Show resolved Hide resolved
x-pack/plugins/observability_solution/apm/server/deprecations/apm_user_role.ts Outdated Show resolved Hide resolved
x-pack/plugins/observability_solution/apm/server/deprecations/apm_user_role.ts Outdated Show resolved Hide resolved
x-pack/plugins/observability_solution/apm/server/deprecations/apm_user_role.ts Outdated Show resolved Hide resolved
crespocarlos
crespocarlos approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azasypkin
Copy link
Member

ACK: will review today

azasypkin
azasypkin approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

x-pack/plugins/observability_solution/apm/server/deprecations/apm_user_role.ts Outdated Show resolved Hide resolved
x-pack/plugins/observability_solution/apm/server/deprecations/apm_user_role.ts Outdated Show resolved Hide resolved
x-pack/plugins/observability_solution/apm/server/deprecations/apm_user_role.ts Outdated Show resolved Hide resolved
x-pack/plugins/observability_solution/apm/server/deprecations/apm_user_role.ts Outdated Show resolved Hide resolved
x-pack/plugins/observability_solution/apm/server/deprecations/apm_user_role.ts Outdated Show resolved Hide resolved
x-pack/plugins/observability_solution/apm/server/deprecations/apm_user_role.ts Outdated Show resolved Hide resolved
x-pack/plugins/observability_solution/apm/server/deprecations/apm_user_role.ts Show resolved Hide resolved
@cauemarcondes cauemarcondes enabled auto-merge (squash) November 20, 2024 10:17
@elasticmachine
Copy link
Contributor

⏳ Build in-progress

  • Buildkite Build
  • Commit: 38439ef
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-200163-38439efb1c4f

History

@cauemarcondes cauemarcondes merged commit a4ef281 into elastic:main Nov 20, 2024
25 checks passed
@cauemarcondes cauemarcondes deleted the apm-remove-apm-user branch November 20, 2024 13:18
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
@cauemarcondes @paulinashakirova
[APM][9.0] Adding kibana upgrade deprecation warning apm_user removed (…
8c1485b 
…elastic#200163)

Related to: elastic/elasticsearch#116712

Meta issue: elastic#116760
The apm_user role was
elastic/elasticsearch#68749 in 7.13 and was
supposed to be removed in 8.0.
All mentions of apm_user role were finally removed in
elastic#132790.

This PR adds some deprecation steps for users are using the `apm_user`.

<img width="494" alt="Screenshot 2024-11-18 at 14 10 08"
src="https://github.com/user-attachments/assets/e04fff63-b56e-4a74-93ad-a87884f9a8a6">
<img width="1128" alt="Screenshot 2024-11-18 at 14 10 18"
src="https://github.com/user-attachments/assets/de67afcf-8bd5-4896-815a-4e1adc730681">

<img width="1241" alt="Screenshot 2024-11-14 at 13 12 01"
src="https://github.com/user-attachments/assets/e94b0367-b459-45b4-923e-1de7a095b6b8">
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@cauemarcondes @CAWilson94
[APM][9.0] Adding kibana upgrade deprecation warning apm_user removed (…
2ebe2de 
…elastic#200163)

Related to: elastic/elasticsearch#116712

Meta issue: elastic#116760
The apm_user role was
elastic/elasticsearch#68749 in 7.13 and was
supposed to be removed in 8.0.
All mentions of apm_user role were finally removed in
elastic#132790.

This PR adds some deprecation steps for users are using the `apm_user`.

<img width="494" alt="Screenshot 2024-11-18 at 14 10 08"
src="https://github.com/user-attachments/assets/e04fff63-b56e-4a74-93ad-a87884f9a8a6">
<img width="1128" alt="Screenshot 2024-11-18 at 14 10 18"
src="https://github.com/user-attachments/assets/de67afcf-8bd5-4896-815a-4e1adc730681">

<img width="1241" alt="Screenshot 2024-11-14 at 13 12 01"
src="https://github.com/user-attachments/assets/e94b0367-b459-45b4-923e-1de7a095b6b8">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdbirnstiehl mdbirnstiehl mdbirnstiehl left review comments

@colleenmcginnis colleenmcginnis colleenmcginnis left review comments

@crespocarlos crespocarlos crespocarlos approved these changes

@azasypkin azasypkin azasypkin approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:breaking Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cauemarcondes @elasticmachine @azasypkin @crespocarlos @colleenmcginnis @mdbirnstiehl