Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flashing banner when creating pipeline #199786

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Fix flashing banner when creating pipeline #199786

merged 3 commits into from
Nov 19, 2024

Conversation

SoniaSanzV
Copy link
Contributor

@SoniaSanzV SoniaSanzV commented Nov 12, 2024 •
edited by kibanamachine
Loading

Closes #197810

Summary

The isValid verification wasn't taken into account if the form was in isSubmitting state.

flashing banner

@SoniaSanzV SoniaSanzV added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Ingest Node Pipelines Ingest node pipelines management backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 12, 2024
@SoniaSanzV SoniaSanzV self-assigned this Nov 12, 2024
@SoniaSanzV SoniaSanzV requested a review from a team as a code owner November 12, 2024 13:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ingestPipelines 405.3KB 405.3KB +17.0B

History

cc @SoniaSanzV

sabarasaba
sabarasaba approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@sabarasaba sabarasaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm, tested locally 🚀 Nice work @SoniaSanzV!

@SoniaSanzV SoniaSanzV merged commit 48158d4 into elastic:main Nov 19, 2024
21 checks passed
@SoniaSanzV SoniaSanzV deleted the pipelines_flashing_banner branch November 19, 2024 15:21
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11916168746

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 19, 2024
@SoniaSanzV
Fix flashing banner when creating pipeline (elastic#199786)
5d96825 
Closes [elastic#197810](elastic#197810)

## Summary
The `isValid` verification wasn't taken into account if the form was in
`isSubmitting` state.

![flashing
banner](https://github.com/user-attachments/assets/6f9173ff-7f2c-46a5-99cc-31fdd699404e)

(cherry picked from commit 48158d4)
@kibanamachine kibanamachine mentioned this pull request Nov 19, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 19, 2024
@kibanamachine @SoniaSanzV
[8.x] Fix flashing banner when creating pipeline (#199786) (#200760)
086a448 
# Backport

This will backport the following commits from `main` to `8.x`:
- [Fix flashing banner when creating pipeline
(#199786)](#199786)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sonia Sanz
Vivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-19T15:21:23Z","message":"Fix
flashing banner when creating pipeline (#199786)\n\nCloses
[#197810](https://github.com/elastic/kibana/issues/197810)\r\n\r\n##
Summary\r\nThe `isValid` verification wasn't taken into account if the
form was in\r\n`isSubmitting`
state.\r\n\r\n\r\n![flashing\r\nbanner](https://github.com/user-attachments/assets/6f9173ff-7f2c-46a5-99cc-31fdd699404e)","sha":"48158d49269e8134f99faa822be1acd53a04326f","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana
Management","release_note:skip","v9.0.0","Feature:Ingest Node
Pipelines","backport:prev-minor"],"title":"Fix flashing banner when
creating
pipeline","number":199786,"url":"https://github.com/elastic/kibana/pull/199786","mergeCommit":{"message":"Fix
flashing banner when creating pipeline (#199786)\n\nCloses
[#197810](https://github.com/elastic/kibana/issues/197810)\r\n\r\n##
Summary\r\nThe `isValid` verification wasn't taken into account if the
form was in\r\n`isSubmitting`
state.\r\n\r\n\r\n![flashing\r\nbanner](https://github.com/user-attachments/assets/6f9173ff-7f2c-46a5-99cc-31fdd699404e)","sha":"48158d49269e8134f99faa822be1acd53a04326f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199786","number":199786,"mergeCommit":{"message":"Fix
flashing banner when creating pipeline (#199786)\n\nCloses
[#197810](https://github.com/elastic/kibana/issues/197810)\r\n\r\n##
Summary\r\nThe `isValid` verification wasn't taken into account if the
form was in\r\n`isSubmitting`
state.\r\n\r\n\r\n![flashing\r\nbanner](https://github.com/user-attachments/assets/6f9173ff-7f2c-46a5-99cc-31fdd699404e)","sha":"48158d49269e8134f99faa822be1acd53a04326f"}}]}]
BACKPORT-->

Co-authored-by: Sonia Sanz Vivas <[email protected]>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
@SoniaSanzV @paulinashakirova
Fix flashing banner when creating pipeline (elastic#199786)
552c446 
Closes [elastic#197810](elastic#197810)

## Summary
The `isValid` verification wasn't taken into account if the form was in
`isSubmitting` state.


![flashing
banner](https://github.com/user-attachments/assets/6f9173ff-7f2c-46a5-99cc-31fdd699404e)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@SoniaSanzV @CAWilson94
Fix flashing banner when creating pipeline (elastic#199786)
bc2fc72 
Closes [elastic#197810](elastic#197810)

## Summary
The `isValid` verification wasn't taken into account if the form was in
`isSubmitting` state.


![flashing
banner](https://github.com/user-attachments/assets/6f9173ff-7f2c-46a5-99cc-31fdd699404e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabarasaba sabarasaba sabarasaba approved these changes

Assignees

@SoniaSanzV SoniaSanzV

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Ingest Node Pipelines] Flashing error banner when creating pipeline
4 participants
@SoniaSanzV @elasticmachine @kibanamachine @sabarasaba