[IndexAdapter] Extract index-adapter package from data-stream-adapter #199575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semd
added
release_note:skip
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --update'
…package' into index_adapter_base_package
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
kapral18
reviewed
Nov 11, 2024
kapral18
reviewed
Nov 12, 2024
Comment on lines
19
to
20
| const simulateIndexTemplateResponse = { template: { mappings: { is_managed: true } } }; | ||
| // @ts-expect-error test data type mismatch |
There was a problem hiding this comment.
Let me know if there is a specific reason behind the shape you use here, because the following makes both type check and tests pass:
Suggested change
| const simulateIndexTemplateResponse = { template: { mappings: { is_managed: true } } }; | |
| // @ts-expect-error test data type mismatch | |
| const simulateIndexTemplateResponse = { | |
| template: { | |
| settings: {}, | |
| aliases: {}, | |
| mappings: {}, | |
| }, | |
| }; |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Public APIs missing exports
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
cc @semd |
|
Starting backport for target branches: 8.18, 8.x https://github.com/elastic/kibana/actions/runs/11802336660 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
semd
added a commit
to semd/kibana
that referenced
this pull request
Nov 12, 2024
…elastic#199575) ## Summary Extracts `IndexAdapter` from `DataStreamAdapter` and `IndexPatternAdapter` from `DataStreamSpaceAdapter`. There are no breaking changes for the _data-stream-adapter_ package; the behavior of both the `DataStreamAdapter` and `DataStreamSpaceAdapter` remains unchanged. The new _index-adapter_ package exports `IndexAdapter` and `IndexPatternAdapter` to manage individual indices without using data streams. This is needed for SIEM rule migrations. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 9a9f02c) # Conflicts: # .github/CODEOWNERS # package.json # tsconfig.base.json # yarn.lock
semd
added a commit
that referenced
this pull request
Nov 12, 2024
…dapter (#199575) (#199848) # Backport This will backport the following commits from `main` to `8.x`: - [[IndexAdapter] Extract index-adapter package from data-stream-adapter (#199575)](#199575) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Massaneda","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-12T17:16:32Z","message":"[IndexAdapter] Extract index-adapter package from data-stream-adapter (#199575)\n\n## Summary\r\n\r\nExtracts `IndexAdapter` from `DataStreamAdapter` and\r\n`IndexPatternAdapter` from `DataStreamSpaceAdapter`.\r\n\r\nThere are no breaking changes for the _data-stream-adapter_ package; the\r\nbehavior of both the `DataStreamAdapter` and `DataStreamSpaceAdapter`\r\nremains unchanged.\r\n\r\nThe new _index-adapter_ package exports `IndexAdapter` and\r\n`IndexPatternAdapter` to manage individual indices without using data\r\nstreams.\r\n\r\nThis is needed for SIEM rule migrations.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"9a9f02c9315beda4089b1ef16089747c080bc345","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting","Team: SecuritySolution","backport:prev-minor","v8.18.0"],"number":199575,"url":"https://github.com/elastic/kibana/pull/199575","mergeCommit":{"message":"[IndexAdapter] Extract index-adapter package from data-stream-adapter (#199575)\n\n## Summary\r\n\r\nExtracts `IndexAdapter` from `DataStreamAdapter` and\r\n`IndexPatternAdapter` from `DataStreamSpaceAdapter`.\r\n\r\nThere are no breaking changes for the _data-stream-adapter_ package; the\r\nbehavior of both the `DataStreamAdapter` and `DataStreamSpaceAdapter`\r\nremains unchanged.\r\n\r\nThe new _index-adapter_ package exports `IndexAdapter` and\r\n`IndexPatternAdapter` to manage individual indices without using data\r\nstreams.\r\n\r\nThis is needed for SIEM rule migrations.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"9a9f02c9315beda4089b1ef16089747c080bc345"}},"sourceBranch":"main","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199575","number":199575,"mergeCommit":{"message":"[IndexAdapter] Extract index-adapter package from data-stream-adapter (#199575)\n\n## Summary\r\n\r\nExtracts `IndexAdapter` from `DataStreamAdapter` and\r\n`IndexPatternAdapter` from `DataStreamSpaceAdapter`.\r\n\r\nThere are no breaking changes for the _data-stream-adapter_ package; the\r\nbehavior of both the `DataStreamAdapter` and `DataStreamSpaceAdapter`\r\nremains unchanged.\r\n\r\nThe new _index-adapter_ package exports `IndexAdapter` and\r\n`IndexPatternAdapter` to manage individual indices without using data\r\nstreams.\r\n\r\nThis is needed for SIEM rule migrations.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"9a9f02c9315beda4089b1ef16089747c080bc345"}},{"branch":"8.18","label":"v8.18.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
tkajtoch
pushed a commit
to tkajtoch/kibana
that referenced
this pull request
Nov 12, 2024
…elastic#199575) ## Summary Extracts `IndexAdapter` from `DataStreamAdapter` and `IndexPatternAdapter` from `DataStreamSpaceAdapter`. There are no breaking changes for the _data-stream-adapter_ package; the behavior of both the `DataStreamAdapter` and `DataStreamSpaceAdapter` remains unchanged. The new _index-adapter_ package exports `IndexAdapter` and `IndexPatternAdapter` to manage individual indices without using data streams. This is needed for SIEM rule migrations. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
…elastic#199575) ## Summary Extracts `IndexAdapter` from `DataStreamAdapter` and `IndexPatternAdapter` from `DataStreamSpaceAdapter`. There are no breaking changes for the _data-stream-adapter_ package; the behavior of both the `DataStreamAdapter` and `DataStreamSpaceAdapter` remains unchanged. The new _index-adapter_ package exports `IndexAdapter` and `IndexPatternAdapter` to manage individual indices without using data streams. This is needed for SIEM rule migrations. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
…elastic#199575) ## Summary Extracts `IndexAdapter` from `DataStreamAdapter` and `IndexPatternAdapter` from `DataStreamSpaceAdapter`. There are no breaking changes for the _data-stream-adapter_ package; the behavior of both the `DataStreamAdapter` and `DataStreamSpaceAdapter` remains unchanged. The new _index-adapter_ package exports `IndexAdapter` and `IndexPatternAdapter` to manage individual indices without using data streams. This is needed for SIEM rule migrations. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extracts
IndexAdapterfromDataStreamAdapterandIndexPatternAdapterfromDataStreamSpaceAdapter.There are no breaking changes for the data-stream-adapter package; the behavior of both the
DataStreamAdapterandDataStreamSpaceAdapterremains unchanged.The new index-adapter package exports
IndexAdapterandIndexPatternAdapterto manage individual indices without using data streams.This is needed for SIEM rule migrations.