[Security Solution][Session view] - fix EuiButton key not unique throwing error #199497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
maxcold
approved these changes
Nov 8, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11746308928 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 8, 2024
…wing error (elastic#199497) ## Summary This PR fixes a very small console error because of a EuiButton key that is not unique in the Session View component. Before fix https://github.com/user-attachments/assets/930adc5d-1505-43c1-ac2f-451172e803e5 After fix https://github.com/user-attachments/assets/5a4a824d-d048-4822-a930-a30bb87336cc (cherry picked from commit 3124a72)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 8, 2024
…e throwing error (#199497) (#199518) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Session view] - fix EuiButton key not unique throwing error (#199497)](#199497) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-08T17:01:07Z","message":"[Security Solution][Session view] - fix EuiButton key not unique throwing error (#199497)\n\n## Summary\r\n\r\nThis PR fixes a very small console error because of a EuiButton key that\r\nis not unique in the Session View component.\r\n\r\nBefore fix\r\n\r\n\r\nhttps://github.com/user-attachments/assets/930adc5d-1505-43c1-ac2f-451172e803e5\r\n\r\nAfter fix\r\n\r\n\r\nhttps://github.com/user-attachments/assets/5a4a824d-d048-4822-a930-a30bb87336cc","sha":"3124a72e67b3121afbaafcf92d90a363ceb7d6a9","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:version","v8.17.0"],"title":"[Security Solution][Session view] - fix EuiButton key not unique throwing error","number":199497,"url":"https://github.com/elastic/kibana/pull/199497","mergeCommit":{"message":"[Security Solution][Session view] - fix EuiButton key not unique throwing error (#199497)\n\n## Summary\r\n\r\nThis PR fixes a very small console error because of a EuiButton key that\r\nis not unique in the Session View component.\r\n\r\nBefore fix\r\n\r\n\r\nhttps://github.com/user-attachments/assets/930adc5d-1505-43c1-ac2f-451172e803e5\r\n\r\nAfter fix\r\n\r\n\r\nhttps://github.com/user-attachments/assets/5a4a824d-d048-4822-a930-a30bb87336cc","sha":"3124a72e67b3121afbaafcf92d90a363ceb7d6a9"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199497","number":199497,"mergeCommit":{"message":"[Security Solution][Session view] - fix EuiButton key not unique throwing error (#199497)\n\n## Summary\r\n\r\nThis PR fixes a very small console error because of a EuiButton key that\r\nis not unique in the Session View component.\r\n\r\nBefore fix\r\n\r\n\r\nhttps://github.com/user-attachments/assets/930adc5d-1505-43c1-ac2f-451172e803e5\r\n\r\nAfter fix\r\n\r\n\r\nhttps://github.com/user-attachments/assets/5a4a824d-d048-4822-a930-a30bb87336cc","sha":"3124a72e67b3121afbaafcf92d90a363ceb7d6a9"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a very small console error because of a EuiButton key that is not unique in the Session View component.
Before fix
Screen.Recording.2024-11-08.at.8.58.36.AM.mov
After fix
Screen.Recording.2024-11-08.at.9.01.48.AM.mov