Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): onboarding console bulk import code #199487

Conversation

TattdCodeMonkey
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey commented Nov 8, 2024

Summary

ensure console code has correct new lines for bulk import

@TattdCodeMonkey TattdCodeMonkey added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Search backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.17.0 labels Nov 8, 2024
@TattdCodeMonkey TattdCodeMonkey requested a review from a team as a code owner November 8, 2024 14:38
@TattdCodeMonkey TattdCodeMonkey enabled auto-merge (squash) November 8, 2024 16:10
@TattdCodeMonkey TattdCodeMonkey merged commit a55ad44 into elastic:main Nov 8, 2024
34 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #56 / ObservabilityApp Observability Rules page Create rules flyout "after each" hook for "Should allow the user to select consumers when creating ES query rules"
  • [job] [logs] FTR Configs #56 / ObservabilityApp Observability Rules page Create rules flyout Should allow the user to select consumers when creating ES query rules

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchIndices 159.4KB 159.4KB +2.0B

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11745958912

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 8, 2024
## Summary

ensure console code has correct new lines for bulk import

(cherry picked from commit a55ad44)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 8, 2024
…9516)

# Backport

This will backport the following commits from `main` to `8.x`:
- [fix(search): onboarding console bulk import code
(#199487)](#199487)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Rodney
Norris","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-08T16:36:58Z","message":"fix(search):
onboarding console bulk import code (#199487)\n\n##
Summary\r\n\r\nensure console code has correct new lines for bulk
import","sha":"a55ad44808751137a28c59652eed1c64c965ea36","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor","v8.17.0"],"title":"fix(search):
onboarding console bulk import
code","number":199487,"url":"https://github.com/elastic/kibana/pull/199487","mergeCommit":{"message":"fix(search):
onboarding console bulk import code (#199487)\n\n##
Summary\r\n\r\nensure console code has correct new lines for bulk
import","sha":"a55ad44808751137a28c59652eed1c64c965ea36"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199487","number":199487,"mergeCommit":{"message":"fix(search):
onboarding console bulk import code (#199487)\n\n##
Summary\r\n\r\nensure console code has correct new lines for bulk
import","sha":"a55ad44808751137a28c59652eed1c64c965ea36"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Rodney Norris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Search v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants