Open links in new tabs from pages in Fleet integrations #199468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
albertoblaz
added
Team:Cloud Security
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
botelastic
bot
added
the
Team:Fleet
💚 Build Succeeded
Metrics [docs]Async chunks
cc @albertoblaz |
albertoblaz
changed the title
albertoblaz
added
backport:prev-major
maxcold
approved these changes
Nov 8, 2024
|
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11746804075 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 8, 2024
## Summary Closes elastic/security-team#10987. Fleet integrations render pages whose source content is written in Markdown format. Links in markdown were being converted into regular `<a>` tags rather than in `<EuiLink>` components that include styling for external links and open in new tabs. Also, the "API Reference" page rendered a "Learn more" link using a `<EuiLink>` component with external styling but missed `target="_blank"`, so it wasn't acting as an external link and didn't open in a new tab either. ### Bug origin This bug has dragged for the last 3 years since `react-markdown` upgraded to `v6.0` and introduced a [breaking change](https://github.com/remarkjs/react-markdown/blob/main/changelog.md#600---2021-04-15) in custom renderers ### Screenshots <details><summary>Overview page</summary> <img width="1406" alt="Screenshot 2024-11-08 at 13 35 43" src="https://github.com/user-attachments/assets/b11262f1-0b1e-45e5-baa9-d69727643b08"> </details> <details><summary>API Reference page</summary> <img width="2021" alt="Screenshot 2024-11-08 at 13 35 07" src="https://github.com/user-attachments/assets/7e073df2-0451-4e9d-b80c-878cfcdd6c58"> </details> ### Checklist Delete any items that are not applicable to this PR. - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 763410c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 8, 2024
## Summary Closes elastic/security-team#10987. Fleet integrations render pages whose source content is written in Markdown format. Links in markdown were being converted into regular `<a>` tags rather than in `<EuiLink>` components that include styling for external links and open in new tabs. Also, the "API Reference" page rendered a "Learn more" link using a `<EuiLink>` component with external styling but missed `target="_blank"`, so it wasn't acting as an external link and didn't open in a new tab either. ### Bug origin This bug has dragged for the last 3 years since `react-markdown` upgraded to `v6.0` and introduced a [breaking change](https://github.com/remarkjs/react-markdown/blob/main/changelog.md#600---2021-04-15) in custom renderers ### Screenshots <details><summary>Overview page</summary> <img width="1406" alt="Screenshot 2024-11-08 at 13 35 43" src="https://github.com/user-attachments/assets/b11262f1-0b1e-45e5-baa9-d69727643b08"> </details> <details><summary>API Reference page</summary> <img width="2021" alt="Screenshot 2024-11-08 at 13 35 07" src="https://github.com/user-attachments/assets/7e073df2-0451-4e9d-b80c-878cfcdd6c58"> </details> ### Checklist Delete any items that are not applicable to this PR. - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 763410c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 8, 2024
…) (#199525) # Backport This will backport the following commits from `main` to `8.16`: - [Open links in new tabs from pages in Fleet integrations (#199468)](#199468) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alberto Blázquez","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-08T17:33:55Z","message":"Open links in new tabs from pages in Fleet integrations (#199468)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/security-team/issues/10987.\r\n\r\nFleet integrations render pages whose source content is written in\r\nMarkdown format. Links in markdown were being converted into regular\r\n`<a>` tags rather than in `<EuiLink>` components that include styling\r\nfor external links and open in new tabs.\r\n\r\nAlso, the \"API Reference\" page rendered a \"Learn more\" link using a\r\n`<EuiLink>` component with external styling but missed\r\n`target=\"_blank\"`, so it wasn't acting as an external link and didn't\r\nopen in a new tab either.\r\n\r\n\r\n### Bug origin\r\n\r\nThis bug has dragged for the last 3 years since `react-markdown`\r\nupgraded to `v6.0` and introduced a [breaking\r\nchange](https://github.com/remarkjs/react-markdown/blob/main/changelog.md#600---2021-04-15)\r\nin custom renderers\r\n\r\n\r\n\r\n### Screenshots\r\n\r\n<details><summary>Overview page</summary>\r\n<img width=\"1406\" alt=\"Screenshot 2024-11-08 at 13 35 43\"\r\nsrc=\"https://github.com/user-attachments/assets/b11262f1-0b1e-45e5-baa9-d69727643b08\">\r\n</details> \r\n\r\n<details><summary>API Reference page</summary>\r\n<img width=\"2021\" alt=\"Screenshot 2024-11-08 at 13 35 07\"\r\nsrc=\"https://github.com/user-attachments/assets/7e073df2-0451-4e9d-b80c-878cfcdd6c58\">\r\n</details> \r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"763410c8ab0fed547571431c27a0d5d2f5fd4a7b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:Cloud Security","backport:prev-minor","csp: quick win","v8.16.0","backport:version","v8.17.0"],"title":"Open links in new tabs from pages in Fleet integrations","number":199468,"url":"https://github.com/elastic/kibana/pull/199468","mergeCommit":{"message":"Open links in new tabs from pages in Fleet integrations (#199468)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/security-team/issues/10987.\r\n\r\nFleet integrations render pages whose source content is written in\r\nMarkdown format. Links in markdown were being converted into regular\r\n`<a>` tags rather than in `<EuiLink>` components that include styling\r\nfor external links and open in new tabs.\r\n\r\nAlso, the \"API Reference\" page rendered a \"Learn more\" link using a\r\n`<EuiLink>` component with external styling but missed\r\n`target=\"_blank\"`, so it wasn't acting as an external link and didn't\r\nopen in a new tab either.\r\n\r\n\r\n### Bug origin\r\n\r\nThis bug has dragged for the last 3 years since `react-markdown`\r\nupgraded to `v6.0` and introduced a [breaking\r\nchange](https://github.com/remarkjs/react-markdown/blob/main/changelog.md#600---2021-04-15)\r\nin custom renderers\r\n\r\n\r\n\r\n### Screenshots\r\n\r\n<details><summary>Overview page</summary>\r\n<img width=\"1406\" alt=\"Screenshot 2024-11-08 at 13 35 43\"\r\nsrc=\"https://github.com/user-attachments/assets/b11262f1-0b1e-45e5-baa9-d69727643b08\">\r\n</details> \r\n\r\n<details><summary>API Reference page</summary>\r\n<img width=\"2021\" alt=\"Screenshot 2024-11-08 at 13 35 07\"\r\nsrc=\"https://github.com/user-attachments/assets/7e073df2-0451-4e9d-b80c-878cfcdd6c58\">\r\n</details> \r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"763410c8ab0fed547571431c27a0d5d2f5fd4a7b"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199468","number":199468,"mergeCommit":{"message":"Open links in new tabs from pages in Fleet integrations (#199468)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/security-team/issues/10987.\r\n\r\nFleet integrations render pages whose source content is written in\r\nMarkdown format. Links in markdown were being converted into regular\r\n`<a>` tags rather than in `<EuiLink>` components that include styling\r\nfor external links and open in new tabs.\r\n\r\nAlso, the \"API Reference\" page rendered a \"Learn more\" link using a\r\n`<EuiLink>` component with external styling but missed\r\n`target=\"_blank\"`, so it wasn't acting as an external link and didn't\r\nopen in a new tab either.\r\n\r\n\r\n### Bug origin\r\n\r\nThis bug has dragged for the last 3 years since `react-markdown`\r\nupgraded to `v6.0` and introduced a [breaking\r\nchange](https://github.com/remarkjs/react-markdown/blob/main/changelog.md#600---2021-04-15)\r\nin custom renderers\r\n\r\n\r\n\r\n### Screenshots\r\n\r\n<details><summary>Overview page</summary>\r\n<img width=\"1406\" alt=\"Screenshot 2024-11-08 at 13 35 43\"\r\nsrc=\"https://github.com/user-attachments/assets/b11262f1-0b1e-45e5-baa9-d69727643b08\">\r\n</details> \r\n\r\n<details><summary>API Reference page</summary>\r\n<img width=\"2021\" alt=\"Screenshot 2024-11-08 at 13 35 07\"\r\nsrc=\"https://github.com/user-attachments/assets/7e073df2-0451-4e9d-b80c-878cfcdd6c58\">\r\n</details> \r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"763410c8ab0fed547571431c27a0d5d2f5fd4a7b"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Alberto Blázquez <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 8, 2024
… (#199526) # Backport This will backport the following commits from `main` to `8.x`: - [Open links in new tabs from pages in Fleet integrations (#199468)](#199468) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alberto Blázquez","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-08T17:33:55Z","message":"Open links in new tabs from pages in Fleet integrations (#199468)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/security-team/issues/10987.\r\n\r\nFleet integrations render pages whose source content is written in\r\nMarkdown format. Links in markdown were being converted into regular\r\n`<a>` tags rather than in `<EuiLink>` components that include styling\r\nfor external links and open in new tabs.\r\n\r\nAlso, the \"API Reference\" page rendered a \"Learn more\" link using a\r\n`<EuiLink>` component with external styling but missed\r\n`target=\"_blank\"`, so it wasn't acting as an external link and didn't\r\nopen in a new tab either.\r\n\r\n\r\n### Bug origin\r\n\r\nThis bug has dragged for the last 3 years since `react-markdown`\r\nupgraded to `v6.0` and introduced a [breaking\r\nchange](https://github.com/remarkjs/react-markdown/blob/main/changelog.md#600---2021-04-15)\r\nin custom renderers\r\n\r\n\r\n\r\n### Screenshots\r\n\r\n<details><summary>Overview page</summary>\r\n<img width=\"1406\" alt=\"Screenshot 2024-11-08 at 13 35 43\"\r\nsrc=\"https://github.com/user-attachments/assets/b11262f1-0b1e-45e5-baa9-d69727643b08\">\r\n</details> \r\n\r\n<details><summary>API Reference page</summary>\r\n<img width=\"2021\" alt=\"Screenshot 2024-11-08 at 13 35 07\"\r\nsrc=\"https://github.com/user-attachments/assets/7e073df2-0451-4e9d-b80c-878cfcdd6c58\">\r\n</details> \r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"763410c8ab0fed547571431c27a0d5d2f5fd4a7b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:Cloud Security","backport:prev-minor","csp: quick win","v8.16.0","backport:version","v8.17.0"],"title":"Open links in new tabs from pages in Fleet integrations","number":199468,"url":"https://github.com/elastic/kibana/pull/199468","mergeCommit":{"message":"Open links in new tabs from pages in Fleet integrations (#199468)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/security-team/issues/10987.\r\n\r\nFleet integrations render pages whose source content is written in\r\nMarkdown format. Links in markdown were being converted into regular\r\n`<a>` tags rather than in `<EuiLink>` components that include styling\r\nfor external links and open in new tabs.\r\n\r\nAlso, the \"API Reference\" page rendered a \"Learn more\" link using a\r\n`<EuiLink>` component with external styling but missed\r\n`target=\"_blank\"`, so it wasn't acting as an external link and didn't\r\nopen in a new tab either.\r\n\r\n\r\n### Bug origin\r\n\r\nThis bug has dragged for the last 3 years since `react-markdown`\r\nupgraded to `v6.0` and introduced a [breaking\r\nchange](https://github.com/remarkjs/react-markdown/blob/main/changelog.md#600---2021-04-15)\r\nin custom renderers\r\n\r\n\r\n\r\n### Screenshots\r\n\r\n<details><summary>Overview page</summary>\r\n<img width=\"1406\" alt=\"Screenshot 2024-11-08 at 13 35 43\"\r\nsrc=\"https://github.com/user-attachments/assets/b11262f1-0b1e-45e5-baa9-d69727643b08\">\r\n</details> \r\n\r\n<details><summary>API Reference page</summary>\r\n<img width=\"2021\" alt=\"Screenshot 2024-11-08 at 13 35 07\"\r\nsrc=\"https://github.com/user-attachments/assets/7e073df2-0451-4e9d-b80c-878cfcdd6c58\">\r\n</details> \r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"763410c8ab0fed547571431c27a0d5d2f5fd4a7b"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199468","number":199468,"mergeCommit":{"message":"Open links in new tabs from pages in Fleet integrations (#199468)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/security-team/issues/10987.\r\n\r\nFleet integrations render pages whose source content is written in\r\nMarkdown format. Links in markdown were being converted into regular\r\n`<a>` tags rather than in `<EuiLink>` components that include styling\r\nfor external links and open in new tabs.\r\n\r\nAlso, the \"API Reference\" page rendered a \"Learn more\" link using a\r\n`<EuiLink>` component with external styling but missed\r\n`target=\"_blank\"`, so it wasn't acting as an external link and didn't\r\nopen in a new tab either.\r\n\r\n\r\n### Bug origin\r\n\r\nThis bug has dragged for the last 3 years since `react-markdown`\r\nupgraded to `v6.0` and introduced a [breaking\r\nchange](https://github.com/remarkjs/react-markdown/blob/main/changelog.md#600---2021-04-15)\r\nin custom renderers\r\n\r\n\r\n\r\n### Screenshots\r\n\r\n<details><summary>Overview page</summary>\r\n<img width=\"1406\" alt=\"Screenshot 2024-11-08 at 13 35 43\"\r\nsrc=\"https://github.com/user-attachments/assets/b11262f1-0b1e-45e5-baa9-d69727643b08\">\r\n</details> \r\n\r\n<details><summary>API Reference page</summary>\r\n<img width=\"2021\" alt=\"Screenshot 2024-11-08 at 13 35 07\"\r\nsrc=\"https://github.com/user-attachments/assets/7e073df2-0451-4e9d-b80c-878cfcdd6c58\">\r\n</details> \r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"763410c8ab0fed547571431c27a0d5d2f5fd4a7b"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Alberto Blázquez <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 11, 2024
## Summary Closes elastic/security-team#10987. Fleet integrations render pages whose source content is written in Markdown format. Links in markdown were being converted into regular `<a>` tags rather than in `<EuiLink>` components that include styling for external links and open in new tabs. Also, the "API Reference" page rendered a "Learn more" link using a `<EuiLink>` component with external styling but missed `target="_blank"`, so it wasn't acting as an external link and didn't open in a new tab either. ### Bug origin This bug has dragged for the last 3 years since `react-markdown` upgraded to `v6.0` and introduced a [breaking change](https://github.com/remarkjs/react-markdown/blob/main/changelog.md#600---2021-04-15) in custom renderers ### Screenshots <details><summary>Overview page</summary> <img width="1406" alt="Screenshot 2024-11-08 at 13 35 43" src="https://github.com/user-attachments/assets/b11262f1-0b1e-45e5-baa9-d69727643b08"> </details> <details><summary>API Reference page</summary> <img width="2021" alt="Screenshot 2024-11-08 at 13 35 07" src="https://github.com/user-attachments/assets/7e073df2-0451-4e9d-b80c-878cfcdd6c58"> </details> ### Checklist Delete any items that are not applicable to this PR. - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: kibanamachine <[email protected]>
|
This PR didn't make it on time to the latest 8.16.0 BC. Updating the labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes https://github.com/elastic/security-team/issues/10987.
Fleet integrations render pages whose source content is written in Markdown format. Links in markdown were being converted into regular
<a>tags rather than in<EuiLink>components that include styling for external links and open in new tabs.Also, the "API Reference" page rendered a "Learn more" link using a
<EuiLink>component with external styling but missedtarget="_blank", so it wasn't acting as an external link and didn't open in a new tab either.Bug origin
This bug has dragged for the last 3 years since
react-markdownupgraded tov6.0and introduced a breaking change in custom renderersScreenshots
Overview page
API Reference page
Checklist
Delete any items that are not applicable to this PR.