fix dashboard grid item performs 2 DOM queries every render #199390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
|
/ci |
|
/ci |
|
/ci |
|
/ci |
nreese
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
nickofthyme
approved these changes
Nov 14, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
TinaHeiligers
requested changes
Nov 14, 2024
packages/core/rendering/core-rendering-browser/src/use_app_fixed_viewport.ts
Outdated
Show resolved
Hide resolved
packages/core/rendering/core-rendering-browser/src/use_app_fixed_viewport.ts
Show resolved
Hide resolved
packages/core/rendering/core-rendering-browser-internal/src/rendering_service.tsx
Show resolved
Hide resolved
TinaHeiligers
approved these changes
Nov 14, 2024
nreese
dismissed
afharo’s stale review
Core team review provided by Tina. Resolved afharo's concerns but he is out of office
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11898803830 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
|
8.x #200648 |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Nov 18, 2024
…199390) Closes elastic#199361 While investigating, I found that fetching DOM element with id `app-fixed-viewport` is a common pattern. I created the hook `useAppFixedViewport` to consolidate this logic into a single location. The hook only performs the DOM look-up on first render and then avoids the DOM look-up on each additional render. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 9f54503) # Conflicts: # .github/CODEOWNERS
nreese
added a commit
that referenced
this pull request
Nov 18, 2024
…99390) (#200648) # Backport This will backport the following commits from `main` to `8.x`: - [fix dashboard grid item performs 2 DOM queries every render (#199390)](#199390) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-18T18:32:53Z","message":"fix dashboard grid item performs 2 DOM queries every render (#199390)\n\nCloses https://github.com/elastic/kibana/issues/199361\r\n\r\nWhile investigating, I found that fetching DOM element with id\r\n`app-fixed-viewport` is a common pattern. I created the hook\r\n`useAppFixedViewport` to consolidate this logic into a single location.\r\nThe hook only performs the DOM look-up on first render and then avoids\r\nthe DOM look-up on each additional render.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"9f545039ab42e95fd1d3d0518da4df6a8d040177","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v8.17.0"],"number":199390,"url":"https://github.com/elastic/kibana/pull/199390","mergeCommit":{"message":"fix dashboard grid item performs 2 DOM queries every render (#199390)\n\nCloses https://github.com/elastic/kibana/issues/199361\r\n\r\nWhile investigating, I found that fetching DOM element with id\r\n`app-fixed-viewport` is a common pattern. I created the hook\r\n`useAppFixedViewport` to consolidate this logic into a single location.\r\nThe hook only performs the DOM look-up on first render and then avoids\r\nthe DOM look-up on each additional render.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"9f545039ab42e95fd1d3d0518da4df6a8d040177"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199390","number":199390,"mergeCommit":{"message":"fix dashboard grid item performs 2 DOM queries every render (#199390)\n\nCloses https://github.com/elastic/kibana/issues/199361\r\n\r\nWhile investigating, I found that fetching DOM element with id\r\n`app-fixed-viewport` is a common pattern. I created the hook\r\n`useAppFixedViewport` to consolidate this logic into a single location.\r\nThe hook only performs the DOM look-up on first render and then avoids\r\nthe DOM look-up on each additional render.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"9f545039ab42e95fd1d3d0518da4df6a8d040177"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…199390) Closes elastic#199361 While investigating, I found that fetching DOM element with id `app-fixed-viewport` is a common pattern. I created the hook `useAppFixedViewport` to consolidate this logic into a single location. The hook only performs the DOM look-up on first render and then avoids the DOM look-up on each additional render. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #199361
While investigating, I found that fetching DOM element with id
app-fixed-viewportis a common pattern. I created the hookuseAppFixedViewportto consolidate this logic into a single location. The hook only performs the DOM look-up on first render and then avoids the DOM look-up on each additional render.