[Search] [Onboarding] Fix colors for dark theme #199331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yansavitski
added
release_note:skip
💚 Build Succeeded
Metrics [docs]Async chunks
|
joemcelroy
approved these changes
Nov 8, 2024
|
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11744140142 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 8, 2024
In dark mode, colors are not changed for some components in indexManagement - Change according background color base on theme - Change icons color base on theme <img width="1030" alt="image" src="https://github.com/user-attachments/assets/f448b522-03cc-4e17-89dd-4a460983bbac"> (cherry picked from commit 619f330)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 8, 2024
In dark mode, colors are not changed for some components in indexManagement - Change according background color base on theme - Change icons color base on theme <img width="1030" alt="image" src="https://github.com/user-attachments/assets/f448b522-03cc-4e17-89dd-4a460983bbac"> (cherry picked from commit 619f330)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 8, 2024
…9490) # Backport This will backport the following commits from `main` to `8.16`: - [[Search] [Onboarding] Fix colors for dark theme (#199331)](#199331) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yan Savitski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-08T14:39:03Z","message":"[Search] [Onboarding] Fix colors for dark theme (#199331)\n\nIn dark mode, colors are not changed for some components in\r\nindexManagement\r\n\r\n- Change according background color base on theme\r\n- Change icons color base on theme\r\n\r\n<img width=\"1030\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/f448b522-03cc-4e17-89dd-4a460983bbac\">","sha":"619f330aa9fbcddf2ddd306555a7b5f0d7d3fbd6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor","v8.16.0"],"title":"[Search] [Onboarding] Fix colors for dark theme","number":199331,"url":"https://github.com/elastic/kibana/pull/199331","mergeCommit":{"message":"[Search] [Onboarding] Fix colors for dark theme (#199331)\n\nIn dark mode, colors are not changed for some components in\r\nindexManagement\r\n\r\n- Change according background color base on theme\r\n- Change icons color base on theme\r\n\r\n<img width=\"1030\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/f448b522-03cc-4e17-89dd-4a460983bbac\">","sha":"619f330aa9fbcddf2ddd306555a7b5f0d7d3fbd6"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199331","number":199331,"mergeCommit":{"message":"[Search] [Onboarding] Fix colors for dark theme (#199331)\n\nIn dark mode, colors are not changed for some components in\r\nindexManagement\r\n\r\n- Change according background color base on theme\r\n- Change icons color base on theme\r\n\r\n<img width=\"1030\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/f448b522-03cc-4e17-89dd-4a460983bbac\">","sha":"619f330aa9fbcddf2ddd306555a7b5f0d7d3fbd6"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Yan Savitski <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 8, 2024
) # Backport This will backport the following commits from `main` to `8.x`: - [[Search] [Onboarding] Fix colors for dark theme (#199331)](#199331) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yan Savitski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-08T14:39:03Z","message":"[Search] [Onboarding] Fix colors for dark theme (#199331)\n\nIn dark mode, colors are not changed for some components in\r\nindexManagement\r\n\r\n- Change according background color base on theme\r\n- Change icons color base on theme\r\n\r\n<img width=\"1030\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/f448b522-03cc-4e17-89dd-4a460983bbac\">","sha":"619f330aa9fbcddf2ddd306555a7b5f0d7d3fbd6","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor","v8.16.0"],"title":"[Search] [Onboarding] Fix colors for dark theme","number":199331,"url":"https://github.com/elastic/kibana/pull/199331","mergeCommit":{"message":"[Search] [Onboarding] Fix colors for dark theme (#199331)\n\nIn dark mode, colors are not changed for some components in\r\nindexManagement\r\n\r\n- Change according background color base on theme\r\n- Change icons color base on theme\r\n\r\n<img width=\"1030\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/f448b522-03cc-4e17-89dd-4a460983bbac\">","sha":"619f330aa9fbcddf2ddd306555a7b5f0d7d3fbd6"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199331","number":199331,"mergeCommit":{"message":"[Search] [Onboarding] Fix colors for dark theme (#199331)\n\nIn dark mode, colors are not changed for some components in\r\nindexManagement\r\n\r\n- Change according background color base on theme\r\n- Change icons color base on theme\r\n\r\n<img width=\"1030\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/f448b522-03cc-4e17-89dd-4a460983bbac\">","sha":"619f330aa9fbcddf2ddd306555a7b5f0d7d3fbd6"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Yan Savitski <[email protected]>
|
This PR didn't make it on time to the latest 8.16.0 BC. Updating the labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dark mode, colors are not changed for some components in indexManagement