Use getUrlPartsWithStrippedDefaultPort instead of getUrlParts #199264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryam-saeidi
added
release_note:skip
pheyos
approved these changes
Nov 7, 2024
wayneseymour
added
the
Team:obs-ux-management
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11721434266 |
💚 Build Succeeded
Metrics [docs]
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 7, 2024
…c#199264) ## Summary Use getUrlPartsWithStrippedDefaultPort to avoid this [issue](elastic#195902 (comment)) on MKI: ``` Serverless Observability - Deployment-agnostic api integration - Custom Threshold rule AVG - PCT - FIRED Rule creation should set correct action variables Error: expected 'https://bk-serverless-ftr-3067-e697d43e3ad9-e0ac80.kb.eu-west-1.aws.qa.elastic.cloud/app/observability/alerts/1e0c2d3e-e5c2-4bfe-9df0-d46681253b9f' to sort of equal 'https://bk-serverless-ftr-3067-e697d43e3ad9-e0ac80.kb.eu-west-1.aws.qa.elastic.cloud:443/app/observability/alerts/1e0c2d3e-e5c2-4bfe-9df0-d46681253b9f' ``` (cherry picked from commit 996104f)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 7, 2024
…199264) (#199288) # Backport This will backport the following commits from `main` to `8.x`: - [Use getUrlPartsWithStrippedDefaultPort instead of getUrlParts (#199264)](#199264) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-07T10:45:33Z","message":"Use getUrlPartsWithStrippedDefaultPort instead of getUrlParts (#199264)\n\n## Summary\r\n\r\nUse getUrlPartsWithStrippedDefaultPort to avoid this\r\n[issue](https://github.com/elastic/kibana/pull/195902#issuecomment-2411667499)\r\non MKI:\r\n\r\n```\r\nServerless Observability - Deployment-agnostic api integration - Custom Threshold rule AVG - PCT - FIRED Rule creation should set correct action variables\r\n\r\nError: expected 'https://bk-serverless-ftr-3067-e697d43e3ad9-e0ac80.kb.eu-west-1.aws.qa.elastic.cloud/app/observability/alerts/1e0c2d3e-e5c2-4bfe-9df0-d46681253b9f'\r\nto sort of equal 'https://bk-serverless-ftr-3067-e697d43e3ad9-e0ac80.kb.eu-west-1.aws.qa.elastic.cloud:443/app/observability/alerts/1e0c2d3e-e5c2-4bfe-9df0-d46681253b9f'\r\n```","sha":"996104f2eae2a3eb2412d5bb4ca52e89a5dbb1db","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-management"],"title":"Use getUrlPartsWithStrippedDefaultPort instead of getUrlParts","number":199264,"url":"https://github.com/elastic/kibana/pull/199264","mergeCommit":{"message":"Use getUrlPartsWithStrippedDefaultPort instead of getUrlParts (#199264)\n\n## Summary\r\n\r\nUse getUrlPartsWithStrippedDefaultPort to avoid this\r\n[issue](https://github.com/elastic/kibana/pull/195902#issuecomment-2411667499)\r\non MKI:\r\n\r\n```\r\nServerless Observability - Deployment-agnostic api integration - Custom Threshold rule AVG - PCT - FIRED Rule creation should set correct action variables\r\n\r\nError: expected 'https://bk-serverless-ftr-3067-e697d43e3ad9-e0ac80.kb.eu-west-1.aws.qa.elastic.cloud/app/observability/alerts/1e0c2d3e-e5c2-4bfe-9df0-d46681253b9f'\r\nto sort of equal 'https://bk-serverless-ftr-3067-e697d43e3ad9-e0ac80.kb.eu-west-1.aws.qa.elastic.cloud:443/app/observability/alerts/1e0c2d3e-e5c2-4bfe-9df0-d46681253b9f'\r\n```","sha":"996104f2eae2a3eb2412d5bb4ca52e89a5dbb1db"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199264","number":199264,"mergeCommit":{"message":"Use getUrlPartsWithStrippedDefaultPort instead of getUrlParts (#199264)\n\n## Summary\r\n\r\nUse getUrlPartsWithStrippedDefaultPort to avoid this\r\n[issue](https://github.com/elastic/kibana/pull/195902#issuecomment-2411667499)\r\non MKI:\r\n\r\n```\r\nServerless Observability - Deployment-agnostic api integration - Custom Threshold rule AVG - PCT - FIRED Rule creation should set correct action variables\r\n\r\nError: expected 'https://bk-serverless-ftr-3067-e697d43e3ad9-e0ac80.kb.eu-west-1.aws.qa.elastic.cloud/app/observability/alerts/1e0c2d3e-e5c2-4bfe-9df0-d46681253b9f'\r\nto sort of equal 'https://bk-serverless-ftr-3067-e697d43e3ad9-e0ac80.kb.eu-west-1.aws.qa.elastic.cloud:443/app/observability/alerts/1e0c2d3e-e5c2-4bfe-9df0-d46681253b9f'\r\n```","sha":"996104f2eae2a3eb2412d5bb4ca52e89a5dbb1db"}}]}] BACKPORT--> Co-authored-by: Maryam Saeidi <[email protected]>
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
Nov 8, 2024
…c#199264) ## Summary Use getUrlPartsWithStrippedDefaultPort to avoid this [issue](elastic#195902 (comment)) on MKI: ``` Serverless Observability - Deployment-agnostic api integration - Custom Threshold rule AVG - PCT - FIRED Rule creation should set correct action variables Error: expected 'https://bk-serverless-ftr-3067-e697d43e3ad9-e0ac80.kb.eu-west-1.aws.qa.elastic.cloud/app/observability/alerts/1e0c2d3e-e5c2-4bfe-9df0-d46681253b9f' to sort of equal 'https://bk-serverless-ftr-3067-e697d43e3ad9-e0ac80.kb.eu-west-1.aws.qa.elastic.cloud:443/app/observability/alerts/1e0c2d3e-e5c2-4bfe-9df0-d46681253b9f' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use getUrlPartsWithStrippedDefaultPort to avoid this issue on MKI: