[Index Management] Fix ILM policy link trigger an SPA friendly navigation #199252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viajes7
force-pushed
the
fix/ilm-policy-route
branch
2 times, most recently
from
f17a573 to
2337a22
Compare
|
Hi, @ElenaStoeva can you also help review this PR? Thanks a lot. |
|
@elasticmachine merge upstream |
viajes7
force-pushed
the
fix/ilm-policy-route
branch
5 times, most recently
from
6edf527 to
7b91cd3
Compare
ElenaStoeva
approved these changes
Nov 20, 2024
ElenaStoeva
added
Feature:Index Management
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
|
/ci |
|
Hey @viajes7, there is one failing Jest test in ci, which I think is caused by these changes - could you please fix it? |
Sure, test case fixed |
viajes7
force-pushed
the
fix/ilm-policy-route
branch
from
7b91cd3 to
dcca7d3
Compare
|
/ci |
It looks like the test is still failing - also, I don't see any test changes in this PR. |
viajes7
force-pushed
the
fix/ilm-policy-route
branch
from
e654383 to
1f0b09b
Compare
Hi, @ElenaStoeva Sorry about that. I didn't notice that the local push failed and I have pushed it again. |
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
|
@elasticmachine run docs-build |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11959512720 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 21, 2024
…tion (elastic#199252) ## Summary Close elastic#87876 Use `core.application.navigateToUrl` navigate to given URL in a SPA friendly. https://github.com/user-attachments/assets/1918eb3d-fbec-46d9-8eae-b4a26ebd36a2 (cherry picked from commit fa100b4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 21, 2024
…navigation (#199252) (#201271) # Backport This will backport the following commits from `main` to `8.x`: - [[Index Management] Fix ILM policy link trigger an SPA friendly navigation (#199252)](#199252) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jusheng Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T18:35:59Z","message":"[Index Management] Fix ILM policy link trigger an SPA friendly navigation (#199252)\n\n## Summary\r\n\r\nClose #87876 \r\n\r\nUse `core.application.navigateToUrl` navigate to given URL in a SPA\r\nfriendly.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/1918eb3d-fbec-46d9-8eae-b4a26ebd36a2","sha":"fa100b48191d08fde48894ff88dd49687ef4d524","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index Management","Team:Kibana Management","release_note:skip","💝community","v9.0.0","backport:prev-minor"],"title":"[Index Management] Fix ILM policy link trigger an SPA friendly navigation","number":199252,"url":"https://github.com/elastic/kibana/pull/199252","mergeCommit":{"message":"[Index Management] Fix ILM policy link trigger an SPA friendly navigation (#199252)\n\n## Summary\r\n\r\nClose #87876 \r\n\r\nUse `core.application.navigateToUrl` navigate to given URL in a SPA\r\nfriendly.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/1918eb3d-fbec-46d9-8eae-b4a26ebd36a2","sha":"fa100b48191d08fde48894ff88dd49687ef4d524"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199252","number":199252,"mergeCommit":{"message":"[Index Management] Fix ILM policy link trigger an SPA friendly navigation (#199252)\n\n## Summary\r\n\r\nClose #87876 \r\n\r\nUse `core.application.navigateToUrl` navigate to given URL in a SPA\r\nfriendly.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/1918eb3d-fbec-46d9-8eae-b4a26ebd36a2","sha":"fa100b48191d08fde48894ff88dd49687ef4d524"}}]}] BACKPORT--> Co-authored-by: Jusheng Huang <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…tion (elastic#199252) ## Summary Close elastic#87876 Use `core.application.navigateToUrl` navigate to given URL in a SPA friendly. https://github.com/user-attachments/assets/1918eb3d-fbec-46d9-8eae-b4a26ebd36a2
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…tion (elastic#199252) ## Summary Close elastic#87876 Use `core.application.navigateToUrl` navigate to given URL in a SPA friendly. https://github.com/user-attachments/assets/1918eb3d-fbec-46d9-8eae-b4a26ebd36a2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #87876
Use
core.application.navigateToUrlnavigate to given URL in a SPA friendly.2024-11-07.11.24.15.mov