Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search: Home page] Remove the extra . from the {number} active API keys. text. #199096

Merged
merged 2 commits into from
Nov 6, 2024

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Nov 6, 2024

This PR fixes a small typo in #197456. No need to add . for text placed in EuiBadge

Screen

image

… keys. text.
@alexwizp alexwizp added Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v9.0.0 labels Nov 6, 2024
@alexwizp alexwizp marked this pull request as ready for review November 6, 2024 09:49
@alexwizp alexwizp requested a review from a team as a code owner November 6, 2024 09:49
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@alexwizp alexwizp changed the title [Search: Home page] Remove the extra . from the {number} active API keys. text.` [Search: Home page] Remove the extra . from the {number} active API keys. text. Nov 6, 2024
@alexwizp alexwizp changed the title [Search: Home page] Remove the extra . from the {number} active API keys. text. [Search: Home page] Remove the extra . from the {number} active API keys. text. Nov 6, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB -2.0B

@alexwizp alexwizp merged commit 1b9079f into elastic:main Nov 6, 2024
21 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11707973565

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 6, 2024
…I keys.` text. (elastic#199096)

This PR fixes a small typo in
elastic#197456. No need to add `.` for
text placed in `EuiBadge`

## Screen
<img width="461" alt="image"
src="https://github.com/user-attachments/assets/40ea17b2-c735-438a-b00e-9e0f0503d5cd">

(cherry picked from commit 1b9079f)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 6, 2024
…60;{number} active API keys.&#x60; text. (#199096) (#199179)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Search: Home page] Remove the extra &#x60;.&#x60; from the
&#x60;{number} active API keys.&#x60; text.
(#199096)](#199096)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-06T16:38:42Z","message":"[Search:
Home page] Remove the extra `.` from the `{number} active API keys.`
text. (#199096)\n\nThis PR fixes a small typo
in\r\nhttps://github.com//pull/197456. No need to add `.`
for\r\ntext placed in `EuiBadge`\r\n\r\n## Screen\r\n<img width=\"461\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/40ea17b2-c735-438a-b00e-9e0f0503d5cd\">","sha":"1b9079f16416cb0e18eb05ef9939520f7a80f767","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Search:
Home page] Remove the extra `.` from the `{number} active API keys.`
text.","number":199096,"url":"https://github.com/elastic/kibana/pull/199096","mergeCommit":{"message":"[Search:
Home page] Remove the extra `.` from the `{number} active API keys.`
text. (#199096)\n\nThis PR fixes a small typo
in\r\nhttps://github.com//pull/197456. No need to add `.`
for\r\ntext placed in `EuiBadge`\r\n\r\n## Screen\r\n<img width=\"461\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/40ea17b2-c735-438a-b00e-9e0f0503d5cd\">","sha":"1b9079f16416cb0e18eb05ef9939520f7a80f767"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199096","number":199096,"mergeCommit":{"message":"[Search:
Home page] Remove the extra `.` from the `{number} active API keys.`
text. (#199096)\n\nThis PR fixes a small typo
in\r\nhttps://github.com//pull/197456. No need to add `.`
for\r\ntext placed in `EuiBadge`\r\n\r\n## Screen\r\n<img width=\"461\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/40ea17b2-c735-438a-b00e-9e0f0503d5cd\">","sha":"1b9079f16416cb0e18eb05ef9939520f7a80f767"}}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <[email protected]>
mgadewoll pushed a commit to mgadewoll/kibana that referenced this pull request Nov 7, 2024
…I keys.` text. (elastic#199096)

This PR fixes a small typo in
elastic#197456. No need to add `.` for
text placed in `EuiBadge`

## Screen
<img width="461" alt="image"
src="https://github.com/user-attachments/assets/40ea17b2-c735-438a-b00e-9e0f0503d5cd">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants