[Security Solution][Bug] Incorrect message as Duplicate entry? shown on creating New Knowledge Base index. (#198892) #199045
+71
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on creating New Knowledge Base index. (elastic#198892)
e40pud
added
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
e40pud
changed the title
stephmilovic
approved these changes
Nov 5, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
cc @e40pud |
|
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11693173430 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 5, 2024
…on creating New Knowledge Base index. (elastic#198892) (elastic#199045) ## Summary BUG: elastic#198892 This PR fixes the BUG where we would show `Duplicate entry?` confirmation modal on new document creation. This happens because the state is not being reset properly on flyout close and we use previous values in the new entry creation flow. ### To test 1. Create a global entry (document or index) 2. Edit the entry from 1 3. Switch global to private 4. Save entry => This will trigger `Duplicate entry?` confirmation modal (save it) 5. Press `New > Index/Document` 6. Fill out required fields 7. Press `Save` button ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 8ebe788)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 5, 2024
…on creating New Knowledge Base index. (elastic#198892) (elastic#199045) ## Summary BUG: elastic#198892 This PR fixes the BUG where we would show `Duplicate entry?` confirmation modal on new document creation. This happens because the state is not being reset properly on flyout close and we use previous values in the new entry creation flow. ### To test 1. Create a global entry (document or index) 2. Edit the entry from 1 3. Switch global to private 4. Save entry => This will trigger `Duplicate entry?` confirmation modal (save it) 5. Press `New > Index/Document` 6. Fill out required fields 7. Press `Save` button ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 8ebe788)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 5, 2024
…shown on creating New Knowledge Base index. (#198892) (#199045) (#199063) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Bug] Incorrect message as Duplicate entry? shown on creating New Knowledge Base index. (#198892) (#199045)](#199045) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T21:57:30Z","message":"[Security Solution][Bug] Incorrect message as Duplicate entry? shown on creating New Knowledge Base index. (#198892) (#199045)\n\n## Summary\r\n\r\nBUG: https://github.com/elastic/kibana/issues/198892\r\n\r\nThis PR fixes the BUG where we would show `Duplicate entry?`\r\nconfirmation modal on new document creation. This happens because the\r\nstate is not being reset properly on flyout close and we use previous\r\nvalues in the new entry creation flow.\r\n\r\n### To test\r\n\r\n1. Create a global entry (document or index)\r\n2. Edit the entry from 1\r\n3. Switch global to private\r\n4. Save entry => This will trigger `Duplicate entry?` confirmation modal\r\n(save it)\r\n5. Press `New > Index/Document`\r\n6. Fill out required fields\r\n7. Press `Save` button\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"8ebe78857b11a20f4be5cdfbeb6b38897f270f19","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","v8.16.0","backport:version","v8.17.0"],"title":"[Security Solution][Bug] Incorrect message as Duplicate entry? shown on creating New Knowledge Base index. (#198892)","number":199045,"url":"https://github.com/elastic/kibana/pull/199045","mergeCommit":{"message":"[Security Solution][Bug] Incorrect message as Duplicate entry? shown on creating New Knowledge Base index. (#198892) (#199045)\n\n## Summary\r\n\r\nBUG: https://github.com/elastic/kibana/issues/198892\r\n\r\nThis PR fixes the BUG where we would show `Duplicate entry?`\r\nconfirmation modal on new document creation. This happens because the\r\nstate is not being reset properly on flyout close and we use previous\r\nvalues in the new entry creation flow.\r\n\r\n### To test\r\n\r\n1. Create a global entry (document or index)\r\n2. Edit the entry from 1\r\n3. Switch global to private\r\n4. Save entry => This will trigger `Duplicate entry?` confirmation modal\r\n(save it)\r\n5. Press `New > Index/Document`\r\n6. Fill out required fields\r\n7. Press `Save` button\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"8ebe78857b11a20f4be5cdfbeb6b38897f270f19"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199045","number":199045,"mergeCommit":{"message":"[Security Solution][Bug] Incorrect message as Duplicate entry? shown on creating New Knowledge Base index. (#198892) (#199045)\n\n## Summary\r\n\r\nBUG: https://github.com/elastic/kibana/issues/198892\r\n\r\nThis PR fixes the BUG where we would show `Duplicate entry?`\r\nconfirmation modal on new document creation. This happens because the\r\nstate is not being reset properly on flyout close and we use previous\r\nvalues in the new entry creation flow.\r\n\r\n### To test\r\n\r\n1. Create a global entry (document or index)\r\n2. Edit the entry from 1\r\n3. Switch global to private\r\n4. Save entry => This will trigger `Duplicate entry?` confirmation modal\r\n(save it)\r\n5. Press `New > Index/Document`\r\n6. Fill out required fields\r\n7. Press `Save` button\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"8ebe78857b11a20f4be5cdfbeb6b38897f270f19"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 5, 2024
… shown on creating New Knowledge Base index. (#198892) (#199045) (#199062) # Backport This will backport the following commits from `main` to `8.16`: - [[Security Solution][Bug] Incorrect message as Duplicate entry? shown on creating New Knowledge Base index. (#198892) (#199045)](#199045) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T21:57:30Z","message":"[Security Solution][Bug] Incorrect message as Duplicate entry? shown on creating New Knowledge Base index. (#198892) (#199045)\n\n## Summary\r\n\r\nBUG: https://github.com/elastic/kibana/issues/198892\r\n\r\nThis PR fixes the BUG where we would show `Duplicate entry?`\r\nconfirmation modal on new document creation. This happens because the\r\nstate is not being reset properly on flyout close and we use previous\r\nvalues in the new entry creation flow.\r\n\r\n### To test\r\n\r\n1. Create a global entry (document or index)\r\n2. Edit the entry from 1\r\n3. Switch global to private\r\n4. Save entry => This will trigger `Duplicate entry?` confirmation modal\r\n(save it)\r\n5. Press `New > Index/Document`\r\n6. Fill out required fields\r\n7. Press `Save` button\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"8ebe78857b11a20f4be5cdfbeb6b38897f270f19","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","v8.16.0","backport:version","v8.17.0"],"title":"[Security Solution][Bug] Incorrect message as Duplicate entry? shown on creating New Knowledge Base index. (#198892)","number":199045,"url":"https://github.com/elastic/kibana/pull/199045","mergeCommit":{"message":"[Security Solution][Bug] Incorrect message as Duplicate entry? shown on creating New Knowledge Base index. (#198892) (#199045)\n\n## Summary\r\n\r\nBUG: https://github.com/elastic/kibana/issues/198892\r\n\r\nThis PR fixes the BUG where we would show `Duplicate entry?`\r\nconfirmation modal on new document creation. This happens because the\r\nstate is not being reset properly on flyout close and we use previous\r\nvalues in the new entry creation flow.\r\n\r\n### To test\r\n\r\n1. Create a global entry (document or index)\r\n2. Edit the entry from 1\r\n3. Switch global to private\r\n4. Save entry => This will trigger `Duplicate entry?` confirmation modal\r\n(save it)\r\n5. Press `New > Index/Document`\r\n6. Fill out required fields\r\n7. Press `Save` button\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"8ebe78857b11a20f4be5cdfbeb6b38897f270f19"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199045","number":199045,"mergeCommit":{"message":"[Security Solution][Bug] Incorrect message as Duplicate entry? shown on creating New Knowledge Base index. (#198892) (#199045)\n\n## Summary\r\n\r\nBUG: https://github.com/elastic/kibana/issues/198892\r\n\r\nThis PR fixes the BUG where we would show `Duplicate entry?`\r\nconfirmation modal on new document creation. This happens because the\r\nstate is not being reset properly on flyout close and we use previous\r\nvalues in the new entry creation flow.\r\n\r\n### To test\r\n\r\n1. Create a global entry (document or index)\r\n2. Edit the entry from 1\r\n3. Switch global to private\r\n4. Save entry => This will trigger `Duplicate entry?` confirmation modal\r\n(save it)\r\n5. Press `New > Index/Document`\r\n6. Fill out required fields\r\n7. Press `Save` button\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"8ebe78857b11a20f4be5cdfbeb6b38897f270f19"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <[email protected]>
mgadewoll
pushed a commit
to mgadewoll/kibana
that referenced
this pull request
Nov 7, 2024
…on creating New Knowledge Base index. (elastic#198892) (elastic#199045) ## Summary BUG: elastic#198892 This PR fixes the BUG where we would show `Duplicate entry?` confirmation modal on new document creation. This happens because the state is not being reset properly on flyout close and we use previous values in the new entry creation flow. ### To test 1. Create a global entry (document or index) 2. Edit the entry from 1 3. Switch global to private 4. Save entry => This will trigger `Duplicate entry?` confirmation modal (save it) 5. Press `New > Index/Document` 6. Fill out required fields 7. Press `Save` button ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BUG: #198892
This PR fixes the BUG where we would show
Duplicate entry?confirmation modal on new document creation. This happens because the state is not being reset properly on flyout close and we use previous values in the new entry creation flow.To test
Duplicate entry?confirmation modal (save it)New > Index/DocumentSavebuttonChecklist
Delete any items that are not applicable to this PR.