Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] migrate es query rule tests to the deployment agnostic framework (#195715) #198919

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

mgiota
Copy link
Contributor

@mgiota mgiota commented Nov 5, 2024

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…stic#195715)

Fixes elastic#183395

This PR migrates the ES query rule tests to the [deployment agnostic
framework](https://github.com/elastic/kibana/tree/main/x-pack/test/api_integration/deployment_agnostic)

### TODO

- [x] Migrate ES rule tests into the deployment agnostic solution
- [ ] Test in MKI before merging

### How to run tests locally

To run serverless
```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/serverless/oblt.serverless.config.ts --grep="ElasticSearch query rule"
```

To run stateful
```
node scripts/functional_tests_server --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts
node scripts/functional_test_runner --config x-pack/test/api_integration/deployment_agnostic/configs/stateful/oblt.stateful.config.ts --grep="ElasticSearch query rule"
```

### How to run tests on MKI

According to this
[discussion](elastic/observability-dev#3519 (comment)),
we should test in MKI environment before merging. For details on how to
run in MKI, see [this section of the
document](https://docs.google.com/document/d/1tiax7xoDYwFXYZjRTgVKkVMjN-SQzBWk4yn1JY6Z5UY/edit#heading=h.ece2z8p74izh)
and [this
readme](https://github.com/elastic/kibana/blob/main/x-pack/test_serverless/README.md#run-tests-on-mki).

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Maryam Saeidi <[email protected]>
(cherry picked from commit 512bfcc)

# Conflicts:
#	x-pack/test/api_integration/deployment_agnostic/apis/observability/alerting/index.ts
@mgiota mgiota added the backport label Nov 5, 2024
@mgiota mgiota enabled auto-merge (squash) November 5, 2024 11:43
@mgiota mgiota requested a review from maryam-saeidi November 5, 2024 11:43
@mgiota mgiota self-assigned this Nov 5, 2024
@mgiota mgiota merged commit 4af104c into elastic:8.x Nov 5, 2024
24 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @mgiota

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants