Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [ObsUX] [APM-OTEL] Filter by trace.id instead of transaction.if for dependency spans (#198781) #198893

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…ependency spans (elastic#198781)

Closes elastic#193672

### Summary of the issue

The trace waterfall for dependencies operations is filled querying to
span documents using term query for `span.destination.service.resource`
and `span.name` fields, and where `transaction.id` exist. The results
for this query were empty, in otel, span documents don't have the
`transaction.id` field. After this query another one is made to retrieve
the transactions for those spans, querying the transaction ids

### Fix

The query has been changed, so we will check for the `trace.id` instead
of the `transaction.id`
On the second query, we will get from those trace ids the ones with
`transaction.id` and retrieve the transactions data

https://github.com/user-attachments/assets/fba25f61-0646-4071-b49f-422eab7ff18e
(cherry picked from commit c83e6db)
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

github-actions bot commented Nov 5, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibanamachine kibanamachine merged commit 336ad62 into elastic:8.x Nov 5, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants