-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security GenAI][BUG] Knowledge Base: Show only indices with semantic_text
fields
#198707
[Security GenAI][BUG] Knowledge Base: Show only indices with semantic_text
fields
#198707
Conversation
…antic_text` fields
Pinging @elastic/security-solution (Team: SecuritySolution) |
semantic_text
fieldssemantic_text
fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some investigation on this one and it looks like we set these kind of messages as a context for all EUI objects (https://github.com/elastic/kibana/blob/main/packages/core/i18n/core-i18n-browser-internal/src/i18n_eui_mapping.tsx#L374). I was thinking that we could add a description underneath the dropdown menu. Something like this cc @jamesspi |
Thanks @e40pud. I like this approach, but perhaps the text should be:
Not sure if that's too long or not in terms of available character counts. |
Thanks! I think it looks good |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
History
cc @e40pud |
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11681988075 |
…c_text` fields (elastic#198707) ## Summary This is a fix the next issue: > Index input should only list indices with semantic_text fields, not all indices. ### Current behaviour We show all available indices <img width="1311" alt="Screenshot 2024-11-01 at 18 14 36" src="https://github.com/user-attachments/assets/cf9d08fd-a809-4530-b653-d12b8e643e45"> ### Behaviour after the fix We show only indices with `semantic_text` fields <img width="1311" alt="Screenshot 2024-11-01 at 18 08 29" src="https://github.com/user-attachments/assets/864b5552-aece-4cc6-848a-8f73f88f55dc"> ### Testing notes Create some indices with `semantic_text` fields. For example, you can do that via uploading and indexing a PDF file: 1. Navigate to Integrations page 2. Select "Upload a file" 3. Select and upload a PDF file 4. Press Import button 5. Switch to Advanced tab 6. Fill in "Index name" 7. Add additional field > Add semantic text field > Fill in form * Field: `attachment.content` * Copy to field: `content` * Inference endpoint: `elser_model_2` 8. Press Add button 9. Press Import button ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit b122722)
…c_text` fields (elastic#198707) ## Summary This is a fix the next issue: > Index input should only list indices with semantic_text fields, not all indices. ### Current behaviour We show all available indices <img width="1311" alt="Screenshot 2024-11-01 at 18 14 36" src="https://github.com/user-attachments/assets/cf9d08fd-a809-4530-b653-d12b8e643e45"> ### Behaviour after the fix We show only indices with `semantic_text` fields <img width="1311" alt="Screenshot 2024-11-01 at 18 08 29" src="https://github.com/user-attachments/assets/864b5552-aece-4cc6-848a-8f73f88f55dc"> ### Testing notes Create some indices with `semantic_text` fields. For example, you can do that via uploading and indexing a PDF file: 1. Navigate to Integrations page 2. Select "Upload a file" 3. Select and upload a PDF file 4. Press Import button 5. Switch to Advanced tab 6. Fill in "Index name" 7. Add additional field > Add semantic text field > Fill in form * Field: `attachment.content` * Copy to field: `content` * Inference endpoint: `elser_model_2` 8. Press Add button 9. Press Import button ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit b122722)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…#x60;semantic_text` fields (#198707) (#198906) # Backport This will backport the following commits from `main` to `8.16`: - [[Security GenAI][BUG] Knowledge Base: Show only indices with `semantic_text` fields (#198707)](#198707) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T10:12:33Z","message":"[Security GenAI][BUG] Knowledge Base: Show only indices with `semantic_text` fields (#198707)\n\n## Summary\r\n\r\nThis is a fix the next issue:\r\n\r\n> Index input should only list indices with semantic_text fields, not\r\nall indices.\r\n\r\n### Current behaviour\r\n\r\nWe show all available indices\r\n\r\n<img width=\"1311\" alt=\"Screenshot 2024-11-01 at 18 14 36\"\r\nsrc=\"https://github.com/user-attachments/assets/cf9d08fd-a809-4530-b653-d12b8e643e45\">\r\n\r\n### Behaviour after the fix\r\n\r\nWe show only indices with `semantic_text` fields\r\n\r\n<img width=\"1311\" alt=\"Screenshot 2024-11-01 at 18 08 29\"\r\nsrc=\"https://github.com/user-attachments/assets/864b5552-aece-4cc6-848a-8f73f88f55dc\">\r\n\r\n### Testing notes\r\n\r\nCreate some indices with `semantic_text` fields. For example, you can do\r\nthat via uploading and indexing a PDF file:\r\n\r\n1. Navigate to Integrations page\r\n2. Select \"Upload a file\"\r\n3. Select and upload a PDF file\r\n4. Press Import button\r\n5. Switch to Advanced tab\r\n6. Fill in \"Index name\"\r\n7. Add additional field > Add semantic text field > Fill in form\r\n * Field: `attachment.content`\r\n * Copy to field: `content`\r\n * Inference endpoint: `elser_model_2`\r\n8. Press Add button\r\n9. Press Import button\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"b122722d886b66431108a33d0eac2447a63da179","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","backport:version","v8.17.0","v8.16.1"],"title":"[Security GenAI][BUG] Knowledge Base: Show only indices with `semantic_text` fields","number":198707,"url":"https://github.com/elastic/kibana/pull/198707","mergeCommit":{"message":"[Security GenAI][BUG] Knowledge Base: Show only indices with `semantic_text` fields (#198707)\n\n## Summary\r\n\r\nThis is a fix the next issue:\r\n\r\n> Index input should only list indices with semantic_text fields, not\r\nall indices.\r\n\r\n### Current behaviour\r\n\r\nWe show all available indices\r\n\r\n<img width=\"1311\" alt=\"Screenshot 2024-11-01 at 18 14 36\"\r\nsrc=\"https://github.com/user-attachments/assets/cf9d08fd-a809-4530-b653-d12b8e643e45\">\r\n\r\n### Behaviour after the fix\r\n\r\nWe show only indices with `semantic_text` fields\r\n\r\n<img width=\"1311\" alt=\"Screenshot 2024-11-01 at 18 08 29\"\r\nsrc=\"https://github.com/user-attachments/assets/864b5552-aece-4cc6-848a-8f73f88f55dc\">\r\n\r\n### Testing notes\r\n\r\nCreate some indices with `semantic_text` fields. For example, you can do\r\nthat via uploading and indexing a PDF file:\r\n\r\n1. Navigate to Integrations page\r\n2. Select \"Upload a file\"\r\n3. Select and upload a PDF file\r\n4. Press Import button\r\n5. Switch to Advanced tab\r\n6. Fill in \"Index name\"\r\n7. Add additional field > Add semantic text field > Fill in form\r\n * Field: `attachment.content`\r\n * Copy to field: `content`\r\n * Inference endpoint: `elser_model_2`\r\n8. Press Add button\r\n9. Press Import button\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"b122722d886b66431108a33d0eac2447a63da179"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198707","number":198707,"mergeCommit":{"message":"[Security GenAI][BUG] Knowledge Base: Show only indices with `semantic_text` fields (#198707)\n\n## Summary\r\n\r\nThis is a fix the next issue:\r\n\r\n> Index input should only list indices with semantic_text fields, not\r\nall indices.\r\n\r\n### Current behaviour\r\n\r\nWe show all available indices\r\n\r\n<img width=\"1311\" alt=\"Screenshot 2024-11-01 at 18 14 36\"\r\nsrc=\"https://github.com/user-attachments/assets/cf9d08fd-a809-4530-b653-d12b8e643e45\">\r\n\r\n### Behaviour after the fix\r\n\r\nWe show only indices with `semantic_text` fields\r\n\r\n<img width=\"1311\" alt=\"Screenshot 2024-11-01 at 18 08 29\"\r\nsrc=\"https://github.com/user-attachments/assets/864b5552-aece-4cc6-848a-8f73f88f55dc\">\r\n\r\n### Testing notes\r\n\r\nCreate some indices with `semantic_text` fields. For example, you can do\r\nthat via uploading and indexing a PDF file:\r\n\r\n1. Navigate to Integrations page\r\n2. Select \"Upload a file\"\r\n3. Select and upload a PDF file\r\n4. Press Import button\r\n5. Switch to Advanced tab\r\n6. Fill in \"Index name\"\r\n7. Add additional field > Add semantic text field > Fill in form\r\n * Field: `attachment.content`\r\n * Copy to field: `content`\r\n * Inference endpoint: `elser_model_2`\r\n8. Press Add button\r\n9. Press Import button\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"b122722d886b66431108a33d0eac2447a63da179"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <[email protected]>
…x60;semantic_text` fields (#198707) (#198907) # Backport This will backport the following commits from `main` to `8.x`: - [[Security GenAI][BUG] Knowledge Base: Show only indices with `semantic_text` fields (#198707)](#198707) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ievgen Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T10:12:33Z","message":"[Security GenAI][BUG] Knowledge Base: Show only indices with `semantic_text` fields (#198707)\n\n## Summary\r\n\r\nThis is a fix the next issue:\r\n\r\n> Index input should only list indices with semantic_text fields, not\r\nall indices.\r\n\r\n### Current behaviour\r\n\r\nWe show all available indices\r\n\r\n<img width=\"1311\" alt=\"Screenshot 2024-11-01 at 18 14 36\"\r\nsrc=\"https://github.com/user-attachments/assets/cf9d08fd-a809-4530-b653-d12b8e643e45\">\r\n\r\n### Behaviour after the fix\r\n\r\nWe show only indices with `semantic_text` fields\r\n\r\n<img width=\"1311\" alt=\"Screenshot 2024-11-01 at 18 08 29\"\r\nsrc=\"https://github.com/user-attachments/assets/864b5552-aece-4cc6-848a-8f73f88f55dc\">\r\n\r\n### Testing notes\r\n\r\nCreate some indices with `semantic_text` fields. For example, you can do\r\nthat via uploading and indexing a PDF file:\r\n\r\n1. Navigate to Integrations page\r\n2. Select \"Upload a file\"\r\n3. Select and upload a PDF file\r\n4. Press Import button\r\n5. Switch to Advanced tab\r\n6. Fill in \"Index name\"\r\n7. Add additional field > Add semantic text field > Fill in form\r\n * Field: `attachment.content`\r\n * Copy to field: `content`\r\n * Inference endpoint: `elser_model_2`\r\n8. Press Add button\r\n9. Press Import button\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"b122722d886b66431108a33d0eac2447a63da179","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","backport:version","v8.17.0","v8.16.1"],"title":"[Security GenAI][BUG] Knowledge Base: Show only indices with `semantic_text` fields","number":198707,"url":"https://github.com/elastic/kibana/pull/198707","mergeCommit":{"message":"[Security GenAI][BUG] Knowledge Base: Show only indices with `semantic_text` fields (#198707)\n\n## Summary\r\n\r\nThis is a fix the next issue:\r\n\r\n> Index input should only list indices with semantic_text fields, not\r\nall indices.\r\n\r\n### Current behaviour\r\n\r\nWe show all available indices\r\n\r\n<img width=\"1311\" alt=\"Screenshot 2024-11-01 at 18 14 36\"\r\nsrc=\"https://github.com/user-attachments/assets/cf9d08fd-a809-4530-b653-d12b8e643e45\">\r\n\r\n### Behaviour after the fix\r\n\r\nWe show only indices with `semantic_text` fields\r\n\r\n<img width=\"1311\" alt=\"Screenshot 2024-11-01 at 18 08 29\"\r\nsrc=\"https://github.com/user-attachments/assets/864b5552-aece-4cc6-848a-8f73f88f55dc\">\r\n\r\n### Testing notes\r\n\r\nCreate some indices with `semantic_text` fields. For example, you can do\r\nthat via uploading and indexing a PDF file:\r\n\r\n1. Navigate to Integrations page\r\n2. Select \"Upload a file\"\r\n3. Select and upload a PDF file\r\n4. Press Import button\r\n5. Switch to Advanced tab\r\n6. Fill in \"Index name\"\r\n7. Add additional field > Add semantic text field > Fill in form\r\n * Field: `attachment.content`\r\n * Copy to field: `content`\r\n * Inference endpoint: `elser_model_2`\r\n8. Press Add button\r\n9. Press Import button\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"b122722d886b66431108a33d0eac2447a63da179"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198707","number":198707,"mergeCommit":{"message":"[Security GenAI][BUG] Knowledge Base: Show only indices with `semantic_text` fields (#198707)\n\n## Summary\r\n\r\nThis is a fix the next issue:\r\n\r\n> Index input should only list indices with semantic_text fields, not\r\nall indices.\r\n\r\n### Current behaviour\r\n\r\nWe show all available indices\r\n\r\n<img width=\"1311\" alt=\"Screenshot 2024-11-01 at 18 14 36\"\r\nsrc=\"https://github.com/user-attachments/assets/cf9d08fd-a809-4530-b653-d12b8e643e45\">\r\n\r\n### Behaviour after the fix\r\n\r\nWe show only indices with `semantic_text` fields\r\n\r\n<img width=\"1311\" alt=\"Screenshot 2024-11-01 at 18 08 29\"\r\nsrc=\"https://github.com/user-attachments/assets/864b5552-aece-4cc6-848a-8f73f88f55dc\">\r\n\r\n### Testing notes\r\n\r\nCreate some indices with `semantic_text` fields. For example, you can do\r\nthat via uploading and indexing a PDF file:\r\n\r\n1. Navigate to Integrations page\r\n2. Select \"Upload a file\"\r\n3. Select and upload a PDF file\r\n4. Press Import button\r\n5. Switch to Advanced tab\r\n6. Fill in \"Index name\"\r\n7. Add additional field > Add semantic text field > Fill in form\r\n * Field: `attachment.content`\r\n * Copy to field: `content`\r\n * Inference endpoint: `elser_model_2`\r\n8. Press Add button\r\n9. Press Import button\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"b122722d886b66431108a33d0eac2447a63da179"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ievgen Sorokopud <[email protected]>
Summary
This is a fix the next issue:
Current behaviour
We show all available indices
Behaviour after the fix
We show only indices with
semantic_text
fieldsTesting notes
Create some indices with
semantic_text
fields. For example, you can do that via uploading and indexing a PDF file:attachment.content
content
elser_model_2
Checklist
Delete any items that are not applicable to this PR.