Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CODEOWNERS for @kbn/typed-react-router-config #198569

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Update CODEOWNERS for @kbn/typed-react-router-config #198569

merged 5 commits into from
Nov 4, 2024

Conversation

jasonrhodes
Copy link
Member

Removes obs-ux-management and replaces with obx-ux-infra_services-team, based on this count of imports for this package:

   4 observability_ai_assistant_app
  38 apm
   1 ux
  12 profiling
   5 inventory
   5 observability_ai_assistant_management

Got these stats with these two steps:

ag -Q "@kbn/typed-react-router-config" --ignore="*target*" --ignore="*tsconfig.json" -c ./x-pack/plugins | tee typed-react-router-config-USAGE.log

cat typed-react-router-config-USAGE.log | cut -d "/" -f 4-4 | uniq -c

@jasonrhodes
Update CODEOWNERS for @kbn/typed-react-router-config
cfa7c38 
Removes obs-ux-management and replaces with obx-ux-infra_services-team, based on this count of imports for this package:

```
   4 observability_ai_assistant_app
  38 apm
   1 ux
  12 profiling
   5 inventory
   5 observability_ai_assistant_management
```
kibanamachine and others added 2 commits October 31, 2024 15:49
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/generate codeowners'
594c7bd
@jasonrhodes
Update kibana.jsonc
26a6633 
I originally tried to edit the CODEOWNERS but I forgot that's auto-generated and relies on these kibana.jsonc files. This should be the correct change now.
@jasonrhodes jasonrhodes requested review from a team as code owners November 4, 2024 17:13
@jasonrhodes
Copy link
Member Author

Update: I had originally changed CODEOWNERS directly but that gets auto-generated so CI reverted it automatically based on the contents of the kibana.jsonc file in the package root dir. I've now updated the right values in that kibana.jsonc file.

@jasonrhodes
Copy link
Member Author

@elasticmachine merge upstream

@jasonrhodes jasonrhodes added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Nov 4, 2024
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

@jasonrhodes jasonrhodes merged commit 2de0e05 into main Nov 4, 2024
36 checks passed
@jasonrhodes jasonrhodes deleted the update-codeowners_typed-react-router-config branch November 4, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdelemme kdelemme kdelemme approved these changes

@smith smith smith approved these changes

@paulb-elastic paulb-elastic Awaiting requested review from paulb-elastic

@emma-raffenne emma-raffenne Awaiting requested review from emma-raffenne

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasonrhodes @elasticmachine @smith @kdelemme @kibanamachine