[ML] Convert anomalies controls to EUI / React #19856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
v7.0.0
v6.4.0
:ml
Feature:ml-results
|
Pinging @elastic/ml-ui |
jgowdyelastic
approved these changes
Jun 13, 2018
| }; | ||
| } | ||
| // Restore the checked setting from the state. | ||
| const mlCheckboxShowChartsService = this.props.mlCheckboxShowChartsService; |
There was a problem hiding this comment.
nit. could be added as a class variable. e.g. this.mlCheckboxShowChartsService = ...
so it doesn't then have to be read out of the props again in the onChange function
| function optionValueToInterval(value) { | ||
| // Builds the corresponding interval object with the required display and val properties | ||
| // from the specified value. | ||
| const option = OPTIONS.find(opt => opt.value === value); |
There was a problem hiding this comment.
nit. conditions should be wrapped in braces.
const option = OPTIONS.find(opt => (opt.value === value));
|
|
||
| import template from './select_severity.html'; | ||
| import 'plugins/ml/components/controls/controls_select'; | ||
| const OPTIONS = [ |
There was a problem hiding this comment.
these colours are hardcoded a number if times throughout our code base.
It would be nice to move them to a constants file.
getSeverityColor also exists to return a colour based on score, this could also be used here to avoid the hard coding of the hex values.
walterra
approved these changes
Jun 13, 2018
💚 Build Succeeded |
💚 Build Succeeded |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Jun 14, 2018
* [ML] Convert anomalies controls to EUI / React * [ML] Edits to anomaly controls following review
peteharverson
added a commit
that referenced
this pull request
Jun 14, 2018
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Jun 25, 2018
* [ML] Convert anomalies controls to EUI / React * [ML] Edits to anomaly controls following review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the three controls for the Anomalies table and charts in the Anomaly Explorer and Single Metric Viewer to EUI / React.
Before:
After:
The units tests for the old Angular based controls have been removed, and will be replaced by Jest tests in a future PR.
Addresses items in the Controls section of #18374