Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps] Remove 7.x deprecated kibana.yml settings #198435

Merged
merged 13 commits into from
Nov 4, 2024
Merged

[ResponseOps] Remove 7.x deprecated kibana.yml settings #198435

merged 13 commits into from
Nov 4, 2024

Conversation

doakalexi
Copy link
Contributor

@doakalexi doakalexi commented Oct 30, 2024 •
edited
Loading

Resolves #194622

Summary

Removes the following deprecated configuration settings:

  • xpack.actions.customHostSettings.ssl.rejectUnauthorized
  • xpack.actions.whitelistedHosts
  • xpack.actions.rejectUnauthorized
  • xpack.actions.proxyRejectUnauthorizedCertificates
  • xpack.alerts.healthCheck
  • xpack.alerts.invalidateApiKeysTask.interval
  • xpack.alerts.invalidateApiKeysTask.removalDelay
  • xpack.alerting.defaultRuleTaskTimeout

@github-actions GitHub Actions
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@doakalexi doakalexi added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v9.0.0 labels Oct 31, 2024
@doakalexi doakalexi changed the title Removing xpack.actions.customHostSettings.ssl.rejectUnauthorized [ResponseOps] Remove 7.x deprecated kibana.yml settings Oct 31, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@doakalexi doakalexi marked this pull request as ready for review November 1, 2024 14:25
@doakalexi doakalexi requested review from a team as code owners November 1, 2024 14:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

jbudz
jbudz approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding release_note:breaking?

@doakalexi doakalexi added release_note:breaking and removed release_note:skip Skip the PR/issue when compiling release notes labels Nov 1, 2024
js-jankisalvi
js-jankisalvi approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pmuellr
Copy link
Member

pmuellr commented Nov 4, 2024

Seeing the kibana-docker file led me to wondering about the validation stuff we have in cloud, appears to be in files:

  • scala-services/adminconsole/src/main/resources/settings/kibana/alerting.yml
  • scala-services/adminconsole/src/test/resources/settings/kibana_tests.yml

Do we need some things removed from there as well?

pmuellr
pmuellr approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except the comment I left about queueing empheral tasks. Guessing there will be more work to remove all the ephermal task stuff, but seems like we should stop queueing them in this PR. Pinged Mike because I don't know the full context here.

x-pack/plugins/alerting/server/task_runner/action_scheduler/action_scheduler.ts Outdated
@@ -183,11 +180,7 @@ export class ActionScheduler<
enqueueOptions: EnqueueExecutionOptions;
bulkScheduleRequest: EnqueueExecutionOptions[];
}) {
if (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem quite right. If for some reason this.context.taskRunnerContext.supportsEphemeralTasks becomes true, I think we'd end up scheduling all the tasks with it, whereas before we would have only done context.taskRunnerContext.maxEphemeralActionsPerRule of them.

I wonder if we should either remove queueing these as emphermeral completely here, or something else. @mikecote ?

Copy link
Contributor

@mikecote mikecote Nov 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh actually this is my mistake, we have @JiaweiWu who's working on making this setting no-op and removing the ephemeral task code in #197421. Perhaps we can leave this one out from this PR. Sorry about that!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay sounds good, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved in this commit 375e71e

@doakalexi
Copy link
Contributor Author

#194622

Seeing the kibana-docker file led me to wondering about the validation stuff we have in cloud, appears to be in files:

  • scala-services/adminconsole/src/main/resources/settings/kibana/alerting.yml
  • scala-services/adminconsole/src/test/resources/settings/kibana_tests.yml

Do we need some things removed from there as well?

Yes, thanks! Here is the cloud pr https://github.com/elastic/cloud/pull/133738

@doakalexi doakalexi merged commit 9efe20e into elastic:main Nov 4, 2024
39 checks passed
kilfoyle added a commit to kilfoyle/kibana that referenced this pull request Nov 4, 2024
@kilfoyle
Add settings changes from Kibana elastic#198435
642b207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecote mikecote mikecote left review comments

@adcoelho adcoelho adcoelho left review comments

@pmuellr pmuellr pmuellr approved these changes

@js-jankisalvi js-jankisalvi js-jankisalvi approved these changes

@jbudz jbudz jbudz approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:breaking Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove 7.x deprecated kibana.yml settings
8 participants
@doakalexi @elasticmachine @pmuellr @adcoelho @jbudz @mikecote @js-jankisalvi @kibanamachine