Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Remove container and host tsvb fields #198134

Conversation

jennypavlova
Copy link
Member

@jennypavlova jennypavlova commented Oct 29, 2024

Closes #197993

Summary

This PR removes the old tsvb fields used for containers before we changed to the asset details view. They were used for displaying charts but now we use lens formulas so those are no longer needed

Testing

This PR removes old no longer used code so the testing should be for regressions

  • Go to Infrastructure Inventory

  • Select Docker Container from the Show drop-down

  • Click on any container:
    image

  • The asset details flyout and full page view should load as before (the same as for hosts)

  • Repeat same steps for host (and k8s pod)

@jennypavlova jennypavlova added technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Oct 29, 2024
@jennypavlova jennypavlova self-assigned this Oct 29, 2024
@jennypavlova jennypavlova requested review from a team as code owners October 29, 2024 10:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Oct 29, 2024
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@jennypavlova
Copy link
Member Author

/oblt-deploy

@jennypavlova jennypavlova changed the title [Infra] Remove container tsvb fields [Infra] Remove container and host tsvb fields Oct 29, 2024
@jennypavlova
Copy link
Member Author

/oblt-deploy

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 4, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: bed0d0a
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-198134-bed0d0a931cc

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #45 / serverless search UI connectors has embedded dev console
  • [job] [logs] FTR Configs #87 / task_manager task management scheduled at "before all" hook for "sets scheduledAt to runAt if retryAt is null"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
metricsDataAccess 319 293 -26

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
metricsDataAccess 137 135 -2

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
metricsDataAccess 8 6 -2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.7MB 1.7MB +156.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
metricsDataAccess 62.0KB 44.3KB -17.7KB
Unknown metric groups

API count

id before after diff
metricsDataAccess 137 135 -2

History

cc @jennypavlova

Copy link
Contributor

@rmyz rmyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and worked fine, LGTM 🚀

@jennypavlova jennypavlova merged commit d4e4f9b into elastic:main Nov 5, 2024
27 checks passed
mgadewoll pushed a commit to mgadewoll/kibana that referenced this pull request Nov 7, 2024
Closes elastic#197993
## Summary

This PR removes the old tsvb fields used for containers before we
changed to the asset details view. They were used for displaying charts
but now we use lens formulas so those are no longer needed

## Testing

This PR removes old no longer used code so the testing should be for
regressions
- Go to Infrastructure Inventory
- Select Docker Container from the `Show` drop-down
- Click on any container: 

![image](https://github.com/user-attachments/assets/20f66745-4cbd-4700-b2c5-c43ee753b2cb)

- The asset details flyout and full page view should load as before (the
same as for hosts)
- Repeat same steps for host (and k8s pod)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team technical debt Improvement of the software architecture and operational architecture v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Infra] Remove container and host tsvb fields
4 participants