-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra] Remove container and host tsvb fields #198134
[Infra] Remove container and host tsvb fields #198134
Conversation
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
/oblt-deploy |
/oblt-deploy |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Any counts in public APIs
Async chunks
Page load bundle
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and worked fine, LGTM 🚀
Closes elastic#197993 ## Summary This PR removes the old tsvb fields used for containers before we changed to the asset details view. They were used for displaying charts but now we use lens formulas so those are no longer needed ## Testing This PR removes old no longer used code so the testing should be for regressions - Go to Infrastructure Inventory - Select Docker Container from the `Show` drop-down - Click on any container: ![image](https://github.com/user-attachments/assets/20f66745-4cbd-4700-b2c5-c43ee753b2cb) - The asset details flyout and full page view should load as before (the same as for hosts) - Repeat same steps for host (and k8s pod)
Closes #197993
Summary
This PR removes the old tsvb fields used for containers before we changed to the asset details view. They were used for displaying charts but now we use lens formulas so those are no longer needed
Testing
This PR removes old no longer used code so the testing should be for regressions
Go to Infrastructure Inventory
Select Docker Container from the
Show
drop-downClick on any container:
The asset details flyout and full page view should load as before (the same as for hosts)
Repeat same steps for host (and k8s pod)