Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTR][Ownership] Assign rendering_plugin, etc #198024

Merged
merged 10 commits into from
Oct 31, 2024

Conversation

wayneseymour
Copy link
Member

@wayneseymour wayneseymour commented Oct 28, 2024

Summary

Assign ownership for a handful of reviewing teams.

Assignment Reasons

Assigned rendering_plugin due to https://github.com/elastic/kibana/blob/main/test/plugin_functional/plugins/rendering_plugin/kibana.jsonc#L3-L4

Assigned session_notifications due to https://github.com/elastic/kibana/blob/main/test/plugin_functional/plugins/session_notifications/kibana.jsonc#L4

Assigned saml_provider due to https://github.com/elastic/kibana/blob/main/x-pack/test/cloud_integration/plugins/saml_provider/kibana.jsonc#L4

Assigned defend_workflows_cypress due to the name

Assigned riggers_actions_ui_examples due to https://github.com/elastic/kibana/blob/main/api_docs/triggers_actions_ui.mdx#L18

  • It says "Contact @elastic/response-ops for questions regarding this plugin."

Assigned fleet_packages due to the name

Assigned management due to the name

Assigned painless_lab due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/painless_lab/kibana.jsonc#L5

Assigned remote_clusters due to https://github.com/elastic/kibana/blob/main/api_docs/remote_clusters.mdx#L18

Assigned logstash due to the name

Assigned license_management due to https://github.com/elastic/kibana/blob/main/api_docs/license_management.mdx#L18

  • It says "Contact @elastic/kibana-management for questions regarding this plugin."

Assigned iframe_embedded due to https://github.com/elastic/kibana/blob/main/x-pack/test/functional_embedded/plugins/iframe_embedded/kibana.jsonc#L3-L4

Assigned functional_solution_sidenav due to #189804 (and git blame)

Assigned cases due to https://github.com/elastic/kibana/blob/main/api_docs/cases.mdx#L18

  • It says "Contact @elastic/response-ops for questions regarding this plugin."

Contributes to:
#192979

pheyos and others added 8 commits October 25, 2024 13:21
Assigned rendering_plugin due to https://github.com/elastic/kibana/blob/main/test/plugin_functional/plugins/rendering_plugin/kibana.jsonc#L3-L4

Assigned session_notifications due to https://github.com/elastic/kibana/blob/main/test/plugin_functional/plugins/session_notifications/kibana.jsonc#L4

Assigned saml_provider due to https://github.com/elastic/kibana/blob/main/x-pack/test/cloud_integration/plugins/saml_provider/kibana.jsonc#L4

Assigned defend_workflows_cypress due to the name

Assigned riggers_actions_ui_examples due to https://github.com/elastic/kibana/blob/main/api_docs/triggers_actions_ui.mdx#L18
 - It says "Contact @elastic/response-ops for questions regarding this plugin."

Assigned fleet_packages due to the name

Assigned management due to the name

Assigned painless_lab due to https://github.com/elastic/kibana/blob/main/x-pack/plugins/painless_lab/kibana.jsonc#L5

Assigned remote_clusters due to https://github.com/elastic/kibana/blob/main/api_docs/remote_clusters.mdx#L18

Assigned logstash due to the name

Assigned license_management due to https://github.com/elastic/kibana/blob/main/api_docs/license_management.mdx#L18
 - It says "Contact @elastic/kibana-management for questions regarding this plugin."

 Assigned iframe_embedded due to https://github.com/elastic/kibana/blob/main/x-pack/test/functional_embedded/plugins/iframe_embedded/kibana.jsonc#L3-L4

 Assigned functional_solution_sidenav due to elastic#189804 (and git blame)

Assigned cases due to https://github.com/elastic/kibana/blob/main/api_docs/cases.mdx#L18
 - It says "Contact @elastic/response-ops for questions regarding this plugin."

 Contributes to: elastic#192979
@wayneseymour wayneseymour added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Oct 28, 2024
@wayneseymour wayneseymour requested review from a team October 28, 2024 15:20
@wayneseymour wayneseymour self-assigned this Oct 28, 2024
@wayneseymour wayneseymour requested review from joeypoon and gergoabraham and removed request for a team October 28, 2024 15:20
Copy link
Contributor

@gergoabraham gergoabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, thank you for adding @elastic/security-defend-workflows for the defend_workflows_cypress folder! 🙌

Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResponseOps ownership lgtm!

@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

✅ unchanged

History

cc @wayneseymour

@wayneseymour wayneseymour merged commit 5499b69 into elastic:main Oct 31, 2024
23 checks passed
@wayneseymour wayneseymour deleted the assign-rendering-plugin-etc branch October 31, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants