Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Remove sample data #197733

Merged
merged 6 commits into from
Oct 31, 2024
Merged

[Canvas] Remove sample data #197733

merged 6 commits into from
Oct 31, 2024

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Oct 24, 2024 •
edited
Loading

Summary

Removes the sample data from main (9.0).

Some async feedback here

For maintainers

@thomasneirynck
Copy link
Contributor Author

/ci

@thomasneirynck
Copy link
Contributor Author

/ci

@thomasneirynck thomasneirynck marked this pull request as ready for review October 25, 2024 15:30
@thomasneirynck thomasneirynck requested a review from a team as a code owner October 25, 2024 15:30
@thomasneirynck thomasneirynck added chore v9.0.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Oct 25, 2024
@thomasneirynck thomasneirynck marked this pull request as draft October 25, 2024 15:31
@thomasneirynck
Copy link
Contributor Author

/ci

@thomasneirynck thomasneirynck marked this pull request as ready for review October 29, 2024 13:24
@elasticmachine
Copy link
Contributor

💔 Build Failed

Failed CI Steps

History

@thomasneirynck
Copy link
Contributor Author

@nreese wondered if we should keep the sample-workpads when starting up in dev-mode. Agreed it would be convenient to have for debugging. When removed from 9.x, the work-around now would be to export the workpad from an 8.x deployment and import them in 9.x with the import/export UX.

imho, that work-around s a reasonably minor extra step, and to keep things clean, I would just do a clean remove as shown here.

@nreese nreese self-requested a review October 30, 2024 17:46
nreese
nreese approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for removing up canvas sample work pads

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@thomasneirynck thomasneirynck merged commit 0ad421b into elastic:main Oct 31, 2024
22 checks passed
nreese pushed a commit to nreese/kibana that referenced this pull request Nov 1, 2024
@thomasneirynck @nreese
[Canvas] Remove sample data (elastic#197733)
f4cd49f 
## Summary

Removes the Canvas sample data from `main` (9.0).

Some async feedback
[here](elastic#197733 (comment))

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels)
@nreese nreese mentioned this pull request Nov 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

@teresaalvarezsoler teresaalvarezsoler Awaiting requested review from teresaalvarezsoler

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomasneirynck @elasticmachine @nreese