Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Assistant] Revert open AI Assistant settings in new tab #197725

Merged
merged 1 commit into from
Oct 24, 2024
Merged

[Security Assistant] Revert open AI Assistant settings in new tab #197725

merged 1 commit into from
Oct 24, 2024

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Oct 24, 2024 •
edited by kibanamachine
Loading

Summary

Revert changes made in this PR #197323 to open assistant settings in new tab from context menu. This had unintended consequences, so we are reverting back to opening the assistant settings in the same tab. Below is a recording of the behavior we are moving forward with:

a.mov

@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) Team:Security Generative AI Security Generative AI labels Oct 24, 2024
@stephmilovic stephmilovic requested a review from a team as a code owner October 24, 2024 20:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.3MB 20.3MB -268.0B

@stephmilovic stephmilovic merged commit d2aa007 into elastic:main Oct 24, 2024
47 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11508612213

@stephmilovic stephmilovic added v8.16.0 backport:version Backport to applied version labels v8.17.0 and removed backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Oct 24, 2024
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11508637516

@kibanamachine kibanamachine mentioned this pull request Oct 24, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 24, 2024
@stephmilovic
[Security Assistant] Revert open AI Assistant settings in new tab (el…
e65775f 
…astic#197725)

(cherry picked from commit d2aa007)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 8.16 Cherrypick failed because the selected commit (d2aa007) is empty. Did you already backport this commit?
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 197725

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 25, 2024
@kibanamachine @stephmilovic
[8.x] [Security Assistant] Revert open AI Assistant settings in new t…
67abfdc 
…ab (#197725) (#197746)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security Assistant] Revert open AI Assistant settings in new tab
(#197725)](#197725)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Steph
Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T22:44:45Z","message":"[Security
Assistant] Revert open AI Assistant settings in new tab
(#197725)","sha":"d2aa00708309fdf85deb03870f65960ec78161cf","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:
SecuritySolution","backport:prev-minor","Team:Security Generative
AI"],"title":"[Security Assistant] Revert open AI Assistant settings in
new
tab","number":197725,"url":"https://github.com/elastic/kibana/pull/197725","mergeCommit":{"message":"[Security
Assistant] Revert open AI Assistant settings in new tab
(#197725)","sha":"d2aa00708309fdf85deb03870f65960ec78161cf"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197725","number":197725,"mergeCommit":{"message":"[Security
Assistant] Revert open AI Assistant settings in new tab
(#197725)","sha":"d2aa00708309fdf85deb03870f65960ec78161cf"}}]}]
BACKPORT-->

Co-authored-by: Steph Milovic <[email protected]>
@stephmilovic stephmilovic mentioned this pull request Oct 25, 2024
Merged
@stephmilovic
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Oct 25, 2024
@stephmilovic
[Security Assistant] Revert open AI Assistant settings in new tab (el…
a96228c 
…astic#197725)

(cherry picked from commit d2aa007)
stephmilovic added a commit that referenced this pull request Oct 25, 2024
@stephmilovic
[8.16] [Security Assistant] Revert open AI Assistant settings in new …
95635d3 
…tab (#197725) (#197857)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Security Assistant] Revert open AI Assistant settings in new tab
(#197725)](#197725)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Steph
Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T22:44:45Z","message":"[Security
Assistant] Revert open AI Assistant settings in new tab
(#197725)","sha":"d2aa00708309fdf85deb03870f65960ec78161cf","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:
SecuritySolution","Team:Security Generative
AI","v8.16.0","backport:version","v8.17.0"],"number":197725,"url":"https://github.com/elastic/kibana/pull/197725","mergeCommit":{"message":"[Security
Assistant] Revert open AI Assistant settings in new tab
(#197725)","sha":"d2aa00708309fdf85deb03870f65960ec78161cf"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197725","number":197725,"mergeCommit":{"message":"[Security
Assistant] Revert open AI Assistant settings in new tab
(#197725)","sha":"d2aa00708309fdf85deb03870f65960ec78161cf"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/197746","number":197746,"state":"MERGED","mergeCommit":{"sha":"67abfdc08366f041b0de3542deb5ac80fd2eed29","message":"[8.x]
[Security Assistant] Revert open AI Assistant settings in new tab
(#197725) (#197746)\n\n# Backport\n\nThis will backport the following
commits from `main` to `8.x`:\n- [[Security Assistant] Revert open AI
Assistant settings in new
tab\n(#197725)](https://github.com/elastic/kibana/pull/197725)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Steph\nMilovic\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-24T22:44:45Z\",\"message\":\"[Security\nAssistant]
Revert open AI Assistant settings in new
tab\n(#197725)\",\"sha\":\"d2aa00708309fdf85deb03870f65960ec78161cf\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"Team:\nSecuritySolution\",\"backport:prev-minor\",\"Team:Security
Generative\nAI\"],\"title\":\"[Security Assistant] Revert open AI
Assistant settings
in\nnew\ntab\",\"number\":197725,\"url\":\"https://github.com/elastic/kibana/pull/197725\",\"mergeCommit\":{\"message\":\"[Security\nAssistant]
Revert open AI Assistant settings in new
tab\n(#197725)\",\"sha\":\"d2aa00708309fdf85deb03870f65960ec78161cf\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/197725\",\"number\":197725,\"mergeCommit\":{\"message\":\"[Security\nAssistant]
Revert open AI Assistant settings in new
tab\n(#197725)\",\"sha\":\"d2aa00708309fdf85deb03870f65960ec78161cf\"}}]}]\nBACKPORT-->\n\nCo-authored-by:
Steph Milovic <[email protected]>"}}]}] BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephmilovic @elasticmachine @kibanamachine @patrykkopycinski