[8.x] [Index Management] Fix unhandled error in ds data retention modal (#196524)

[kibanamachine]

Backport

This will backport the following commits from main to 8.x:

• [Index Management] Fix unhandled error in ds data retention modal (#196524)

Questions ?

Please refer to the Backport tool documentation

\r\nClick \"Manage\" --> Click \"Edit data retention\"\r\n4. Disable the toggle \"Keep data up to maximum retention period\"\r\n5. Verify that the field is enabled correctly, there is not endless\r\nspinner, and no console error.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/957e0869-ee23-46d9-8f20-134937f6f8cf\r\n\r\n---------\r\n\r\nCo-authored-by: Matthew Kime ","sha":"d8fa996c5052d10da2f438b93723437f5631bbde","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index Management","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-minor","v8.17.0"],"title":"[Index Management] Fix unhandled error in ds data retention modal","number":196524,"url":"https://github.com//pull/196524","mergeCommit":{"message":"[Index Management] Fix unhandled error in ds data retention modal (#196524)\n\nFixes https://github.com//issues/196331\r\n\r\n## Summary\r\n\r\nThis PR fixes the bug in the Edit ds data retention modal where we were\r\ncomparing the max retention period with an undefined `value` (now the\r\ncomparison happens only if `value` is defined). Also, the PR makes the\r\ndata retention field get re-validated only when the time unit changes\r\n(otherwise, when we switch off the toggle to enable to data retention\r\nfield, the field would get validated and would immediately show an error\r\n\"A data retention value is required.\" which is not great UX).\r\n\r\n### How to test:\r\n1. Start serverless ES with `yarn es serverless --projectType=security\r\n-E data_streams.lifecycle.retention.max=200d` and kibana with `yarn\r\nserverless-security`\r\n2. Navigate to Kibana, create a data stream using Dev Tools:\r\n```\r\nPUT _index_template/ds\r\n{\r\n \"index_patterns\": [\"ds\"],\r\n \"data_stream\": {}\r\n}\r\n\r\nPOST ds/_doc\r\n{\r\n \"@timestamp\": \"2020-01-27\"\r\n}\r\n```\r\n3. Navigate to Index Management. Find the data stream and select it -->\r\nClick \"Manage\" --> Click \"Edit data retention\"\r\n4. Disable the toggle \"Keep data up to maximum retention period\"\r\n5. Verify that the field is enabled correctly, there is not endless\r\nspinner, and no console error.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/957e0869-ee23-46d9-8f20-134937f6f8cf\r\n\r\n---------\r\n\r\nCo-authored-by: Matthew Kime ","sha":"d8fa996c5052d10da2f438b93723437f5631bbde"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com//pull/196524","number":196524,"mergeCommit":{"message":"[Index Management] Fix unhandled error in ds data retention modal (#196524)\n\nFixes https://github.com//issues/196331\r\n\r\n## Summary\r\n\r\nThis PR fixes the bug in the Edit ds data retention modal where we were\r\ncomparing the max retention period with an undefined `value` (now the\r\ncomparison happens only if `value` is defined). Also, the PR makes the\r\ndata retention field get re-validated only when the time unit changes\r\n(otherwise, when we switch off the toggle to enable to data retention\r\nfield, the field would get validated and would immediately show an error\r\n\"A data retention value is required.\" which is not great UX).\r\n\r\n### How to test:\r\n1. Start serverless ES with `yarn es serverless --projectType=security\r\n-E data_streams.lifecycle.retention.max=200d` and kibana with `yarn\r\nserverless-security`\r\n2. Navigate to Kibana, create a data stream using Dev Tools:\r\n```\r\nPUT _index_template/ds\r\n{\r\n \"index_patterns\": [\"ds\"],\r\n \"data_stream\": {}\r\n}\r\n\r\nPOST ds/_doc\r\n{\r\n \"@timestamp\": \"2020-01-27\"\r\n}\r\n```\r\n3. Navigate to Index Management. Find the data stream and select it -->\r\nClick \"Manage\" --> Click \"Edit data retention\"\r\n4. Disable the toggle \"Keep data up to maximum retention period\"\r\n5. Verify that the field is enabled correctly, there is not endless\r\nspinner, and no console error.\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/957e0869-ee23-46d9-8f20-134937f6f8cf\r\n\r\n---------\r\n\r\nCo-authored-by: Matthew Kime ","sha":"d8fa996c5052d10da2f438b93723437f5631bbde"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: d0b281a

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
indexManagement	693	694	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
indexManagement	687.8KB	688.2KB	+455.0B

cc @ElenaStoeva