Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sustainable Kibana Architecture] Address security group dependencies' issues #197480

Merged
merged 6 commits into from
Oct 25, 2024
Merged

[Sustainable Kibana Architecture] Address security group dependencies' issues #197480

merged 6 commits into from
Oct 25, 2024

Conversation

gsoldevila
Copy link
Contributor

@gsoldevila gsoldevila commented Oct 23, 2024 •
edited by kibanamachine
Loading

Summary

In the scope of Sustainable Kibana Architecture, this PR fixes invalid dependencies from security solution code towards packages that are categorised as group: 'platform', visibility: 'private'.

@gsoldevila gsoldevila added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development labels Oct 23, 2024
@gsoldevila gsoldevila requested review from a team as code owners October 23, 2024 15:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

szaffarano
szaffarano approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@szaffarano szaffarano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsoldevila gsoldevila changed the title [Kibana Sustainable Architecture] Address security group dependencies' issues [Sustainable Kibana Architecture] Address security group dependencies' issues Oct 23, 2024
@gsoldevila gsoldevila force-pushed the kbn-team-1066-address-security-group-issues branch from 62d2b60 to c49366f Compare October 24, 2024 05:55
@gsoldevila gsoldevila requested a review from a team as a code owner October 24, 2024 07:35
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Oct 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
savedObjectsTagging 83 30 -53
savedObjectsTaggingOss 53 58 +5
total -48

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
savedObjectsTaggingOss 1 0 -1
Unknown metric groups

API count

id before after diff
savedObjectsTagging 89 36 -53
savedObjectsTaggingOss 100 105 +5
total -48

History

@gsoldevila gsoldevila merged commit 6e3bf77 into elastic:main Oct 25, 2024
46 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11515563571

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 25, 2024
@gsoldevila
[Sustainable Kibana Architecture] Address security group dependenci…
80ecc11 
…es' issues (elastic#197480)

## Summary

In the scope of [Sustainable Kibana
Architecture](elastic/kibana-team#1179), this
PR fixes invalid dependencies from `security solution` code towards
packages that are categorised as `group: 'platform', visibility:
'private'`.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 6e3bf77)
@kibanamachine kibanamachine mentioned this pull request Oct 25, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 25, 2024
@gsoldevila
[Sustainable Kibana Architecture] Address security group dependenci…
1bfc9f3 
…es' issues (elastic#197480)

## Summary

In the scope of [Sustainable Kibana
Architecture](elastic/kibana-team#1179), this
PR fixes invalid dependencies from `security solution` code towards
packages that are categorised as `group: 'platform', visibility:
'private'`.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 6e3bf77)
@kibanamachine kibanamachine mentioned this pull request Oct 25, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 25, 2024
@gsoldevila
[Sustainable Kibana Architecture] Address security group dependenci…
97830f2 
…es' issues (elastic#197480)

## Summary

In the scope of [Sustainable Kibana
Architecture](elastic/kibana-team#1179), this
PR fixes invalid dependencies from `security solution` code towards
packages that are categorised as `group: 'platform', visibility:
'private'`.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 6e3bf77)
@kibanamachine kibanamachine mentioned this pull request Oct 25, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.15
✅ 8.16
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

gsoldevila added a commit to gsoldevila/kibana that referenced this pull request Oct 25, 2024
@gsoldevila
Remove exception, fixed by elastic#197480
6b79b88
kibanamachine added a commit that referenced this pull request Oct 25, 2024
@kibanamachine @gsoldevila
[8.15] [Sustainable Kibana Architecture] Address &#x60;security&#x60;…
db772d0 
… group dependencies&#x27; issues (#197480) (#197783)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Sustainable Kibana Architecture] Address &#x60;security&#x60; group
dependencies&#x27; issues
(#197480)](#197480)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-25T09:26:05Z","message":"[Sustainable
Kibana Architecture] Address `security` group dependencies' issues
(#197480)\n\n## Summary\r\n\r\nIn the scope of [Sustainable
Kibana\r\nArchitecture](elastic/kibana-team#1179),
this\r\nPR fixes invalid dependencies from `security solution` code
towards\r\npackages that are categorised as `group: 'platform',
visibility:\r\n'private'`.\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"6e3bf7775e52515d5dfc653d25e769b0252c4d3d","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:
SecuritySolution","backport:prev-major"],"title":"[Sustainable Kibana
Architecture] Address `security` group dependencies'
issues","number":197480,"url":"https://github.com/elastic/kibana/pull/197480","mergeCommit":{"message":"[Sustainable
Kibana Architecture] Address `security` group dependencies' issues
(#197480)\n\n## Summary\r\n\r\nIn the scope of [Sustainable
Kibana\r\nArchitecture](elastic/kibana-team#1179),
this\r\nPR fixes invalid dependencies from `security solution` code
towards\r\npackages that are categorised as `group: 'platform',
visibility:\r\n'private'`.\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"6e3bf7775e52515d5dfc653d25e769b0252c4d3d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197480","number":197480,"mergeCommit":{"message":"[Sustainable
Kibana Architecture] Address `security` group dependencies' issues
(#197480)\n\n## Summary\r\n\r\nIn the scope of [Sustainable
Kibana\r\nArchitecture](elastic/kibana-team#1179),
this\r\nPR fixes invalid dependencies from `security solution` code
towards\r\npackages that are categorised as `group: 'platform',
visibility:\r\n'private'`.\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"6e3bf7775e52515d5dfc653d25e769b0252c4d3d"}}]}]
BACKPORT-->

Co-authored-by: Gerard Soldevila <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 25, 2024
@kibanamachine @gsoldevila
[8.16] [Sustainable Kibana Architecture] Address &#x60;security&#x60;…
ec2bae0 
… group dependencies&#x27; issues (#197480) (#197784)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Sustainable Kibana Architecture] Address &#x60;security&#x60; group
dependencies&#x27; issues
(#197480)](#197480)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-25T09:26:05Z","message":"[Sustainable
Kibana Architecture] Address `security` group dependencies' issues
(#197480)\n\n## Summary\r\n\r\nIn the scope of [Sustainable
Kibana\r\nArchitecture](elastic/kibana-team#1179),
this\r\nPR fixes invalid dependencies from `security solution` code
towards\r\npackages that are categorised as `group: 'platform',
visibility:\r\n'private'`.\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"6e3bf7775e52515d5dfc653d25e769b0252c4d3d","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:
SecuritySolution","backport:prev-major"],"title":"[Sustainable Kibana
Architecture] Address `security` group dependencies'
issues","number":197480,"url":"https://github.com/elastic/kibana/pull/197480","mergeCommit":{"message":"[Sustainable
Kibana Architecture] Address `security` group dependencies' issues
(#197480)\n\n## Summary\r\n\r\nIn the scope of [Sustainable
Kibana\r\nArchitecture](elastic/kibana-team#1179),
this\r\nPR fixes invalid dependencies from `security solution` code
towards\r\npackages that are categorised as `group: 'platform',
visibility:\r\n'private'`.\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"6e3bf7775e52515d5dfc653d25e769b0252c4d3d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197480","number":197480,"mergeCommit":{"message":"[Sustainable
Kibana Architecture] Address `security` group dependencies' issues
(#197480)\n\n## Summary\r\n\r\nIn the scope of [Sustainable
Kibana\r\nArchitecture](elastic/kibana-team#1179),
this\r\nPR fixes invalid dependencies from `security solution` code
towards\r\npackages that are categorised as `group: 'platform',
visibility:\r\n'private'`.\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"6e3bf7775e52515d5dfc653d25e769b0252c4d3d"}}]}]
BACKPORT-->

Co-authored-by: Gerard Soldevila <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 25, 2024
@kibanamachine @gsoldevila
[8.x] [Sustainable Kibana Architecture] Address &#x60;security&#x60; …
f81fdb9 
…group dependencies&#x27; issues (#197480) (#197785)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Sustainable Kibana Architecture] Address &#x60;security&#x60; group
dependencies&#x27; issues
(#197480)](#197480)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Gerard
Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-25T09:26:05Z","message":"[Sustainable
Kibana Architecture] Address `security` group dependencies' issues
(#197480)\n\n## Summary\r\n\r\nIn the scope of [Sustainable
Kibana\r\nArchitecture](elastic/kibana-team#1179),
this\r\nPR fixes invalid dependencies from `security solution` code
towards\r\npackages that are categorised as `group: 'platform',
visibility:\r\n'private'`.\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"6e3bf7775e52515d5dfc653d25e769b0252c4d3d","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:
SecuritySolution","backport:prev-major"],"title":"[Sustainable Kibana
Architecture] Address `security` group dependencies'
issues","number":197480,"url":"https://github.com/elastic/kibana/pull/197480","mergeCommit":{"message":"[Sustainable
Kibana Architecture] Address `security` group dependencies' issues
(#197480)\n\n## Summary\r\n\r\nIn the scope of [Sustainable
Kibana\r\nArchitecture](elastic/kibana-team#1179),
this\r\nPR fixes invalid dependencies from `security solution` code
towards\r\npackages that are categorised as `group: 'platform',
visibility:\r\n'private'`.\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"6e3bf7775e52515d5dfc653d25e769b0252c4d3d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197480","number":197480,"mergeCommit":{"message":"[Sustainable
Kibana Architecture] Address `security` group dependencies' issues
(#197480)\n\n## Summary\r\n\r\nIn the scope of [Sustainable
Kibana\r\nArchitecture](elastic/kibana-team#1179),
this\r\nPR fixes invalid dependencies from `security solution` code
towards\r\npackages that are categorised as `group: 'platform',
visibility:\r\n'private'`.\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"6e3bf7775e52515d5dfc653d25e769b0252c4d3d"}}]}]
BACKPORT-->

Co-authored-by: Gerard Soldevila <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

@angorayc angorayc angorayc approved these changes

@sebelga sebelga sebelga approved these changes

@rudolf rudolf rudolf approved these changes

@szaffarano szaffarano szaffarano approved these changes

Assignees
No one assigned
Labels
backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.15.4 v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@gsoldevila @elasticmachine @kibanamachine @szaffarano @rudolf @sebelga @angorayc @juliaElastic