[ES|QL] [Discover] Keeps the preferred chart configuration when possible

[stratoula]

Summary

Closes #184631

It keeps the chart configuration when the user is doing actions compatible with the current query such as:

• Adding a where filter (by clicking the table, the sidebar, the chart)
• Changes the breakdown field and the field type is compatible with the current chart
• Changing to a compatible chart type (from example from bar to line or pie to treemap)
• Changing the query that doesnt affect the generated columns mapped to a chart. For example adding a limit or creating a runtime field etc.

The logic depends on the suggestions. If the suggestions return the preferred chart type, then we are going to use this. So it really depends on the api and the type / number of columns. It is as smarter as it can in order to not create bugs. I am quite happy with the result. It is much better than what we have so far.

Next steps

I would love to do the same on the dahsboard too, needs more time though. But the changes made here will def work in favor

Checklist

• Unit or functional tests were updated or added to match the most common scenarios
• Flaky Test Runner was used on any tests changed

[stratoula]

I moved this here as it is used in many places already

[markov00]

Approving but please consider the comment I've left above

[mbondyra]

Seeing Marco's comment I actually think he might be right. Changing the code to the one below would make sure that if we add a new lens vis type, typescript will complain. WDYT?

Suggested change

	export const mapVisToChartType = (visualizationType: string) => {
	switch (visualizationType) {
	case LensVisualizationType.XY:
	return ChartType.XY;
	case LensVisualizationType.Metric:
	case LensVisualizationType.LegacyMetric:
	return ChartType.Metric;
	case LensVisualizationType.Pie:
	return ChartType.Pie;
	case LensVisualizationType.Heatmap:
	return ChartType.Heatmap;
	case LensVisualizationType.Gauge:
	return ChartType.Gauge;
	case LensVisualizationType.Datatable:
	return ChartType.Table;
	}
	};
	type ValueOf<T> = T[keyof T];
	type LensToChartMap = {
	[K in ValueOf<typeof LensVisualizationType>]: ChartType;
	};
	const lensTypesToChartTypes: LensToChartMap = {
	[LensVisualizationType.XY]: ChartType.XY,
	[LensVisualizationType.Metric]: ChartType.Metric,
	[LensVisualizationType.LegacyMetric]: ChartType.Metric,
	[LensVisualizationType.Pie]: ChartType.Pie,
	[LensVisualizationType.Heatmap]: ChartType.Heatmap,
	[LensVisualizationType.Gauge]: ChartType.Gauge,
	[LensVisualizationType.Datatable]: ChartType.Table,
	};
	function isLensVisualizationType(value: string): value is LensVisualizationType {
	return value in LensVisualizationType;
	}
	export const mapVisToChartType = (visualizationType: string) => {
	if (isLensVisualizationType(visualizationType)) {
	return lensTypesToChartTypes[visualizationType];
	}
	};

[stratoula]

Thanx MArta, done here 6daa2c8

[stratoula]

This creates a bug actually

[stratoula]

Fixed here cf707f8

[elasticmachine]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 4fad39b
• Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-197453-4fad39b1269a

Failed CI Steps

• Jest Integration Tests #5

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
aiops	584	587	+3
apm	1882	1885	+3
charts	126	129	+3
cloudSecurityPosture	659	662	+3
dashboard	675	678	+3
dataVisualizer	729	732	+3
discover	1015	1018	+3
esqlDataGrid	368	371	+3
eventAnnotationListing	583	586	+3
expressionHeatmap	179	182	+3
expressionMetricVis	112	115	+3
expressionPartitionVis	193	196	+3
expressionTagcloud	167	170	+3
expressionXY	254	257	+3
graph	300	303	+3
investigateApp	579	582	+3
lens	1468	1472	+4
logsExplorer	568	571	+3
logsShared	700	703	+3
ml	2013	2016	+3
observability	1067	1070	+3
observabilityAIAssistantApp	381	384	+3
securitySolution	6146	6149	+3
slo	853	856	+3
transform	504	507	+3
triggersActionsUi	850	853	+3
unifiedHistogram	190	193	+3
visDefaultEditor	203	206	+3
visTypeTimelion	63	66	+3
visTypeTimeseries	459	462	+3
total			+91

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
@kbn/visualization-utils	17	22	+5
lens	590	591	+1
total			+6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
lens	1.5MB	1.5MB	+860.0B
observabilityAIAssistantApp	239.1KB	239.2KB	+53.0B
unifiedHistogram	70.1KB	71.0KB	+975.0B
total			+1.8KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
lens	63	62	-1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
lens	50.8KB	50.8KB	+27.0B
unifiedHistogram	10.1KB	10.5KB	+413.0B
total			+440.0B

Unknown metric groups

API count

id	before	after	diff
@kbn/visualization-utils	19	24	+5
lens	692	693	+1
total			+6

History

• 💔 Build #248559 failed 16063d1
• 💚 Build #248448 succeeded 7ee61ab
• 💚 Build #248378 succeeded abbe859
• 💚 Build #248013 succeeded ea3e443
• 💔 Build #247938 failed 1e92f8d

[kibanamachine]

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11693873531

[kibanamachine]

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

[IanLee1521]

I came across this in the release notes for 8.17 and I've definitely been bitten by this before. Looking forward to trying this out!