Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Trained models: Accessibility tests #197446

Merged
merged 3 commits into from
Oct 24, 2024
Merged

[ML] Trained models: Accessibility tests #197446

merged 3 commits into from
Oct 24, 2024

Conversation

rbrtj
Copy link
Contributor

@rbrtj rbrtj commented Oct 23, 2024 •
edited by kibanamachine
Loading

Summary

Accessibility tests for Trained models page.

@rbrtj rbrtj added non-issue Indicates to automation that a pull request should not appear in the release notes :ml release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:ML Team label for ML (also use :ml) v8.16.0 backport:version Backport to applied version labels v8.17.0 labels Oct 23, 2024
@rbrtj rbrtj self-assigned this Oct 23, 2024
@rbrtj rbrtj requested a review from a team as a code owner October 23, 2024 13:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson mentioned this pull request Oct 24, 2024
Closed
23 tasks
peteharverson
peteharverson approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

walterra
walterra approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peteharverson peteharverson mentioned this pull request Oct 24, 2024
Open
26 tasks
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #17 / Policy Advanced Settings section should expand and collapse section when button is clicked
  • [job] [logs] FTR Configs #43 / Serverless Common UI - Management Index Management Indices can delete index

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.5MB 4.5MB -11.0B

History

cc @rbrtj

@rbrtj rbrtj merged commit f279b39 into elastic:main Oct 24, 2024
24 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11503423475

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 24, 2024
@rbrtj
[ML] Trained models: Accessibility tests (elastic#197446)
d1f4747 
## Summary

Accessibility tests for Trained models page.

(cherry picked from commit f279b39)
@kibanamachine kibanamachine mentioned this pull request Oct 24, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 24, 2024
@rbrtj
[ML] Trained models: Accessibility tests (elastic#197446)
aa89e8f 
## Summary

Accessibility tests for Trained models page.

(cherry picked from commit f279b39)
@kibanamachine kibanamachine mentioned this pull request Oct 24, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.16
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 24, 2024
@kibanamachine @rbrtj
[8.16] [ML] Trained models: Accessibility tests (#197446) (#197687)
b0af74f 
# Backport

This will backport the following commits from `main` to `8.16`:
- [[ML] Trained models: Accessibility tests
(#197446)](#197446)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T16:22:53Z","message":"[ML]
Trained models: Accessibility tests (#197446)\n\n##
Summary\r\n\r\nAccessibility tests for Trained models
page.","sha":"f279b39bde0136df1efb0b9cc4e97af68be69896","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["non-issue",":ml","release_note:skip","v9.0.0","Team:ML","v8.16.0","backport:version","v8.17.0"],"title":"[ML]
Trained models: Accessibility
tests","number":197446,"url":"https://github.com/elastic/kibana/pull/197446","mergeCommit":{"message":"[ML]
Trained models: Accessibility tests (#197446)\n\n##
Summary\r\n\r\nAccessibility tests for Trained models
page.","sha":"f279b39bde0136df1efb0b9cc4e97af68be69896"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197446","number":197446,"mergeCommit":{"message":"[ML]
Trained models: Accessibility tests (#197446)\n\n##
Summary\r\n\r\nAccessibility tests for Trained models
page.","sha":"f279b39bde0136df1efb0b9cc4e97af68be69896"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Jaszczurek <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 24, 2024
@kibanamachine @rbrtj
[8.x] [ML] Trained models: Accessibility tests (#197446) (#197688)
63c8df3 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Trained models: Accessibility tests
(#197446)](#197446)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-24T16:22:53Z","message":"[ML]
Trained models: Accessibility tests (#197446)\n\n##
Summary\r\n\r\nAccessibility tests for Trained models
page.","sha":"f279b39bde0136df1efb0b9cc4e97af68be69896","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["non-issue",":ml","release_note:skip","v9.0.0","Team:ML","v8.16.0","backport:version","v8.17.0"],"title":"[ML]
Trained models: Accessibility
tests","number":197446,"url":"https://github.com/elastic/kibana/pull/197446","mergeCommit":{"message":"[ML]
Trained models: Accessibility tests (#197446)\n\n##
Summary\r\n\r\nAccessibility tests for Trained models
page.","sha":"f279b39bde0136df1efb0b9cc4e97af68be69896"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197446","number":197446,"mergeCommit":{"message":"[ML]
Trained models: Accessibility tests (#197446)\n\n##
Summary\r\n\r\nAccessibility tests for Trained models
page.","sha":"f279b39bde0136df1efb0b9cc4e97af68be69896"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Jaszczurek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@walterra walterra walterra approved these changes

Assignees

@rbrtj rbrtj

Labels
backport:version Backport to applied version labels :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rbrtj @elasticmachine @kibanamachine @walterra @peteharverson