[Search] [Playground] Bug get text field for semantic field #197345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yansavitski
commented
Oct 22, 2024
•
yansavitski
commented
- Fix [Object object] in retrieval documents when semantic text is used
yansavitski
added
release_note:skip
joemcelroy
reviewed
Oct 23, 2024
| @@ -21,5 +21,7 @@ export const getValueForSelectedField = (hit: SearchHit, path: string): string = | |||
| .join('\n --- \n'); | |||
| } | |||
|
|
|||
| return get(hit._source, path, ''); | |||
| return has(hit._source, `${path}.text`) | |||
There was a problem hiding this comment.
can we have FTR tests that demonstrate this issue is fixed?
There was a problem hiding this comment.
I’ve added a unit test. Adding an FTR test would require significant changes in ftr, like creating an index with a semantic field and relevant data. Considering the simplicity of the case, maybe unit test would be enough?
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
|
joemcelroy
approved these changes
Oct 25, 2024
joemcelroy
added
backport:prev-minor
|
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11517708282 |
|
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11517708273 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 25, 2024
…197345) - Fix [Object object] in retrieval documents when semantic text is used <img width="825" alt="image" src="https://github.com/user-attachments/assets/39b154ac-727b-40c2-8262-4ff6f892a634"> (cherry picked from commit a224f9e)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 25, 2024
…197345) - Fix [Object object] in retrieval documents when semantic text is used <img width="825" alt="image" src="https://github.com/user-attachments/assets/39b154ac-727b-40c2-8262-4ff6f892a634"> (cherry picked from commit a224f9e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 25, 2024
…197345) (#197813) # Backport This will backport the following commits from `main` to `8.16`: - [[Search] [Playground] Bug get text field for semantic field (#197345)](#197345) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yan Savitski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-25T11:54:16Z","message":"[Search] [Playground] Bug get text field for semantic field (#197345)\n\n- Fix [Object object] in retrieval documents when semantic text is used\r\n<img width=\"825\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/39b154ac-727b-40c2-8262-4ff6f892a634\">","sha":"a224f9e14bcfc94db669c7e73dc97fc923326e36","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor","v8.16.0"],"title":"[Search] [Playground] Bug get text field for semantic field","number":197345,"url":"https://github.com/elastic/kibana/pull/197345","mergeCommit":{"message":"[Search] [Playground] Bug get text field for semantic field (#197345)\n\n- Fix [Object object] in retrieval documents when semantic text is used\r\n<img width=\"825\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/39b154ac-727b-40c2-8262-4ff6f892a634\">","sha":"a224f9e14bcfc94db669c7e73dc97fc923326e36"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197345","number":197345,"mergeCommit":{"message":"[Search] [Playground] Bug get text field for semantic field (#197345)\n\n- Fix [Object object] in retrieval documents when semantic text is used\r\n<img width=\"825\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/39b154ac-727b-40c2-8262-4ff6f892a634\">","sha":"a224f9e14bcfc94db669c7e73dc97fc923326e36"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Yan Savitski <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 25, 2024
…97345) (#197814) # Backport This will backport the following commits from `main` to `8.x`: - [[Search] [Playground] Bug get text field for semantic field (#197345)](#197345) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yan Savitski","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-25T11:54:16Z","message":"[Search] [Playground] Bug get text field for semantic field (#197345)\n\n- Fix [Object object] in retrieval documents when semantic text is used\r\n<img width=\"825\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/39b154ac-727b-40c2-8262-4ff6f892a634\">","sha":"a224f9e14bcfc94db669c7e73dc97fc923326e36","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor","v8.16.0"],"title":"[Search] [Playground] Bug get text field for semantic field","number":197345,"url":"https://github.com/elastic/kibana/pull/197345","mergeCommit":{"message":"[Search] [Playground] Bug get text field for semantic field (#197345)\n\n- Fix [Object object] in retrieval documents when semantic text is used\r\n<img width=\"825\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/39b154ac-727b-40c2-8262-4ff6f892a634\">","sha":"a224f9e14bcfc94db669c7e73dc97fc923326e36"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197345","number":197345,"mergeCommit":{"message":"[Search] [Playground] Bug get text field for semantic field (#197345)\n\n- Fix [Object object] in retrieval documents when semantic text is used\r\n<img width=\"825\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/39b154ac-727b-40c2-8262-4ff6f892a634\">","sha":"a224f9e14bcfc94db669c7e73dc97fc923326e36"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Yan Savitski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.