Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Update allocations tooltip to clarify that it's per node #197099

Merged
merged 4 commits into from
Oct 23, 2024
Merged

[ML] Update allocations tooltip to clarify that it's per node #197099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cb817cf
Update allocations tooltip to clarify that it's per node
leemthompo Oct 21, 2024
16855b1
Tweak
leemthompo Oct 22, 2024
8530fbd
Condition tooltip based on deployment type
leemthompo Oct 23, 2024
5f97e64
Update translations
leemthompo Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import type {
NodeDeploymentStatsResponse,
} from '../../../../common/types/trained_models';
import { useFieldFormatter } from '../../contexts/kibana/use_field_formatter';
import { useEnabledFeatures } from '../../contexts/ml';

interface AllocatedModelsProps {
models: NodeDeploymentStatsResponse['allocated_models'];
Expand All @@ -38,6 +39,7 @@ export const AllocatedModels: FC<AllocatedModelsProps> = ({
const dateFormatter = useFieldFormatter(FIELD_FORMAT_IDS.DATE);
const durationFormatter = useFieldFormatter(FIELD_FORMAT_IDS.DURATION);
const euiTheme = useEuiTheme();
const { showNodeInfo } = useEnabledFeatures();

const columns: Array<EuiBasicTableColumn<AllocatedModel>> = [
{
Expand Down Expand Up @@ -105,9 +107,20 @@ export const AllocatedModels: FC<AllocatedModelsProps> = ({
width: '8%',
name: (
<EuiToolTip
content={i18n.translate('xpack.ml.trainedModels.nodesList.modelsList.allocationTooltip', {
defaultMessage: 'number_of_allocations times threads_per_allocation',
})}
content={
showNodeInfo
? i18n.translate(
'xpack.ml.trainedModels.nodesList.modelsList.allocationTooltipNodes',
{
defaultMessage:
'Number of allocations per node multiplied by number of threads per allocation',
}
)
: i18n.translate('xpack.ml.trainedModels.nodesList.modelsList.allocationTooltip', {
defaultMessage:
'Number of allocations multiplied by number of threads per allocation',
})
}
>
<span>
{i18n.translate('xpack.ml.trainedModels.nodesList.modelsList.allocationHeader', {
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/translations/translations/fr-FR.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47476,4 +47476,4 @@
"xpack.watcher.watchEdit.thresholdWatchExpression.aggType.fieldIsRequiredValidationMessage": "Ce champ est requis.",
"xpack.watcher.watcherDescription": "Détectez les modifications survenant dans vos données en créant, gérant et monitorant des alertes."
}
}
}
2 changes: 1 addition & 1 deletion x-pack/plugins/translations/translations/ja-JP.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47214,4 +47214,4 @@
"xpack.watcher.watchEdit.thresholdWatchExpression.aggType.fieldIsRequiredValidationMessage": "フィールドを選択してください。",
"xpack.watcher.watcherDescription": "アラートの作成、管理、監視によりデータへの変更を検知します。"
}
}
}
2 changes: 1 addition & 1 deletion x-pack/plugins/translations/translations/zh-CN.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47267,4 +47267,4 @@
"xpack.watcher.watchEdit.thresholdWatchExpression.aggType.fieldIsRequiredValidationMessage": "此字段必填。",
"xpack.watcher.watcherDescription": "通过创建、管理和监测警报来检测数据中的更改。"
}
}
}