-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.16] [FTR] enable roles management testing for Observability project (#196514) #196862
Merged
kibanamachine
merged 1 commit into
elastic:8.16
from
kibanamachine:backport/8.16/pr-196514
Oct 18, 2024
Merged
[8.16] [FTR] enable roles management testing for Observability project (#196514) #196862
kibanamachine
merged 1 commit into
elastic:8.16
from
kibanamachine:backport/8.16/pr-196514
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tic#196514) ## Summary This PR makes changes in FTR `saml_auth` service to allow creating custom role for Oblt serverless project, when roles management is explicitly enabled with `--xpack.security.roleManagementEnabled=true` in Kibana server arguments. I also added [role_management/custom_role_access.ts ](x-pack/test_serverless/functional/test_suites/observability/role_management/custom_role_access.ts) as a test example. Currently roles management is enabled in `x-pack/test_serverless/functional/test_suites/observability/config.feature_flags.ts` and after this PR is merged, more tests with custom roles can be added for Oblt project. How to run tests: ``` node scripts/functional_tests --config x-pack/test_serverless/functional/test_suites/observability/config.feature_flags.ts ``` (cherry picked from commit 16c965f)
💚 Build Succeeded
Metrics [docs]
cc @dmlemeshko |
kibanamachine
added a commit
that referenced
this pull request
Oct 25, 2024
…#196514) (#197845) # Backport This will backport the following commits from `main` to `8.x`: - [[FTR] enable roles management testing for Observability project (#196514)](#196514) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T12:17:13Z","message":"[FTR] enable roles management testing for Observability project (#196514)\n\n## Summary\r\n\r\nThis PR makes changes in FTR `saml_auth` service to allow creating\r\ncustom role for Oblt serverless project, when roles management is\r\nexplicitly enabled with `--xpack.security.roleManagementEnabled=true` in\r\nKibana server arguments.\r\n\r\nI also added [role_management/custom_role_access.ts\r\n](x-pack/test_serverless/functional/test_suites/observability/role_management/custom_role_access.ts)\r\nas a test example. Currently roles management is enabled in\r\n`x-pack/test_serverless/functional/test_suites/observability/config.feature_flags.ts`\r\nand after this PR is merged, more tests with custom roles can be added\r\nfor Oblt project.\r\n\r\nHow to run tests:\r\n\r\n```\r\nnode scripts/functional_tests --config x-pack/test_serverless/functional/test_suites/observability/config.feature_flags.ts\r\n```","sha":"16c965f853f17565e2da996b1f2ab21e9e33a003","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","v8.16.0","backport:version","v8.17.0"],"title":"[FTR] enable roles management testing for Observability project","number":196514,"url":"https://github.com/elastic/kibana/pull/196514","mergeCommit":{"message":"[FTR] enable roles management testing for Observability project (#196514)\n\n## Summary\r\n\r\nThis PR makes changes in FTR `saml_auth` service to allow creating\r\ncustom role for Oblt serverless project, when roles management is\r\nexplicitly enabled with `--xpack.security.roleManagementEnabled=true` in\r\nKibana server arguments.\r\n\r\nI also added [role_management/custom_role_access.ts\r\n](x-pack/test_serverless/functional/test_suites/observability/role_management/custom_role_access.ts)\r\nas a test example. Currently roles management is enabled in\r\n`x-pack/test_serverless/functional/test_suites/observability/config.feature_flags.ts`\r\nand after this PR is merged, more tests with custom roles can be added\r\nfor Oblt project.\r\n\r\nHow to run tests:\r\n\r\n```\r\nnode scripts/functional_tests --config x-pack/test_serverless/functional/test_suites/observability/config.feature_flags.ts\r\n```","sha":"16c965f853f17565e2da996b1f2ab21e9e33a003"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196514","number":196514,"mergeCommit":{"message":"[FTR] enable roles management testing for Observability project (#196514)\n\n## Summary\r\n\r\nThis PR makes changes in FTR `saml_auth` service to allow creating\r\ncustom role for Oblt serverless project, when roles management is\r\nexplicitly enabled with `--xpack.security.roleManagementEnabled=true` in\r\nKibana server arguments.\r\n\r\nI also added [role_management/custom_role_access.ts\r\n](x-pack/test_serverless/functional/test_suites/observability/role_management/custom_role_access.ts)\r\nas a test example. Currently roles management is enabled in\r\n`x-pack/test_serverless/functional/test_suites/observability/config.feature_flags.ts`\r\nand after this PR is merged, more tests with custom roles can be added\r\nfor Oblt project.\r\n\r\nHow to run tests:\r\n\r\n```\r\nnode scripts/functional_tests --config x-pack/test_serverless/functional/test_suites/observability/config.feature_flags.ts\r\n```","sha":"16c965f853f17565e2da996b1f2ab21e9e33a003"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/196862","number":196862,"state":"MERGED","mergeCommit":{"sha":"e42cc1f8a4246b4aa34191429b272174ed9f852b","message":"[8.16] [FTR] enable roles management testing for Observability project (#196514) (#196862)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.16`:\n- [[FTR] enable roles management testing for Observability project\n(#196514)](https://github.com/elastic/kibana/pull/196514)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Dzmitry\nLemechko\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-18T12:17:13Z\",\"message\":\"[FTR]\nenable roles management testing for Observability project\n(#196514)\\n\\n## Summary\\r\\n\\r\\nThis PR makes changes in FTR `saml_auth`\nservice to allow creating\\r\\ncustom role for Oblt serverless project,\nwhen roles management is\\r\\nexplicitly enabled with\n`--xpack.security.roleManagementEnabled=true` in\\r\\nKibana server\narguments.\\r\\n\\r\\nI also added\n[role_management/custom_role_access.ts\\r\\n](x-pack/test_serverless/functional/test_suites/observability/role_management/custom_role_access.ts)\\r\\nas\na test example. Currently roles management is enabled\nin\\r\\n`x-pack/test_serverless/functional/test_suites/observability/config.feature_flags.ts`\\r\\nand\nafter this PR is merged, more tests with custom roles can be\nadded\\r\\nfor Oblt project.\\r\\n\\r\\nHow to run tests:\\r\\n\\r\\n```\\r\\nnode\nscripts/functional_tests --config\nx-pack/test_serverless/functional/test_suites/observability/config.feature_flags.ts\\r\\n```\",\"sha\":\"16c965f853f17565e2da996b1f2ab21e9e33a003\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"v8.16.0\",\"backport:version\"],\"title\":\"[FTR]\nenable roles management testing for Observability\nproject\",\"number\":196514,\"url\":\"https://github.com/elastic/kibana/pull/196514\",\"mergeCommit\":{\"message\":\"[FTR]\nenable roles management testing for Observability project\n(#196514)\\n\\n## Summary\\r\\n\\r\\nThis PR makes changes in FTR `saml_auth`\nservice to allow creating\\r\\ncustom role for Oblt serverless project,\nwhen roles management is\\r\\nexplicitly enabled with\n`--xpack.security.roleManagementEnabled=true` in\\r\\nKibana server\narguments.\\r\\n\\r\\nI also added\n[role_management/custom_role_access.ts\\r\\n](x-pack/test_serverless/functional/test_suites/observability/role_management/custom_role_access.ts)\\r\\nas\na test example. Currently roles management is enabled\nin\\r\\n`x-pack/test_serverless/functional/test_suites/observability/config.feature_flags.ts`\\r\\nand\nafter this PR is merged, more tests with custom roles can be\nadded\\r\\nfor Oblt project.\\r\\n\\r\\nHow to run tests:\\r\\n\\r\\n```\\r\\nnode\nscripts/functional_tests --config\nx-pack/test_serverless/functional/test_suites/observability/config.feature_flags.ts\\r\\n```\",\"sha\":\"16c965f853f17565e2da996b1f2ab21e9e33a003\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.16\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/196514\",\"number\":196514,\"mergeCommit\":{\"message\":\"[FTR]\nenable roles management testing for Observability project\n(#196514)\\n\\n## Summary\\r\\n\\r\\nThis PR makes changes in FTR `saml_auth`\nservice to allow creating\\r\\ncustom role for Oblt serverless project,\nwhen roles management is\\r\\nexplicitly enabled with\n`--xpack.security.roleManagementEnabled=true` in\\r\\nKibana server\narguments.\\r\\n\\r\\nI also added\n[role_management/custom_role_access.ts\\r\\n](x-pack/test_serverless/functional/test_suites/observability/role_management/custom_role_access.ts)\\r\\nas\na test example. Currently roles management is enabled\nin\\r\\n`x-pack/test_serverless/functional/test_suites/observability/config.feature_flags.ts`\\r\\nand\nafter this PR is merged, more tests with custom roles can be\nadded\\r\\nfor Oblt project.\\r\\n\\r\\nHow to run tests:\\r\\n\\r\\n```\\r\\nnode\nscripts/functional_tests --config\nx-pack/test_serverless/functional/test_suites/observability/config.feature_flags.ts\\r\\n```\",\"sha\":\"16c965f853f17565e2da996b1f2ab21e9e33a003\"}},{\"branch\":\"8.16\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Dzmitry Lemechko <[email protected]>"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dzmitry Lemechko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
main
to8.16
:Questions ?
Please refer to the Backport tool documentation