[Lens] fix flaky long running test #196725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
added
Team:Visualizations
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
|
|
Starting backport for target branches: 8.15, 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11399593578 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 18, 2024
## Summary Fixes elastic#192476 Due the the fact type function is quite slow but irreplaceable here + the DOM tree we're rendering here is very big, I think the best option is to up the timeout limit. On average this test is around 1s long though. (We're setting the limit to 10s) (cherry picked from commit ce41bf1)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 18, 2024
## Summary Fixes elastic#192476 Due the the fact type function is quite slow but irreplaceable here + the DOM tree we're rendering here is very big, I think the best option is to up the timeout limit. On average this test is around 1s long though. (We're setting the limit to 10s) (cherry picked from commit ce41bf1)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 18, 2024
# Backport This will backport the following commits from `main` to `8.16`: - [[Lens] fix flaky long running test (#196725)](#196725) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marta Bondyra","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T07:42:11Z","message":"[Lens] fix flaky long running test (#196725)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/192476\r\nDue the the fact type function is quite slow but irreplaceable here +\r\nthe DOM tree we're rendering here is very big, I think the best option\r\nis to up the timeout limit. On average this test is around 1s long\r\nthough. (We're setting the limit to 10s)","sha":"ce41bf1fafca416826f1864c3bf8dc0ffb02afc5","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","v9.0.0","backport:prev-major"],"title":"[Lens] fix flaky long running test","number":196725,"url":"https://github.com/elastic/kibana/pull/196725","mergeCommit":{"message":"[Lens] fix flaky long running test (#196725)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/192476\r\nDue the the fact type function is quite slow but irreplaceable here +\r\nthe DOM tree we're rendering here is very big, I think the best option\r\nis to up the timeout limit. On average this test is around 1s long\r\nthough. (We're setting the limit to 10s)","sha":"ce41bf1fafca416826f1864c3bf8dc0ffb02afc5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196725","number":196725,"mergeCommit":{"message":"[Lens] fix flaky long running test (#196725)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/192476\r\nDue the the fact type function is quite slow but irreplaceable here +\r\nthe DOM tree we're rendering here is very big, I think the best option\r\nis to up the timeout limit. On average this test is around 1s long\r\nthough. (We're setting the limit to 10s)","sha":"ce41bf1fafca416826f1864c3bf8dc0ffb02afc5"}}]}] BACKPORT--> Co-authored-by: Marta Bondyra <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Oct 18, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Lens] fix flaky long running test (#196725)](#196725) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marta Bondyra","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-18T07:42:11Z","message":"[Lens] fix flaky long running test (#196725)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/192476\r\nDue the the fact type function is quite slow but irreplaceable here +\r\nthe DOM tree we're rendering here is very big, I think the best option\r\nis to up the timeout limit. On average this test is around 1s long\r\nthough. (We're setting the limit to 10s)","sha":"ce41bf1fafca416826f1864c3bf8dc0ffb02afc5","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","v9.0.0","backport:prev-major"],"title":"[Lens] fix flaky long running test","number":196725,"url":"https://github.com/elastic/kibana/pull/196725","mergeCommit":{"message":"[Lens] fix flaky long running test (#196725)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/192476\r\nDue the the fact type function is quite slow but irreplaceable here +\r\nthe DOM tree we're rendering here is very big, I think the best option\r\nis to up the timeout limit. On average this test is around 1s long\r\nthough. (We're setting the limit to 10s)","sha":"ce41bf1fafca416826f1864c3bf8dc0ffb02afc5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196725","number":196725,"mergeCommit":{"message":"[Lens] fix flaky long running test (#196725)\n\n## Summary\r\n\r\nFixes https://github.com/elastic/kibana/issues/192476\r\nDue the the fact type function is quite slow but irreplaceable here +\r\nthe DOM tree we're rendering here is very big, I think the best option\r\nis to up the timeout limit. On average this test is around 1s long\r\nthough. (We're setting the limit to 10s)","sha":"ce41bf1fafca416826f1864c3bf8dc0ffb02afc5"}}]}] BACKPORT--> Co-authored-by: Marta Bondyra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #192476
Due the the fact type function is quite slow but irreplaceable here + the DOM tree we're rendering here is very big, I think the best option is to up the timeout limit. On average this test is around 1s long though. (We're setting the limit to 10s)