Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM][Otel] Fix an error with mobile services coming from synthtrace #196313

Merged
merged 2 commits into from
Oct 15, 2024
Merged

[APM][Otel] Fix an error with mobile services coming from synthtrace #196313

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
951c304
Remove transaction.type from span to avoind changing the event
jennypavlova Oct 15, 2024
5b1e0bd
Merge branch 'main' into 196161-apmotel-fix-an-error-with-mobile-serv…
jennypavlova Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/kbn-apm-synthtrace-client/src/lib/apm/mobile_device.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ export class MobileDevice extends Entity<ApmFields> {
spanSubtype: 'http',
'http.request.method': httpMethod,
'url.original': httpUrl,
'transaction.type': 'mobile',
'processor.event': 'span',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was it mobile?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was set because of the parent transaction - it is set there but inside the span function we are not setting the transaction.type so that's why some spans were visible and the httpSpans were throwing an error. I don't see any test checking it and it's not part of any span-specific fields so I guess it was something we had copied from the transaction 🤔

};

if (this.networkConnection) {
Expand Down