[Lens] escape backslash characters in the formula input #196171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
added
Team:Visualizations
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
mbondyra
added
the
release_note:skip
nickofthyme
approved these changes
Oct 14, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11341573679 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 15, 2024
## Summary Ensures that backslashes are properly escaped in addition to single quotes in formula (cherry picked from commit e0251df)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 15, 2024
… (#196237) # Backport This will backport the following commits from `main` to `8.x`: - [[Lens] escape backslash characters in the formula input (#196171)](#196171) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marta Bondyra","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-15T07:46:56Z","message":"[Lens] escape backslash characters in the formula input (#196171)\n\n## Summary\r\n\r\nEnsures that backslashes are properly escaped in addition to single\r\nquotes in formula","sha":"e0251df6bd944fc53c58b9ee73c0b5d2eb892197","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","v9.0.0","backport:prev-minor"],"title":"[Lens] escape backslash characters in the formula input","number":196171,"url":"https://github.com/elastic/kibana/pull/196171","mergeCommit":{"message":"[Lens] escape backslash characters in the formula input (#196171)\n\n## Summary\r\n\r\nEnsures that backslashes are properly escaped in addition to single\r\nquotes in formula","sha":"e0251df6bd944fc53c58b9ee73c0b5d2eb892197"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196171","number":196171,"mergeCommit":{"message":"[Lens] escape backslash characters in the formula input (#196171)\n\n## Summary\r\n\r\nEnsures that backslashes are properly escaped in addition to single\r\nquotes in formula","sha":"e0251df6bd944fc53c58b9ee73c0b5d2eb892197"}}]}] BACKPORT--> Co-authored-by: Marta Bondyra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensures that backslashes are properly escaped in addition to single quotes in formula