Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Onboarding] Remove System Logs onboarding flow #196132

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ import { SerializableRecord } from '@kbn/utility-types';
export const OBSERVABILITY_ONBOARDING_LOCATOR = 'OBSERVABILITY_ONBOARDING_LOCATOR' as const;

export interface ObservabilityOnboardingLocatorParams extends SerializableRecord {
/** If given, it will load the given map else will load the create a new map page. */
source?: 'customLogs' | 'systemLogs';
/** If given, it will load the given onboarding flow
* else will load the main onboarding screen.
*/
source?: 'auto-detect' | 'customLogs' | 'kubernetes' | 'otel-logs' | 'firehose';
category?: string;
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,3 @@
*/

export * from './custom_logs/generate_custom_logs_yml';
export * from './system_logs/generate_system_logs_yml';

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@ describe.skip('[Logs onboarding] Give Feedback', () => {
cy.visitKibana('/app/observabilityOnboarding');
});

it('feedback button is present in system logs onboarding', () => {
cy.getByTestSubj('obltOnboardingHomeStartSystemLogStream').click();
cy.getByTestSubj('observabilityOnboardingPageGiveFeedback').should('exist');
});

it('feedback button is present in custom logs onboarding', () => {
cy.getByTestSubj('obltOnboardingHomeStartLogFileStream').click();
cy.getByTestSubj('observabilityOnboardingPageGiveFeedback').should('exist');
Expand Down
Loading