-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES|QL] Update grammars #196046
[ES|QL] Update grammars #196046
Conversation
Pinging @elastic/kibana-esql (Team:ESQL) |
/ci |
Needs to merge this first #195847 |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Page load bundle
History
|
@elastic/security-detection-engine can you please review? It is a tiny change for you and I would love to merge before the FF 🙏 |
As the review from the security team is just a unit test update I am going to mege this PR as I want this merged before the FF |
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11347453951 |
This PR updates the ES|QL grammars (lexer and parser) to match the latest version in Elasticsearch. --------- Co-authored-by: Stratoula Kalafateli <[email protected]> (cherry picked from commit bed5c4e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] Update grammars (#196046)](#196046) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kibana Machine","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-15T13:47:08Z","message":"[ES|QL] Update grammars (#196046)\n\nThis PR updates the ES|QL grammars (lexer and parser) to match the\r\nlatest version in Elasticsearch.\r\n\r\n---------\r\n\r\nCo-authored-by: Stratoula Kalafateli <[email protected]>","sha":"bed5c4e9fe0cf5acc2e5b3326ca306134bc18891","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL","v8.16.0"],"title":"[ES|QL] Update grammars","number":196046,"url":"https://github.com/elastic/kibana/pull/196046","mergeCommit":{"message":"[ES|QL] Update grammars (#196046)\n\nThis PR updates the ES|QL grammars (lexer and parser) to match the\r\nlatest version in Elasticsearch.\r\n\r\n---------\r\n\r\nCo-authored-by: Stratoula Kalafateli <[email protected]>","sha":"bed5c4e9fe0cf5acc2e5b3326ca306134bc18891"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196046","number":196046,"mergeCommit":{"message":"[ES|QL] Update grammars (#196046)\n\nThis PR updates the ES|QL grammars (lexer and parser) to match the\r\nlatest version in Elasticsearch.\r\n\r\n---------\r\n\r\nCo-authored-by: Stratoula Kalafateli <[email protected]>","sha":"bed5c4e9fe0cf5acc2e5b3326ca306134bc18891"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security Solution change (which is a single test asserting an ES|QL validation error) looks good to me!
This PR updates the ES|QL grammars (lexer and parser) to match the latest version in Elasticsearch.