[Security Solution][Serverless] Logging - Fix explore test issue #195941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkirchan
added
release_note:skip
dkirchan
requested review from
a team,
MadameSheema,
patrykkopycinski,
maximpn and
banderror
as code owners
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
semd
approved these changes
Oct 11, 2024
|
/ci |
maximpn
approved these changes
Oct 14, 2024
| await cloudHandler.deleteSecurityProject(project.id, PROJECT_NAME); | ||
| } catch (error) { | ||
| // False positive | ||
| // eslint-disable-next-line require-atomic-updates | ||
| result = error; | ||
| failedSpecFilePaths.push(filePath); | ||
| log.error(`Something went wrong with the cypress execution: ${error}`); |
There was a problem hiding this comment.
nit: Could we make error message clearer? Something like Cypress runner failed: ${error} looks better.
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History
cc @dkirchan |
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses two points:
Copy valuetest was moved to the top of the spec file. This allows the proper execution of all the tests. Pending further investigation. Me and @MadameSheema tested this locally and it always passes without any issues.Also I tried to increase the resources of the agent assigned in Buildkite to run the tests but this still does not seem to be resolving the issue.