[Synthetics] Handle private locations simultaneous edits !! #195874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
added
release_note:fix
backport:prev-minor
pheyos
approved these changes
Nov 5, 2024
dominiqueclarke
requested review from
dominiqueclarke
and removed request for
dominiqueclarke
jbudz
approved these changes
Nov 5, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11731651488 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 7, 2024
…195874) ## Summary Fixes elastic#190801 !! Handle private locations simultaneous edits !! Registered a new saved object to handle private locations properly. Instead of using a singleton, now each private location will be represented by it's own saved object. ### Existing private locations When we are doing any write operation, we migrate them to new kind of saved object and remove the legacy saved object type. ### Testing - Create multiple private locations on main - Switch to branch and create few more locations - Make sure all private locations are editable, deleteable and have been migrated to new saved object types in the course --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 96c9b5b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 7, 2024
…95874) (#199387) # Backport This will backport the following commits from `main` to `8.x`: - [[Synthetics] Handle private locations simultaneous edits !! (#195874)](#195874) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-07T21:31:09Z","message":"[Synthetics] Handle private locations simultaneous edits !! (#195874)\n\n## Summary\r\n\r\nFixes #190801 !!\r\n\r\nHandle private locations simultaneous edits !! \r\n\r\nRegistered a new saved object to handle private locations properly.\r\nInstead of using a singleton, now each private location will be\r\nrepresented by it's own saved object.\r\n\r\n### Existing private locations\r\nWhen we are doing any write operation, we migrate them to new kind of\r\nsaved object and remove the legacy saved object type.\r\n\r\n\r\n### Testing\r\n\r\n- Create multiple private locations on main \r\n- Switch to branch and create few more locations\r\n- Make sure all private locations are editable, deleteable and have been\r\nmigrated to new saved object types in the course\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"96c9b5b5d0a82c6e4b0a9b86fc1ab4dd9fa4d707","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics] Handle private locations simultaneous edits !!","number":195874,"url":"https://github.com/elastic/kibana/pull/195874","mergeCommit":{"message":"[Synthetics] Handle private locations simultaneous edits !! (#195874)\n\n## Summary\r\n\r\nFixes #190801 !!\r\n\r\nHandle private locations simultaneous edits !! \r\n\r\nRegistered a new saved object to handle private locations properly.\r\nInstead of using a singleton, now each private location will be\r\nrepresented by it's own saved object.\r\n\r\n### Existing private locations\r\nWhen we are doing any write operation, we migrate them to new kind of\r\nsaved object and remove the legacy saved object type.\r\n\r\n\r\n### Testing\r\n\r\n- Create multiple private locations on main \r\n- Switch to branch and create few more locations\r\n- Make sure all private locations are editable, deleteable and have been\r\nmigrated to new saved object types in the course\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"96c9b5b5d0a82c6e4b0a9b86fc1ab4dd9fa4d707"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195874","number":195874,"mergeCommit":{"message":"[Synthetics] Handle private locations simultaneous edits !! (#195874)\n\n## Summary\r\n\r\nFixes #190801 !!\r\n\r\nHandle private locations simultaneous edits !! \r\n\r\nRegistered a new saved object to handle private locations properly.\r\nInstead of using a singleton, now each private location will be\r\nrepresented by it's own saved object.\r\n\r\n### Existing private locations\r\nWhen we are doing any write operation, we migrate them to new kind of\r\nsaved object and remove the legacy saved object type.\r\n\r\n\r\n### Testing\r\n\r\n- Create multiple private locations on main \r\n- Switch to branch and create few more locations\r\n- Make sure all private locations are editable, deleteable and have been\r\nmigrated to new saved object types in the course\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"96c9b5b5d0a82c6e4b0a9b86fc1ab4dd9fa4d707"}}]}] BACKPORT--> Co-authored-by: Shahzad <[email protected]>
|
Thanks a lot! |
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
Nov 8, 2024
…195874) ## Summary Fixes elastic#190801 !! Handle private locations simultaneous edits !! Registered a new saved object to handle private locations properly. Instead of using a singleton, now each private location will be represented by it's own saved object. ### Existing private locations When we are doing any write operation, we migrate them to new kind of saved object and remove the legacy saved object type. ### Testing - Create multiple private locations on main - Switch to branch and create few more locations - Make sure all private locations are editable, deleteable and have been migrated to new saved object types in the course --------- Co-authored-by: kibanamachine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 8, 2024
…195874) ## Summary Fixes elastic#190801 !! Handle private locations simultaneous edits !! Registered a new saved object to handle private locations properly. Instead of using a singleton, now each private location will be represented by it's own saved object. ### Existing private locations When we are doing any write operation, we migrate them to new kind of saved object and remove the legacy saved object type. ### Testing - Create multiple private locations on main - Switch to branch and create few more locations - Make sure all private locations are editable, deleteable and have been migrated to new saved object types in the course --------- Co-authored-by: kibanamachine <[email protected]>
shahzad31
added a commit
that referenced
this pull request
Nov 21, 2024
## Summary This is a regression from the PR #195874, where we added the new type into all but didn't do it for read.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 21, 2024
…201170) ## Summary This is a regression from the PR elastic#195874, where we added the new type into all but didn't do it for read. (cherry picked from commit 5d4282e)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 21, 2024
…201170) ## Summary This is a regression from the PR elastic#195874, where we added the new type into all but didn't do it for read. (cherry picked from commit 5d4282e)
kibanamachine
added a commit
that referenced
this pull request
Nov 21, 2024
…201170) (#201258) # Backport This will backport the following commits from `main` to `8.17`: - [[Synthetics] Add new object into read synthetics feature !! (#201170)](#201170) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T17:40:09Z","message":"[Synthetics] Add new object into read synthetics feature !! (#201170)\n\n## Summary\n\nThis is a regression from the PR\nhttps://github.com//pull/195874, where we added the new\ntype into all but didn't do it for read.","sha":"5d4282e91621b433e2bdf7201f9bedf47661d152","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v8.17.0","v8.18.0"],"title":"[Synthetics] Add new object into read synthetics feature !!","number":201170,"url":"https://github.com/elastic/kibana/pull/201170","mergeCommit":{"message":"[Synthetics] Add new object into read synthetics feature !! (#201170)\n\n## Summary\n\nThis is a regression from the PR\nhttps://github.com//pull/195874, where we added the new\ntype into all but didn't do it for read.","sha":"5d4282e91621b433e2bdf7201f9bedf47661d152"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201170","number":201170,"mergeCommit":{"message":"[Synthetics] Add new object into read synthetics feature !! (#201170)\n\n## Summary\n\nThis is a regression from the PR\nhttps://github.com//pull/195874, where we added the new\ntype into all but didn't do it for read.","sha":"5d4282e91621b433e2bdf7201f9bedf47661d152"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Shahzad <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 21, 2024
…01170) (#201259) # Backport This will backport the following commits from `main` to `8.x`: - [[Synthetics] Add new object into read synthetics feature !! (#201170)](#201170) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T17:40:09Z","message":"[Synthetics] Add new object into read synthetics feature !! (#201170)\n\n## Summary\n\nThis is a regression from the PR\nhttps://github.com//pull/195874, where we added the new\ntype into all but didn't do it for read.","sha":"5d4282e91621b433e2bdf7201f9bedf47661d152","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v8.17.0","v8.18.0"],"title":"[Synthetics] Add new object into read synthetics feature !!","number":201170,"url":"https://github.com/elastic/kibana/pull/201170","mergeCommit":{"message":"[Synthetics] Add new object into read synthetics feature !! (#201170)\n\n## Summary\n\nThis is a regression from the PR\nhttps://github.com//pull/195874, where we added the new\ntype into all but didn't do it for read.","sha":"5d4282e91621b433e2bdf7201f9bedf47661d152"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201170","number":201170,"mergeCommit":{"message":"[Synthetics] Add new object into read synthetics feature !! (#201170)\n\n## Summary\n\nThis is a regression from the PR\nhttps://github.com//pull/195874, where we added the new\ntype into all but didn't do it for read.","sha":"5d4282e91621b433e2bdf7201f9bedf47661d152"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Shahzad <[email protected]>
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Nov 26, 2024
…201170) ## Summary This is a regression from the PR elastic#195874, where we added the new type into all but didn't do it for read.
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…201170) ## Summary This is a regression from the PR elastic#195874, where we added the new type into all but didn't do it for read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #190801 !!
Handle private locations simultaneous edits !!
Registered a new saved object to handle private locations properly. Instead of using a singleton, now each private location will be represented by it's own saved object.
Existing private locations
When we are doing any write operation, we migrate them to new kind of saved object and remove the legacy saved object type.
Testing