[ResponseOps][Rules] Fix case action templates in stack for security serverless #195763

adcoelho · 2024-10-10T13:02:36Z

Fixes #195599

Summary

This PR ensures that we can use templates in the case action when:

the project is serverless security, and
the rule is created in stack management

How to test

Add the following line to serverless.yml - xpack.cloud.serverless.project_id: test-123
Start Elastic search in serverless security mode - yarn es serverless --projectType security
Start Kibana in serverless security mode - yarn start --serverless=security
Go to Security > Cases > Settings and add a template.
Go to stack and create a rule with the case action.
Confirm the template created in step 5 can be selected.

Please double-check also that the templates in the case action still work as expected in normal scenarios.

elasticmachine · 2024-10-10T13:02:39Z

Pinging @elastic/response-ops (Team:ResponseOps)

elasticmachine · 2024-10-10T13:02:39Z

Pinging @elastic/response-ops-cases (Feature:Cases)

…fix'

js-jankisalvi

Verified locally, works as expected 👍

Security > Cases > template visible in security and stack management rules in serverless security project.

Observability > Cases > templates visible in observability rules in serverless observability project

cnasikas · 2024-10-11T07:43:21Z

x-pack/plugins/triggers_actions_ui/public/plugin.ts

@@ -167,7 +168,7 @@ export interface TriggersAndActionsUIPublicPluginStart {
 interface PluginsSetup {
  management: ManagementSetup;
  home?: HomePublicPluginSetup;
-  cloud?: { isCloudEnabled: boolean };
+  cloud: CloudSetup;


I think the type should be optional, correct?

You're right, thank you!

cnasikas · 2024-10-11T07:46:16Z

x-pack/plugins/cases/public/components/system_actions/cases/cases_params.tsx

@@ -39,11 +39,20 @@ export const CasesParamsFieldsComponent: React.FunctionComponent<
  ActionParamsProps<CasesActionParams>
 > = ({ actionParams, editAction, errors, index, producerId, featureId }) => {
  const {
+    cloud,


Just a reminder that the cases_params component is rendered through various applications that provide the KibanaContextProvider. Even if the triggers actions UI provides cloud maybe other solutions will not. If it is working in Security then they definitely provide it 🙂.

But this portion of cases' code is only used by triggers_actions_ui so it's safe to assume that cloud will be provided no? I added cloud to triggers actions UI because they define Kibana context for connectors.

If it is working in Security then they definitely provide it 🙂.

The important part is that it works in Stack Management so that is independent of security right? (even if the project is security serverless)

This portion of code is being used everywhere the alerts flyout is being used. Also, the actions component is being exported and used by the Security solution in their rules form:

Nevertheless, even if the cloud plugin is not available because you can only create security rules there the owner will always be correct + @js-jankisalvi tested it 🙂 . The issue is on Stack so it should be fine.

adcoelho · 2024-10-11T10:31:10Z

/ci

elasticmachine · 2024-10-14T10:45:57Z

💚 Build Succeeded

Buildkite Build
Commit: 5d73274

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`triggersActionsUi`	566	567	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cases`	491.8KB	491.9KB	+126.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`triggersActionsUi`	123.3KB	123.3KB	+14.0B

Unknown metric groups

API count

id	before	after	diff
`triggersActionsUi`	592	593	+1

History

💚 Build #241556 succeeded 1dcc346
💔 Build #241476 failed 5d4f152
💚 Build #241160 succeeded d41cd86

cc @adcoelho

kibanamachine · 2024-10-14T11:25:46Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11326568180

…serverless (elastic#195763) Fixes elastic#195599 ## Summary This PR ensures that we can use templates in the case action when: 1. the project is serverless security, and 2. the rule is created in stack management ### How to test 1. Add the following line to `serverless.yml` - `xpack.cloud.serverless.project_id: test-123` 3. Start Elastic search in serverless security mode - `yarn es serverless --projectType security` 4. Start Kibana in serverless security mode - `yarn start --serverless=security` 5. Go to Security > Cases > Settings and add a template. 6. Go to stack and create a rule with the case action. 7. Confirm the template created in step 5 can be selected. <img width="586" alt="Screenshot 2024-10-10 at 15 00 46" src="https://github.com/user-attachments/assets/5379e1d1-f0eb-4829-9604-ee5a0e3d050b"> **Please double-check also that the templates in the case action still work as expected in normal scenarios.** --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 97322a8)

kibanamachine · 2024-10-14T11:30:19Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…urity serverless (#195763) (#196110) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Rules] Fix case action templates in stack for security serverless (#195763)](#195763)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Antonio <[email protected]>

adcoelho added 2 commits October 10, 2024 13:30

Initial commit

758185c

Tests.

0c71513

adcoelho self-assigned this Oct 10, 2024

adcoelho requested a review from a team as a code owner October 10, 2024 13:02

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

d41cd86

…fix'

cnasikas added v8.16.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 10, 2024

js-jankisalvi approved these changes Oct 10, 2024

View reviewed changes

cnasikas approved these changes Oct 11, 2024

View reviewed changes

PR comments.

5d4f152

adcoelho added 2 commits October 11, 2024 13:28

Merge branch 'main' into fix-template-case-action-bug

1dcc346

Merge branch 'main' into fix-template-case-action-bug

5d73274

adcoelho merged commit 97322a8 into elastic:main Oct 14, 2024
24 checks passed

kibanamachine mentioned this pull request Oct 14, 2024

[8.x] [ResponseOps][Rules] Fix case action templates in stack for security serverless (#195763) #196110

Merged

kibanamachine mentioned this pull request Oct 14, 2024

[Cloud Posture] Adding CSP 3P support callout for Wiz integration #196025

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ResponseOps][Rules] Fix case action templates in stack for security serverless #195763

[ResponseOps][Rules] Fix case action templates in stack for security serverless #195763

adcoelho commented Oct 10, 2024 •

edited by kibanamachine

Loading

elasticmachine commented Oct 10, 2024

elasticmachine commented Oct 10, 2024

js-jankisalvi left a comment •

edited

Loading

cnasikas Oct 11, 2024

adcoelho Oct 11, 2024

cnasikas Oct 11, 2024

adcoelho Oct 11, 2024 •

edited

Loading

cnasikas Oct 11, 2024 •

edited

Loading

adcoelho commented Oct 11, 2024

elasticmachine commented Oct 14, 2024

API count

kibanamachine commented Oct 14, 2024

kibanamachine commented Oct 14, 2024

[ResponseOps][Rules] Fix case action templates in stack for security serverless #195763

[ResponseOps][Rules] Fix case action templates in stack for security serverless #195763

Conversation

adcoelho commented Oct 10, 2024 • edited by kibanamachine Loading

Summary

How to test

elasticmachine commented Oct 10, 2024

elasticmachine commented Oct 10, 2024

js-jankisalvi left a comment • edited Loading

Choose a reason for hiding this comment

cnasikas Oct 11, 2024

Choose a reason for hiding this comment

adcoelho Oct 11, 2024

Choose a reason for hiding this comment

cnasikas Oct 11, 2024

Choose a reason for hiding this comment

adcoelho Oct 11, 2024 • edited Loading

Choose a reason for hiding this comment

cnasikas Oct 11, 2024 • edited Loading

Choose a reason for hiding this comment

adcoelho commented Oct 11, 2024

elasticmachine commented Oct 14, 2024

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

History

kibanamachine commented Oct 14, 2024

kibanamachine commented Oct 14, 2024

💚 All backports created successfully

Questions ?

adcoelho commented Oct 10, 2024 •

edited by kibanamachine

Loading

js-jankisalvi left a comment •

edited

Loading

adcoelho Oct 11, 2024 •

edited

Loading

cnasikas Oct 11, 2024 •

edited

Loading