[ES|QL] handle snapshot-only functions #195691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdaemon
added
release_note:skip
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
|
Pinging @elastic/kibana-esql (Team:ESQL) |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11294266964 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 11, 2024
## Summary Close elastic#192712 Snapshot-only functions are no longer suggested by the editor, though they are still validated if typed. Also, they are excluded from the inline function documentation. ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 65df028)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 11, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[ES|QL] handle snapshot-only functions (#195691)](#195691) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Drew Tate","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-11T14:34:13Z","message":"[ES|QL] handle snapshot-only functions (#195691)\n\n## Summary\r\n\r\nClose https://github.com/elastic/kibana/issues/192712\r\n\r\nSnapshot-only functions are no longer suggested by the editor, though\r\nthey are still validated if typed.\r\n\r\nAlso, they are excluded from the inline function documentation.\r\n\r\n### Checklist\r\n\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"65df0280e1c96a9cc8b88f77ed0aca23190f7537","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Feature:ES|QL","Team:ESQL"],"title":"[ES|QL] handle snapshot-only functions","number":195691,"url":"https://github.com/elastic/kibana/pull/195691","mergeCommit":{"message":"[ES|QL] handle snapshot-only functions (#195691)\n\n## Summary\r\n\r\nClose https://github.com/elastic/kibana/issues/192712\r\n\r\nSnapshot-only functions are no longer suggested by the editor, though\r\nthey are still validated if typed.\r\n\r\nAlso, they are excluded from the inline function documentation.\r\n\r\n### Checklist\r\n\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"65df0280e1c96a9cc8b88f77ed0aca23190f7537"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195691","number":195691,"mergeCommit":{"message":"[ES|QL] handle snapshot-only functions (#195691)\n\n## Summary\r\n\r\nClose https://github.com/elastic/kibana/issues/192712\r\n\r\nSnapshot-only functions are no longer suggested by the editor, though\r\nthey are still validated if typed.\r\n\r\nAlso, they are excluded from the inline function documentation.\r\n\r\n### Checklist\r\n\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"65df0280e1c96a9cc8b88f77ed0aca23190f7537"}}]}] BACKPORT--> Co-authored-by: Drew Tate <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #192712
Snapshot-only functions are no longer suggested by the editor, though they are still validated if typed.
Also, they are excluded from the inline function documentation.
Checklist