-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataUsage][Serverless] Data usage metrics page enhancements #195556
Merged
ashokaditya
merged 20 commits into
elastic:main
from
ashokaditya:feat/data-usage-metrics-ux-api-192965-192966
Oct 14, 2024
+1,083
−230
Merged
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
e0d9128
refactor page vs component logic
ashokaditya 547ace0
add data streams filter
ashokaditya 78a9ceb
use metering stats instead to get data streams list
ashokaditya dfaf1e5
[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'
kibanamachine 0e613d3
Merge branch 'main' into feat/data-usage-metrics-ux-api-192965-192966
ashokaditya 8489b66
Merge branch 'main' into feat/data-usage-metrics-ux-api-192965-192966
ashokaditya b68a3fa
fix checks
ashokaditya 06be6d8
fix bad merge
ashokaditya d6c9c79
remove `clear all` as payload is required
ashokaditya 92e60db
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine 1790cda
Revert "remove `clear all` as payload is required"
ashokaditya ba31edd
fix type imports
ashokaditya 94aa478
add a callout when no data streams selected
ashokaditya 9f32e32
hide metrics filter for now
ashokaditya dc2587a
comment
ashokaditya 6c1d4a8
remove console.log
ashokaditya e7f32cd
fix
ashokaditya 68369f4
Merge branch 'main' into feat/data-usage-metrics-ux-api-192965-192966
ashokaditya d9fe7a3
fix
ashokaditya f9b4718
cleanup schema
ashokaditya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neptunian I copied some of this from x-pack/plugins/index_management/server/routes/api/data_streams/register_get_route.ts#L90.
Do you happen to know how
asSecondaryAuthUser
is different fromasCurrentUser
. I also tried withasCurrentUser
here and it yields the same set of datastreams/data. I'm not sure if we should just useasCurrentUser
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question. Lets ask @elastic/kibana-management .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mattkime! Do you or anyone on your team happen to know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting up to speed on this but to answer your direct question - https://github.com/elastic/kibana/blob/main/packages/core/elasticsearch/core-elasticsearch-server/src/client/scoped_cluster_client.ts#L28
I doubt my above comment was useful so I'll just report what Alison shared in chat - #190131 (comment)