[Fields Metadata] Improve integration fields resolution and caching #195405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyghiani
added
release_note:skip
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
|
@elasticmachine merge upstream |
|
There are no new commits on the base branch. |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Public APIs missing exports
History
|
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11325496009 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 14, 2024
…lastic#195405) ## 📓 Summary Browsing fields from the Discover sidebar, I noticed integration fields never show a related description even if they exist. The same is happening in the fields table for the document detail flyout. This happens due to `integration` and `dataset` parameters not being passed to the service. https://github.com/user-attachments/assets/0946cc71-44fb-4fc7-8e9d-b146bdd811f2 These changes improve the resolution of the integration field metadata: - The `integration` and `dataset` params are no longer required to attempt resolving and integration field metadata. They are still accepted as an explicit hint in case we cannot infer correctly some integration packages from the field name. - The above change enables querying fields from different integrations and datasets at once, enabling metadata retrieval for mixed data sources. - The integration retrieved from the EPR is now cached with its relevant version, solving a potential corner case as explained [here](elastic#183806 (review)). https://github.com/user-attachments/assets/ae9cafd8-2581-4ce0-9242-cbb4e37c7702 --------- Co-authored-by: Marco Antonio Ghiani <[email protected]> (cherry picked from commit 2b7c72c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 14, 2024
…hing (#195405) (#196086) # Backport This will backport the following commits from `main` to `8.x`: - [[Fields Metadata] Improve integration fields resolution and caching (#195405)](#195405) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Antonio Ghiani","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T10:15:36Z","message":"[Fields Metadata] Improve integration fields resolution and caching (#195405)\n\n## 📓 Summary\r\n\r\nBrowsing fields from the Discover sidebar, I noticed integration fields\r\nnever show a related description even if they exist. The same is\r\nhappening in the fields table for the document detail flyout.\r\n\r\nThis happens due to `integration` and `dataset` parameters not being\r\npassed to the service.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/0946cc71-44fb-4fc7-8e9d-b146bdd811f2\r\n\r\nThese changes improve the resolution of the integration field metadata:\r\n\r\n- The `integration` and `dataset` params are no longer required to\r\nattempt resolving and integration field metadata.\r\nThey are still accepted as an explicit hint in case we cannot infer\r\ncorrectly some integration packages from the field name.\r\n- The above change enables querying fields from different integrations\r\nand datasets at once, enabling metadata retrieval for mixed data\r\nsources.\r\n- The integration retrieved from the EPR is now cached with its relevant\r\nversion, solving a potential corner case as explained\r\n[here](https://github.com/elastic/kibana/pull/183806#pullrequestreview-2088102130).\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ae9cafd8-2581-4ce0-9242-cbb4e37c7702\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"2b7c72c6193cf46c5cf883dafb8521f4a6805cd4","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","Team:obs-ux-logs"],"title":"[Fields Metadata] Improve integration fields resolution and caching","number":195405,"url":"https://github.com/elastic/kibana/pull/195405","mergeCommit":{"message":"[Fields Metadata] Improve integration fields resolution and caching (#195405)\n\n## 📓 Summary\r\n\r\nBrowsing fields from the Discover sidebar, I noticed integration fields\r\nnever show a related description even if they exist. The same is\r\nhappening in the fields table for the document detail flyout.\r\n\r\nThis happens due to `integration` and `dataset` parameters not being\r\npassed to the service.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/0946cc71-44fb-4fc7-8e9d-b146bdd811f2\r\n\r\nThese changes improve the resolution of the integration field metadata:\r\n\r\n- The `integration` and `dataset` params are no longer required to\r\nattempt resolving and integration field metadata.\r\nThey are still accepted as an explicit hint in case we cannot infer\r\ncorrectly some integration packages from the field name.\r\n- The above change enables querying fields from different integrations\r\nand datasets at once, enabling metadata retrieval for mixed data\r\nsources.\r\n- The integration retrieved from the EPR is now cached with its relevant\r\nversion, solving a potential corner case as explained\r\n[here](https://github.com/elastic/kibana/pull/183806#pullrequestreview-2088102130).\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ae9cafd8-2581-4ce0-9242-cbb4e37c7702\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"2b7c72c6193cf46c5cf883dafb8521f4a6805cd4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195405","number":195405,"mergeCommit":{"message":"[Fields Metadata] Improve integration fields resolution and caching (#195405)\n\n## 📓 Summary\r\n\r\nBrowsing fields from the Discover sidebar, I noticed integration fields\r\nnever show a related description even if they exist. The same is\r\nhappening in the fields table for the document detail flyout.\r\n\r\nThis happens due to `integration` and `dataset` parameters not being\r\npassed to the service.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/0946cc71-44fb-4fc7-8e9d-b146bdd811f2\r\n\r\nThese changes improve the resolution of the integration field metadata:\r\n\r\n- The `integration` and `dataset` params are no longer required to\r\nattempt resolving and integration field metadata.\r\nThey are still accepted as an explicit hint in case we cannot infer\r\ncorrectly some integration packages from the field name.\r\n- The above change enables querying fields from different integrations\r\nand datasets at once, enabling metadata retrieval for mixed data\r\nsources.\r\n- The integration retrieved from the EPR is now cached with its relevant\r\nversion, solving a potential corner case as explained\r\n[here](https://github.com/elastic/kibana/pull/183806#pullrequestreview-2088102130).\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ae9cafd8-2581-4ce0-9242-cbb4e37c7702\r\n\r\n---------\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"2b7c72c6193cf46c5cf883dafb8521f4a6805cd4"}}]}] BACKPORT--> Co-authored-by: Marco Antonio Ghiani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 Summary
Browsing fields from the Discover sidebar, I noticed integration fields never show a related description even if they exist. The same is happening in the fields table for the document detail flyout.
This happens due to
integrationanddatasetparameters not being passed to the service.Screen.Recording.2024-10-08.at.14.59.13.mov
These changes improve the resolution of the integration field metadata:
integrationanddatasetparams are no longer required to attempt resolving and integration field metadata.They are still accepted as an explicit hint in case we cannot infer correctly some integration packages from the field name.
Screen.Recording.2024-10-08.at.15.09.14.mov