-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Onboarding][Auto-detect] Update design for supported integrations badges #195351
[Onboarding][Auto-detect] Update design for supported integrations badges #195351
Conversation
content={ | ||
<EuiText size="s"> | ||
<ul> | ||
{SUPPORTED_INTEGRATIONS_LIST.map((integration) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the tooltip only list the ones that are not already spelled out individually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took this from the desings. At first I thought the same, that it should have only the remaining services, but it seems convenient to have the full list in one place, I suspect that was the logic behind the designs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, no worries then :)
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Unknown metric groupsmiscellaneous assets size
History
|
Starting backport for target branches: 8.15, 8.x https://github.com/elastic/kibana/actions/runs/11327308701 |
…dges (elastic#195351) Closes elastic/observability-dev#4007 Updates integration badges according to [the latest designs](https://www.figma.com/design/CPhMyRNOgo0wsEiaIMZJ14/Onboarding-Quick-Starts?node-id=3015-58062&t=5tvnrPIOkfg7xAJp-1). ![CleanShot 2024-10-08 at 08 57 48@2x](https://github.com/user-attachments/assets/1ae0d9d7-3b1f-4acd-b16f-ad1cbc09db88) (cherry picked from commit 0226634)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
…ons badges (#195351) (#196124) # Backport This will backport the following commits from `main` to `8.x`: - [[Onboarding][Auto-detect] Update design for supported integrations badges (#195351)](#195351) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Mykola Harmash","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T12:14:23Z","message":"[Onboarding][Auto-detect] Update design for supported integrations badges (#195351)\n\nCloses https://github.com/elastic/observability-dev/issues/4007\r\n\r\nUpdates integration badges according to [the latest\r\ndesigns](https://www.figma.com/design/CPhMyRNOgo0wsEiaIMZJ14/Onboarding-Quick-Starts?node-id=3015-58062&t=5tvnrPIOkfg7xAJp-1).\r\n\r\n![CleanShot 2024-10-08 at 08 57\r\n48@2x](https://github.com/user-attachments/assets/1ae0d9d7-3b1f-4acd-b16f-ad1cbc09db88)","sha":"02266345cb4199342867e3d9d5718090297f5700","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","v8.16.0"],"title":"[Onboarding][Auto-detect] Update design for supported integrations badges","number":195351,"url":"https://github.com/elastic/kibana/pull/195351","mergeCommit":{"message":"[Onboarding][Auto-detect] Update design for supported integrations badges (#195351)\n\nCloses https://github.com/elastic/observability-dev/issues/4007\r\n\r\nUpdates integration badges according to [the latest\r\ndesigns](https://www.figma.com/design/CPhMyRNOgo0wsEiaIMZJ14/Onboarding-Quick-Starts?node-id=3015-58062&t=5tvnrPIOkfg7xAJp-1).\r\n\r\n![CleanShot 2024-10-08 at 08 57\r\n48@2x](https://github.com/user-attachments/assets/1ae0d9d7-3b1f-4acd-b16f-ad1cbc09db88)","sha":"02266345cb4199342867e3d9d5718090297f5700"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195351","number":195351,"mergeCommit":{"message":"[Onboarding][Auto-detect] Update design for supported integrations badges (#195351)\n\nCloses https://github.com/elastic/observability-dev/issues/4007\r\n\r\nUpdates integration badges according to [the latest\r\ndesigns](https://www.figma.com/design/CPhMyRNOgo0wsEiaIMZJ14/Onboarding-Quick-Starts?node-id=3015-58062&t=5tvnrPIOkfg7xAJp-1).\r\n\r\n![CleanShot 2024-10-08 at 08 57\r\n48@2x](https://github.com/user-attachments/assets/1ae0d9d7-3b1f-4acd-b16f-ad1cbc09db88)","sha":"02266345cb4199342867e3d9d5718090297f5700"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Mykola Harmash <[email protected]>
Closes https://github.com/elastic/observability-dev/issues/4007
Updates integration badges according to the latest designs.