Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Onboarding][Auto-detect] Update design for supported integrations badges #195351

Conversation

mykolaharmash
Copy link
Contributor

@mykolaharmash mykolaharmash commented Oct 8, 2024

@mykolaharmash mykolaharmash requested a review from a team as a code owner October 8, 2024 07:43
@mykolaharmash mykolaharmash requested a review from a team October 8, 2024 07:43
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Oct 8, 2024
@mykolaharmash mykolaharmash added v9.0.0 backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development v8.16.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 8, 2024
content={
<EuiText size="s">
<ul>
{SUPPORTED_INTEGRATIONS_LIST.map((integration) => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the tooltip only list the ones that are not already spelled out individually?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took this from the desings. At first I thought the same, that it should have only the remaining services, but it seems convenient to have the full list in one place, I suspect that was the logic behind the designs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, no worries then :)

@mykolaharmash mykolaharmash enabled auto-merge (squash) October 14, 2024 09:11
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 14, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 0ec0588
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-195351-0ec05881fee4

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observabilityOnboarding 256 261 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityOnboarding 281.2KB 292.4KB +11.2KB
Unknown metric groups

miscellaneous assets size

id before after diff
observabilityOnboarding 1.3MB 1.3MB +11.3KB

History

@mykolaharmash mykolaharmash merged commit 0226634 into elastic:main Oct 14, 2024
27 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.x

https://github.com/elastic/kibana/actions/runs/11327308701

@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.15 Backport failed because of merge conflicts
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 195351

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 14, 2024
…ons badges (#195351) (#196124)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Onboarding][Auto-detect] Update design for supported integrations
badges (#195351)](#195351)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Mykola
Harmash","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-14T12:14:23Z","message":"[Onboarding][Auto-detect]
Update design for supported integrations badges (#195351)\n\nCloses
https://github.com/elastic/observability-dev/issues/4007\r\n\r\nUpdates
integration badges according to [the
latest\r\ndesigns](https://www.figma.com/design/CPhMyRNOgo0wsEiaIMZJ14/Onboarding-Quick-Starts?node-id=3015-58062&t=5tvnrPIOkfg7xAJp-1).\r\n\r\n![CleanShot
2024-10-08 at 08
57\r\n48@2x](https://github.com/user-attachments/assets/1ae0d9d7-3b1f-4acd-b16f-ad1cbc09db88)","sha":"02266345cb4199342867e3d9d5718090297f5700","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","v8.16.0"],"title":"[Onboarding][Auto-detect]
Update design for supported integrations
badges","number":195351,"url":"https://github.com/elastic/kibana/pull/195351","mergeCommit":{"message":"[Onboarding][Auto-detect]
Update design for supported integrations badges (#195351)\n\nCloses
https://github.com/elastic/observability-dev/issues/4007\r\n\r\nUpdates
integration badges according to [the
latest\r\ndesigns](https://www.figma.com/design/CPhMyRNOgo0wsEiaIMZJ14/Onboarding-Quick-Starts?node-id=3015-58062&t=5tvnrPIOkfg7xAJp-1).\r\n\r\n![CleanShot
2024-10-08 at 08
57\r\n48@2x](https://github.com/user-attachments/assets/1ae0d9d7-3b1f-4acd-b16f-ad1cbc09db88)","sha":"02266345cb4199342867e3d9d5718090297f5700"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195351","number":195351,"mergeCommit":{"message":"[Onboarding][Auto-detect]
Update design for supported integrations badges (#195351)\n\nCloses
https://github.com/elastic/observability-dev/issues/4007\r\n\r\nUpdates
integration badges according to [the
latest\r\ndesigns](https://www.figma.com/design/CPhMyRNOgo0wsEiaIMZJ14/Onboarding-Quick-Starts?node-id=3015-58062&t=5tvnrPIOkfg7xAJp-1).\r\n\r\n![CleanShot
2024-10-08 at 08
57\r\n48@2x](https://github.com/user-attachments/assets/1ae0d9d7-3b1f-4acd-b16f-ad1cbc09db88)","sha":"02266345cb4199342867e3d9d5718090297f5700"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Mykola Harmash <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants