chore(slo): add access:public missing options for public routes #195114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdelemme
added
v8.16.0
backport:prev-minor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
botelastic
bot
added
the
ci:project-deploy-observability
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
maryam-saeidi
approved these changes
Oct 8, 2024
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11237499767 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 8, 2024
…tic#195114) (cherry picked from commit 8281517)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
1 task
kibanamachine
added a commit
that referenced
this pull request
Oct 8, 2024
…#195114) (#195427) # Backport This will backport the following commits from `main` to `8.x`: - [chore(slo): add access:public missing options for public routes (#195114)](#195114) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Delemme","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-08T14:21:47Z","message":"chore(slo): add access:public missing options for public routes (#195114)","sha":"8281517ef5ede44519dbb52abaf59d4f86d9396e","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0"],"title":"chore(slo): add access:public missing options for public routes","number":195114,"url":"https://github.com/elastic/kibana/pull/195114","mergeCommit":{"message":"chore(slo): add access:public missing options for public routes (#195114)","sha":"8281517ef5ede44519dbb52abaf59d4f86d9396e"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195114","number":195114,"mergeCommit":{"message":"chore(slo): add access:public missing options for public routes (#195114)","sha":"8281517ef5ede44519dbb52abaf59d4f86d9396e"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Kevin Delemme <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #192180
🌮 Summary
This PR adds the missing public access option to 2 SLO routes since in 9.x default value will be internal when no specified otherwise.
Testing
Accessing the SLO listing page should result make the call the /_definitions endpoint without error