[ML] Hide ES|QL based saved searches in ML & Transforms #195084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbrtj
added
release_note:fix
:ml
v9.0.0
Team:ML
|
Pinging @elastic/ml-ui (:ml) |
rbrtj
commented
Oct 4, 2024
| @@ -69,6 +72,9 @@ export const Page: FC<PageProps> = ({ | |||
| defaultMessage: 'Saved search', | |||
| } | |||
| ), | |||
| showSavedObject: (savedObject: SavedObject) => | |||
| // ES|QL Based saved searches are not supported across ML, filter them out | |||
There was a problem hiding this comment.
It covers:
- Data Visualizer => Data View
- AIOps Labs
- Anomaly Detection => Jobs
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @rbrtj |
3 tasks
peteharverson
approved these changes
Oct 8, 2024
| @@ -64,6 +67,9 @@ export const SearchSelection: FC<SearchSelectionProps> = ({ | |||
| defaultMessage: 'Saved search', | |||
| } | |||
| ), | |||
| showSavedObject: (savedObject: SavedObject) => | |||
There was a problem hiding this comment.
Interestingly the transform wizard used to partially work when selecting an ES|QL based saved search, successfully pulling out the index pattern from the search to use in the transform. However the other commands in the search (WHERE, RENAME, DROP etc) would be ignored, so I think this change is correct, filtering out ES|QL based saved searches until if / when the transform wizard supports the whole of the search.
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11250933204 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 9, 2024
## Summary Fix for: [elastic#187962](elastic#187962) We were displaying ES|QL based searches in various areas of ML, not just in the places mentioned in the issue. Before:  Then, after selecting the ESQL based search:  After the fix:  (cherry picked from commit 1b4ebaa)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 9, 2024
…95084) (#195541) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Hide ES|QL based saved searches in ML & Transforms (#195084)](#195084) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-09T08:14:50Z","message":"[ML] Hide ES|QL based saved searches in ML & Transforms (#195084)\n\n## Summary\r\n\r\nFix for: [#187962](https://github.com/elastic/kibana/issues/187962)\r\nWe were displaying ES|QL based searches in various areas of ML, not just\r\nin the places mentioned in the issue.\r\nBefore:\r\n\r\nThen, after selecting the ESQL based search:\r\n\r\n\r\nAfter the fix:\r\n\r\n","sha":"1b4ebaa85261074aec775d23165474863ddea45a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Team:ML","v8.16.0","backport:version"],"title":"[ML] Hide ES|QL based saved searches in ML & Transforms","number":195084,"url":"https://github.com/elastic/kibana/pull/195084","mergeCommit":{"message":"[ML] Hide ES|QL based saved searches in ML & Transforms (#195084)\n\n## Summary\r\n\r\nFix for: [#187962](https://github.com/elastic/kibana/issues/187962)\r\nWe were displaying ES|QL based searches in various areas of ML, not just\r\nin the places mentioned in the issue.\r\nBefore:\r\n\r\nThen, after selecting the ESQL based search:\r\n\r\n\r\nAfter the fix:\r\n\r\n","sha":"1b4ebaa85261074aec775d23165474863ddea45a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195084","number":195084,"mergeCommit":{"message":"[ML] Hide ES|QL based saved searches in ML & Transforms (#195084)\n\n## Summary\r\n\r\nFix for: [#187962](https://github.com/elastic/kibana/issues/187962)\r\nWe were displaying ES|QL based searches in various areas of ML, not just\r\nin the places mentioned in the issue.\r\nBefore:\r\n\r\nThen, after selecting the ESQL based search:\r\n\r\n\r\nAfter the fix:\r\n\r\n","sha":"1b4ebaa85261074aec775d23165474863ddea45a"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix for: #187962
We were displaying ES|QL based searches in various areas of ML, not just in the places mentioned in the issue.
Before:
Then, after selecting the ESQL based search:
After the fix: