Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Synthetics] Improve synthetics alerting (#186585) #194671

Merged
merged 5 commits into from
Oct 2, 2024
Merged

[8.x] [Synthetics] Improve synthetics alerting (#186585) #194671

merged 5 commits into from
Oct 2, 2024

Conversation

shahzad31
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@shahzad31
[Synthetics] Improve synthetics alerting (elastic#186585)
b40857b 
## Summary

Fixes elastic#175298

Improve synthetics alerting !!

User will be able to create custom synthetics status alert by defining
three kind of criteria

### Monitor is down over last consective checks with threshold

<img width="639" alt="image"
src="https://github.com/elastic/kibana/assets/3505601/390da238-f7f2-4eb0-9606-3279b3199fdf">

### From Locations threshold

Will be considered down only when from defined number of locations

<img width="618" alt="image"
src="https://github.com/elastic/kibana/assets/3505601/24741a10-0880-4247-9048-8ce03df25bf5">

### Over time with checks threshold just like uptime custom status alert

<img width="631" alt="image"
src="https://github.com/elastic/kibana/assets/3505601/64e1c808-8d4b-4dd0-b794-eb7f4e5d1e6b">

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Dominique Clarke <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Maryam Saeidi <[email protected]>
Co-authored-by: Justin Kambic <[email protected]>
(cherry picked from commit 82d0b00)

# Conflicts:
#	.github/CODEOWNERS
#	x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/alerts/query_bar.tsx
@shahzad31 shahzad31 enabled auto-merge (squash) October 2, 2024 09:50
@shahzad31 shahzad31 mentioned this pull request Oct 2, 2024
Merged
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Oct 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

dominiqueclarke
dominiqueclarke approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 2, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 86094af
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-194671-86094af5af0f

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
synthetics 1018 1153 +135

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/observability-synthetics-test-data - 4 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 965.5KB 1.2MB ⚠️ +237.4KB
triggersActionsUi 1.6MB 1.6MB +115.0B
total +237.5KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/observability-synthetics-test-data - 1 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
synthetics 36.9KB 37.1KB +221.0B
Unknown metric groups

API count

id before after diff
@kbn/observability-synthetics-test-data - 4 +4

ESLint disabled line counts

id before after diff
@kbn/synthetics-e2e 19 18 -1
@kbn/test-suites-xpack 720 721 +1
synthetics 49 52 +3
total +3

Total ESLint disabled count

id before after diff
@kbn/synthetics-e2e 20 19 -1
@kbn/test-suites-xpack 744 745 +1
synthetics 55 58 +3
total +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@shahzad31 shahzad31 merged commit 757e919 into elastic:8.x Oct 2, 2024
36 checks passed
@shahzad31 shahzad31 deleted the backport/8.x/pr-186585 branch October 3, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

@dominiqueclarke dominiqueclarke dominiqueclarke approved these changes

Assignees
No one assigned
Labels
backport ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shahzad31 @elasticmachine @kibana-ci @dominiqueclarke @justinkambic