Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[UII] Fix client-side validation for agent policy timeout fields (#191674)" #194338

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

jen-huang
Copy link
Contributor

@jen-huang jen-huang commented Sep 27, 2024

Summary

Resolves #194221.

This PR reverts commit f29bf1c. Timeout fields should be clearable with undefined value or zero.

@jen-huang jen-huang added release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development labels Sep 27, 2024
@jen-huang jen-huang self-assigned this Sep 27, 2024
@jen-huang jen-huang requested a review from a team as a code owner September 27, 2024 18:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jen-huang
Copy link
Contributor Author

/ci

@jen-huang jen-huang merged commit 6792cb4 into elastic:main Sep 30, 2024
26 checks passed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.7MB 1.7MB -40.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jen-huang

@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.x

https://github.com/elastic/kibana/actions/runs/11114360369

@jen-huang jen-huang deleted the fix/194221 branch September 30, 2024 21:24
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 30, 2024
…lds (elastic#191674)" (elastic#194338)

## Summary

Resolves elastic#194221.

This PR reverts commit f29bf1c. Timeout
fields should be clearable with undefined value or zero.

(cherry picked from commit 6792cb4)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.15 Backport failed because of merge conflicts
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 194338

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 30, 2024
…timeout fields (#191674)" (#194338) (#194491)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Revert "[UII] Fix client-side validation for agent policy
timeout fields (#191674)"
(#194338)](#194338)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jen
Huang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-30T21:22:37Z","message":"Revert
\"[UII] Fix client-side validation for agent policy timeout fields
(#191674)\" (#194338)\n\n## Summary\r\n\r\nResolves #194221.\r\n\r\nThis
PR reverts commit f29bf1c.
Timeout\r\nfields should be clearable with undefined value or
zero.","sha":"6792cb4dca5adecf1a48a4d052dae603db5772e3","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Fleet","v9.0.0","backport:prev-major"],"title":"Revert
\"[UII] Fix client-side validation for agent policy timeout fields
(#191674)\"","number":194338,"url":"https://github.com/elastic/kibana/pull/194338","mergeCommit":{"message":"Revert
\"[UII] Fix client-side validation for agent policy timeout fields
(#191674)\" (#194338)\n\n## Summary\r\n\r\nResolves #194221.\r\n\r\nThis
PR reverts commit f29bf1c.
Timeout\r\nfields should be clearable with undefined value or
zero.","sha":"6792cb4dca5adecf1a48a4d052dae603db5772e3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194338","number":194338,"mergeCommit":{"message":"Revert
\"[UII] Fix client-side validation for agent policy timeout fields
(#191674)\" (#194338)\n\n## Summary\r\n\r\nResolves #194221.\r\n\r\nThis
PR reverts commit f29bf1c.
Timeout\r\nfields should be clearable with undefined value or
zero.","sha":"6792cb4dca5adecf1a48a4d052dae603db5772e3"}}]}] BACKPORT-->

Co-authored-by: Jen Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development release_note:fix Team:Fleet Team label for Observability Data Collection Fleet team v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Can't clear unenrollment timeout from agent policy
6 participants