-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dataset quality] Keeping timeframe selected when navigating to dataset details #194263
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Maybe would be great if we have 1 test to make sure that this doesn't break
As agreed I'd proceed to create a react component test for this |
b2c9e2d
to
3acc68a
Compare
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Starting backport for target branches: 8.15, 8.x https://github.com/elastic/kibana/actions/runs/11124503152 |
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
… dataset details (#194263) (#194556) # Backport This will backport the following commits from `main` to `8.x`: - [[Dataset quality] Keeping timeframe selected when navigating to dataset details (#194263)](#194263) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yngrid Coello","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-01T11:36:54Z","message":"[Dataset quality] Keeping timeframe selected when navigating to dataset details (#194263)\n\nhttps://github.com/user-attachments/assets/1042bc36-29df-4833-be53-96ee142a4d6a","sha":"1d3ab6989d1e42d0a85ffe1f7f3db316fcd011ea","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability"],"title":"[Dataset quality] Keeping timeframe selected when navigating to dataset details","number":194263,"url":"https://github.com/elastic/kibana/pull/194263","mergeCommit":{"message":"[Dataset quality] Keeping timeframe selected when navigating to dataset details (#194263)\n\nhttps://github.com/user-attachments/assets/1042bc36-29df-4833-be53-96ee142a4d6a","sha":"1d3ab6989d1e42d0a85ffe1f7f3db316fcd011ea"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194263","number":194263,"mergeCommit":{"message":"[Dataset quality] Keeping timeframe selected when navigating to dataset details (#194263)\n\nhttps://github.com/user-attachments/assets/1042bc36-29df-4833-be53-96ee142a4d6a","sha":"1d3ab6989d1e42d0a85ffe1f7f3db316fcd011ea"}}]}] BACKPORT--> Co-authored-by: Yngrid Coello <[email protected]>
Screen.Recording.2024-09-27.at.10.20.23.mov