Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset quality] Keeping timeframe selected when navigating to dataset details #194263

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Sep 27, 2024

Screen.Recording.2024-09-27.at.10.20.23.mov

@yngrdyn yngrdyn requested a review from a team as a code owner September 27, 2024 08:19
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 27, 2024
@yngrdyn yngrdyn added release_note:skip Skip the PR/issue when compiling release notes and removed ci:project-deploy-observability Create an Observability project labels Sep 27, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@yngrdyn yngrdyn added the backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development label Sep 27, 2024
Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Maybe would be great if we have 1 test to make sure that this doesn't break

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Sep 27, 2024
@yngrdyn
Copy link
Contributor Author

yngrdyn commented Sep 27, 2024

LGTM! Maybe would be great if we have 1 test to make sure that this doesn't break

As agreed I'd proceed to create a react component test for this

@yngrdyn yngrdyn force-pushed the Keeping-timeframe-selected branch from b2c9e2d to 3acc68a Compare October 1, 2024 10:10
@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 1, 2024

💛 Build succeeded, but was flaky

  • Buildkite Build
  • Commit: 3acc68a
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-194263-3acc68af01c9

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
datasetQuality 208.0KB 208.0KB +48.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yngrdyn yngrdyn enabled auto-merge (squash) October 1, 2024 11:16
@yngrdyn yngrdyn merged commit 1d3ab69 into elastic:main Oct 1, 2024
23 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.x

https://github.com/elastic/kibana/actions/runs/11124503152

@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.15 Backport failed because of merge conflicts
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 194263

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 1, 2024
… dataset details (#194263) (#194556)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Dataset quality] Keeping timeframe selected when navigating to
dataset details
(#194263)](#194263)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Yngrid
Coello","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-01T11:36:54Z","message":"[Dataset
quality] Keeping timeframe selected when navigating to dataset details
(#194263)\n\nhttps://github.com/user-attachments/assets/1042bc36-29df-4833-be53-96ee142a4d6a","sha":"1d3ab6989d1e42d0a85ffe1f7f3db316fcd011ea","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability"],"title":"[Dataset
quality] Keeping timeframe selected when navigating to dataset
details","number":194263,"url":"https://github.com/elastic/kibana/pull/194263","mergeCommit":{"message":"[Dataset
quality] Keeping timeframe selected when navigating to dataset details
(#194263)\n\nhttps://github.com/user-attachments/assets/1042bc36-29df-4833-be53-96ee142a4d6a","sha":"1d3ab6989d1e42d0a85ffe1f7f3db316fcd011ea"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194263","number":194263,"mergeCommit":{"message":"[Dataset
quality] Keeping timeframe selected when navigating to dataset details
(#194263)\n\nhttps://github.com/user-attachments/assets/1042bc36-29df-4833-be53-96ee142a4d6a","sha":"1d3ab6989d1e42d0a85ffe1f7f3db316fcd011ea"}}]}]
BACKPORT-->

Co-authored-by: Yngrid Coello <[email protected]>
@yngrdyn yngrdyn self-assigned this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants