Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Unskip vis tests #194020

Merged
merged 2 commits into from
Sep 26, 2024
Merged

[Discover] Unskip vis tests #194020

merged 2 commits into from
Sep 26, 2024

Conversation

jughosta
Copy link
Contributor

@jughosta jughosta commented Sep 25, 2024 •
edited by kibanamachine
Loading

@jughosta jughosta self-assigned this Sep 25, 2024
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#7013

[❌] test/functional/apps/discover/group3/config.ts: 0/25 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7014

[✅] test/functional/apps/discover/group3/config.ts: 25/25 tests passed.

see run history

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Sep 25, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@jughosta jughosta marked this pull request as ready for review September 25, 2024 20:38
@jughosta jughosta requested a review from a team as a code owner September 25, 2024 20:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

kertal
kertal approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thx for taking care of it 🙏

@jughosta jughosta merged commit e1f90cc into elastic:main Sep 26, 2024
22 checks passed
@jughosta jughosta deleted the 184600-unskip-vis-tests branch September 26, 2024 11:36
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 26, 2024
@jughosta
[Discover] Unskip vis tests (elastic#194020)
5d315b4 
- Closees elastic#184600

(cherry picked from commit e1f90cc)
@kibanamachine kibanamachine mentioned this pull request Sep 26, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 26, 2024
@kibanamachine @jughosta
[8.x] [Discover] Unskip vis tests (#194020) (#194121)
f913d39 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Discover] Unskip vis tests
(#194020)](#194020)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-26T11:36:41Z","message":"[Discover]
Unskip vis tests (#194020)\n\n- Closees
https://github.com/elastic/kibana/issues/184600","sha":"e1f90cc39342e668f1831271f3a6b8fc47411e74","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor"],"title":"[Discover]
Unskip vis
tests","number":194020,"url":"https://github.com/elastic/kibana/pull/194020","mergeCommit":{"message":"[Discover]
Unskip vis tests (#194020)\n\n- Closees
https://github.com/elastic/kibana/issues/184600","sha":"e1f90cc39342e668f1831271f3a6b8fc47411e74"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194020","number":194020,"mergeCommit":{"message":"[Discover]
Unskip vis tests (#194020)\n\n- Closees
https://github.com/elastic/kibana/issues/184600","sha":"e1f90cc39342e668f1831271f3a6b8fc47411e74"}}]}]
BACKPORT-->

Co-authored-by: Julia Rechkunova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

Assignees

@jughosta jughosta

Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jughosta @kibanamachine @kibana-ci @elasticmachine @kertal