Don't allow sorting on geo_point #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In discover, if you add a field of type geo_point to your search, and then try to sort on that field, the app errors out. It doesn't make sense to allow sorting on geo_point as this is not supported by ElasticSearch. Perhaps in the future we can allow sorting geo_point by distance from a given location.
| @@ -14,9 +14,13 @@ define(function (require) { | |||
| }, | |||
| template: headerHtml, | |||
| controller: function ($scope) { | |||
| var sortableField = function (field) { | |||
| var mapping = $scope.mapping[field]; | |||
| return mapping && mapping.indexed && mapping.type !== 'geo_point'; | |||
There was a problem hiding this comment.
What if we changed mapping.type !== 'geo_point' to !_.contains(unsortableTypes, mapping.type) and then add a variable above with an array of the un-sortable types... then we can add more later.
|
With changes... LGTM |
lukasolson
added a commit
that referenced
this pull request
Nov 19, 2014
Don't allow sorting on unsortable field types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In discover, if you add a field of type
geo_pointto your search, and then try to sort on that field, the app errors out. It doesn't make sense to allow sorting on geo_point as this is not supported by ElasticSearch. Perhaps in the future we can allow sortinggeo_pointfields by distance from a specified location.Closes #1933.