[Dataset quality] Adding size column and estimated size to serverless #193998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
yngrdyn
added
release_note:skip
|
I remember there were a couple of checks on the UI as well, do we need to clean them up ? |
…ess' of github.com:yngrdyn/kibana into 179-dataset-quality-display-size-information-in-serverless
mohamedhamed-ahmed
approved these changes
Sep 30, 2024
| @@ -26,10 +26,9 @@ export const useOverviewSummaryPanel = () => { | |||
| .map((key: string) => services[key].length) | |||
| .reduce((a, b) => a + b, 0); | |||
|
|
|||
| const totalDocsCount = formatNumber(dataStreamDetails?.docsCount ?? 0, NUMBER_FORMAT); | |||
| const totalDocsCount = formatNumber(dataStreamDetails.docsCount, NUMBER_FORMAT); | |||
There was a problem hiding this comment.
qq: could it happen that docsCount be undefined? I can see this in the type definition but not sure if this is possible. In this case the formatNumber function returns an empty string, is this what we want to display on the UI?
There was a problem hiding this comment.
According to this line docsCount will always be a number, in the worst case scenario (no documents) it will be 0.
mohamedhamed-ahmed
approved these changes
Sep 30, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11121121947 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 1, 2024
…elastic#193998) Closes elastic/logs-dev#179. This PR aims to enable: The estimated size is displayed in Serverless in the following areas: - Estimated and size column in main page - Size in Overview section of Dataset details ### Demo https://github.com/user-attachments/assets/b0ef03fb-061d-44e5-8e1a-c47ece58de37 (cherry picked from commit ea98506)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 1, 2024
…erless (#193998) (#194520) # Backport This will backport the following commits from `main` to `8.x`: - [[Dataset quality] Adding size column and estimated size to serverless (#193998)](#193998) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Yngrid Coello","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-01T08:01:22Z","message":"[Dataset quality] Adding size column and estimated size to serverless (#193998)\n\nCloses https://github.com/elastic/logs-dev/issues/179.\r\n\r\nThis PR aims to enable:\r\nThe estimated size is displayed in Serverless in the following areas:\r\n- Estimated and size column in main page\r\n- Size in Overview section of Dataset details\r\n\r\n### Demo\r\n\r\nhttps://github.com/user-attachments/assets/b0ef03fb-061d-44e5-8e1a-c47ece58de37","sha":"ea9850683a2b24ede2b792717eb6c2ed9271777d","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability"],"title":"[Dataset quality] Adding size column and estimated size to serverless","number":193998,"url":"https://github.com/elastic/kibana/pull/193998","mergeCommit":{"message":"[Dataset quality] Adding size column and estimated size to serverless (#193998)\n\nCloses https://github.com/elastic/logs-dev/issues/179.\r\n\r\nThis PR aims to enable:\r\nThe estimated size is displayed in Serverless in the following areas:\r\n- Estimated and size column in main page\r\n- Size in Overview section of Dataset details\r\n\r\n### Demo\r\n\r\nhttps://github.com/user-attachments/assets/b0ef03fb-061d-44e5-8e1a-c47ece58de37","sha":"ea9850683a2b24ede2b792717eb6c2ed9271777d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193998","number":193998,"mergeCommit":{"message":"[Dataset quality] Adding size column and estimated size to serverless (#193998)\n\nCloses https://github.com/elastic/logs-dev/issues/179.\r\n\r\nThis PR aims to enable:\r\nThe estimated size is displayed in Serverless in the following areas:\r\n- Estimated and size column in main page\r\n- Size in Overview section of Dataset details\r\n\r\n### Demo\r\n\r\nhttps://github.com/user-attachments/assets/b0ef03fb-061d-44e5-8e1a-c47ece58de37","sha":"ea9850683a2b24ede2b792717eb6c2ed9271777d"}}]}] BACKPORT--> Co-authored-by: Yngrid Coello <[email protected]>
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/elastic/logs-dev/issues/179.
This PR aims to enable:
The estimated size is displayed in Serverless in the following areas:
Demo
Screen.Recording.2024-09-25.at.15.12.41.mov